drm: Destroy the correct mutex name in drm_dp_mst_topology_mgr_destroy
Subsystems (2)
PATCH 1/1 drm: Destroy the correct mutex name in drm_dp_mst_topology_mgr_destroy
It looks like one of the topology manager mutexes may have been renamed during a rebase, but the destruction function wasn't updated with the new name:
error: ‘struct drm_dp_mst_topology_mgr’ has no member named ‘delayed_destroy_lock’
Fixes 50094b5dcd32 ("drm/dp_mst: Destroy topology_mgr mutexes")
Cc Lyude Paul <[email protected]>
Cc Sean Paul <[email protected]>
Signed-off-by Matt Roper <[email protected]>
--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_dp_mst_topology.c +1 -1
@@ -4301,7 +4301,7 @@ void drm_dp_mst_topology_mgr_destroy(struct drm_dp_mst_topology_mgr *mgr)drm_atomic_private_obj_fini (&mgr->base); mgr->funcs =NULL ; -mutex_destroy (&mgr->delayed_destroy_lock); +mutex_destroy (&mgr->destroy_connector_lock);mutex_destroy (&mgr->payload_lock);mutex_destroy (&mgr->qlock);mutex_destroy (&mgr->lock);
Signature · 6 lines
2.21.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
UGH this is entirely my fault, sorry about that. This reference got left in when I cherry-picked this patch from a different series.
Reviewed-by Lyude Paul <[email protected]>
Feel free to push right away
Quoted 30 lines · Matt Roper
It looks like one of the topology manager mutexes may have been renamed during a rebase, but the destruction function wasn't updated with the new name:
error: ‘struct drm_dp_mst_topology_mgr’ has no member named ‘delayed_destroy_lock’
Fixes 50094b5dcd32 ("drm/dp_mst: Destroy topology_mgr mutexes")Cc Lyude Paul <[email protected]>Cc Sean Paul <[email protected]>Signed-off-by Matt Roper <[email protected]>--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_dp_mst_topology.c +1
-1@@ -4301,7 +4301,7 @@ void drm_dp_mst_topology_mgr_destroy(struct drm_dp_mst_topology_mgr *mgr) drm_atomic_private_obj_fini(&mgr->base); mgr->funcs =NULL ; -mutex_destroy (&mgr->delayed_destroy_lock); +mutex_destroy (&mgr->destroy_connector_lock);mutex_destroy (&mgr->payload_lock);mutex_destroy (&mgr->qlock);
mutex_destroy(&mgr->lock);
Signature · 7 lines
Cheers, Lyude Paul _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel