Panel rotation patches
Subsystems (7)
v8 cover Panel rotation patches
This adds the plumbing for reading panel rotation from the devicetree and sets up adding a panel property for the panel orientation on Mediatek SoCs when a rotation is present.
v8 changes:
-added reviewed-by tags
-fixed conflict with i915 patch that recently landed -Added additional documentation
v7 changes:
-forgot to add static inline
v6 changes:
-added enum declaration to drm_panel.h header
v5 changes:
-rebased
v4 changes:
-fixed some changes made to the i915 driver
-clarified comments on of orientation helper
v3 changes:
-changed from attach/detach callbacks to directly setting fixed panel
values in drm_panel_attach
-removed update to Documentation
-added separate function for quirked panel orientation property init
v2 changes:
fixed build errors in i915
Derek Basehore (4):
drm/panel: Add helper for reading DT rotation drm/panel: set display info in panel attach drm/connector: Split out orientation quirk detection drm/mtk: add panel orientation property
drivers/gpu/drm/drm_connector.c | 45 ++++++++++++++----- drivers/gpu/drm/drm_panel.c | 70 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dp.c | 4 +- drivers/gpu/drm/i915/vlv_dsi.c | 5 +-- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++ include/drm/drm_connector.h | 2 + include/drm/drm_panel.h | 21 +++++++++ 7 files changed, 138 insertions(+), 17 deletions(-)
Signature · 1 line
2.22.0.410.gd8fdbe21b5-goog
PATCH v8 1/4 drm/panel: Add helper for reading DT rotation
This adds a helper function for reading the rotation (panel orientation) from the device tree.
--- drivers/gpu/drm/drm_panel.c | 43 +++++++++++++++++++++++++++++++++++++ include/drm/drm_panel.h | 9 ++++++++ 2 files changed, 52 insertions(+)
drivers/gpu/drm/drm_panel.c +43 -0
@@ -264,6 +264,49 @@ struct drm_panel *of_drm_find_panel(const struct device_node *np)return ERR_PTR (-EPROBE_DEFER ); }EXPORT_SYMBOL (of_drm_find_panel); + +/** +* of_drm_get_panel_orientation - look up the orientation of the panel through +* the "rotation" binding from a device tree node +* @np: device tree node of the panel +* @orientation: orientation enum to be filled in +* +* Looks up the rotation of a panel in the device tree. The orientation of the +* panel is expressed as a property name "rotation" in the device tree. The +* rotation in the device tree is counter clockwise. +* +* Return: 0 when a valid rotation value (0, 90, 180, or 270) is read or the +* rotation property doesn't exist. -EERROR otherwise. +*/ +int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation) +{ +int rotation, ret; + + ret =of_property_read_u32 (np,"rotation" , &rotation); +if (ret == -EINVAL ) { +/* Don't return an error if there's no rotation property. */ + *orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; +return 0 ; + } + +if (ret <0 ) +return ret; + +if (rotation ==0 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_NORMAL ; +else if (rotation ==90 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_RIGHT_UP ; +else if (rotation ==180 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP ; +else if (rotation ==270 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_LEFT_UP ; +else +return -EINVAL ; + +return 0 ; +} +EXPORT_SYMBOL (of_drm_get_panel_orientation);#endif MODULE_AUTHOR ("Thierry Reding <[email protected]>" );
include/drm/drm_panel.h +9 -0
@@ -34,6 +34,8 @@ struct drm_device;struct drm_panel ;struct display_timing ; +enum drm_panel_orientation ; +/** * struct drm_panel_funcs - perform operations on a given panel *
@@ -165,11 +167,18 @@ int drm_panel_get_modes(struct drm_panel *panel);#if defined(CONFIG_OF ) && defined(CONFIG_DRM_PANEL )struct drm_panel *of_drm_find_panel (const struct device_node *np); +int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation);#else static inline struct drm_panel *of_drm_find_panel (const struct device_node *np) {return ERR_PTR (-ENODEV ); } +static inline int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation) +{ +return -ENODEV ; +}#endif #endif
Signature · 6 lines
2.23.0.351.gc4317032e6-goog _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v8 1/4] drm/panel: Add helper for reading DT rotation
Quoted 5 lines · Derek Basehore
This adds a helper function for reading the rotation (panel orientation) from the device tree.
Signed-off-by Derek Basehore <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>
The patch LGTM, but I don't see it used anywhere later in the patch? Is there a panel driver incoming?
Sean
Quoted 94 lines
--- drivers/gpu/drm/drm_panel.c | 43 +++++++++++++++++++++++++++++++++++++ include/drm/drm_panel.h | 9 ++++++++ 2 files changed, 52 insertions(+)drivers/gpu/drm/drm_panel.c +43
-0@@ -264,6 +264,49 @@ struct drm_panel *of_drm_find_panel(const struct device_node *np)return ERR_PTR (-EPROBE_DEFER ); }EXPORT_SYMBOL (of_drm_find_panel); + +/** +* of_drm_get_panel_orientation - look up the orientation of the panel through +* the "rotation" binding from a device tree node +* @np: device tree node of the panel +* @orientation: orientation enum to be filled in +* +* Looks up the rotation of a panel in the device tree. The orientation of the +* panel is expressed as a property name "rotation" in the device tree. The +* rotation in the device tree is counter clockwise. +* +* Return: 0 when a valid rotation value (0, 90, 180, or 270) is read or the +* rotation property doesn't exist. -EERROR otherwise. +*/ +int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation) +{ +int rotation, ret; + + ret =of_property_read_u32 (np,"rotation" , &rotation); +if (ret == -EINVAL ) { +/* Don't return an error if there's no rotation property. */ + *orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; +return 0 ; + } + +if (ret <0 ) +return ret; + +if (rotation ==0 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_NORMAL ; +else if (rotation ==90 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_RIGHT_UP ; +else if (rotation ==180 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP ; +else if (rotation ==270 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_LEFT_UP ; +else +return -EINVAL ; + +return 0 ; +} +EXPORT_SYMBOL (of_drm_get_panel_orientation);#endif MODULE_AUTHOR ("Thierry Reding <[email protected]>" );include/drm/drm_panel.h +9
-0@@ -34,6 +34,8 @@ struct drm_device;struct drm_panel ;struct display_timing ; +enum drm_panel_orientation ; +/** * struct drm_panel_funcs - perform operations on a given panel * @@ -165,11 +167,18 @@ int drm_panel_get_modes(struct drm_panel *panel);#if defined(CONFIG_OF ) && defined(CONFIG_DRM_PANEL )struct drm_panel *of_drm_find_panel (const struct device_node *np); +int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation);#else static inline struct drm_panel *of_drm_find_panel (const struct device_node *np) {return ERR_PTR (-ENODEV ); } +static inline int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation) +{ +return -ENODEV ; +}#endif #endif Signature · 1 line
2.23.0.351.gc4317032e6-goog
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v8 1/4] drm/panel: Add helper for reading DT rotation
Quoted 10 lines · Sean Paul
Quoted 5 lines · Derek Basehore
This adds a helper function for reading the rotation (panel orientation) from the device tree.
Signed-off-by Derek Basehore <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>The patch LGTM, but I don't see it used anywhere later in the patch? Is there a panel driver incoming?
Yeah, the boe-tv101wum-nl6 panel will use it. It's not in the patch currently sent upstream since I don't want to step on their toes, but I plan on sending a patch to add it as soon as that is merged.
I could hold back on this patch until that panel driver is merged too. Another alternative is to throw this into the generic drm_panel code, but there's no obvious place to put it since DRM seems to leave reading the DTS up to the panel drivers themselves.
Quoted 100 lines
Sean
Quoted 92 lines
--- drivers/gpu/drm/drm_panel.c | 43 +++++++++++++++++++++++++++++++++++++ include/drm/drm_panel.h | 9 ++++++++ 2 files changed, 52 insertions(+)drivers/gpu/drm/drm_panel.c +43
-0@@ -264,6 +264,49 @@ struct drm_panel *of_drm_find_panel(const struct device_node *np)return ERR_PTR (-EPROBE_DEFER ); }EXPORT_SYMBOL (of_drm_find_panel); + +/** +* of_drm_get_panel_orientation - look up the orientation of the panel through +* the "rotation" binding from a device tree node +* @np: device tree node of the panel +* @orientation: orientation enum to be filled in +* +* Looks up the rotation of a panel in the device tree. The orientation of the +* panel is expressed as a property name "rotation" in the device tree. The +* rotation in the device tree is counter clockwise. +* +* Return: 0 when a valid rotation value (0, 90, 180, or 270) is read or the +* rotation property doesn't exist. -EERROR otherwise. +*/ +int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation) +{ +int rotation, ret; + + ret =of_property_read_u32 (np,"rotation" , &rotation); +if (ret == -EINVAL ) { +/* Don't return an error if there's no rotation property. */ + *orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; +return 0 ; + } + +if (ret <0 ) +return ret; + +if (rotation ==0 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_NORMAL ; +else if (rotation ==90 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_RIGHT_UP ; +else if (rotation ==180 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP ; +else if (rotation ==270 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_LEFT_UP ; +else +return -EINVAL ; + +return 0 ; +} +EXPORT_SYMBOL (of_drm_get_panel_orientation);#endif MODULE_AUTHOR ("Thierry Reding <[email protected]>" );include/drm/drm_panel.h +9
-1@@ -34,6 +34,8 @@ struct drm_device;struct drm_panel ;struct display_timing ; +enum drm_panel_orientation ; +/** * struct drm_panel_funcs - perform operations on a given panel * @@ -165,11 +167,18 @@ int drm_panel_get_modes(struct drm_panel *panel);#if defined(CONFIG_OF ) && defined(CONFIG_DRM_PANEL )struct drm_panel *of_drm_find_panel (const struct device_node *np); +int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation);#else static inline struct drm_panel *of_drm_find_panel (const struct device_node *np) {return ERR_PTR (-ENODEV ); } +static inline int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation) +{ +return -ENODEV ; +}#endif #endif --Quoted 2 lines
2.23.0.351.gc4317032e6-goog
--
Sean Paul, Software Engineer, Google / Chromium OS
Re: [PATCH v8 1/4] drm/panel: Add helper for reading DT rotation
Quoted 9 lines · dbasehore .
Quoted 8 lines · Sean Paul
Quoted 5 lines · Derek Basehore
This adds a helper function for reading the rotation (panel orientation) from the device tree.
Signed-off-by Derek Basehore <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>
Quoted 8 lines
Quoted 2 lines
The patch LGTM, but I don't see it used anywhere later in the patch? Is there a panel driver incoming?
Yeah, the boe-tv101wum-nl6 panel will use it. It's not in the patch currently sent upstream since I don't want to step on their toes, but I plan on sending a patch to add it as soon as that is merged.
I could hold back on this patch until that panel driver is merged too.
Yeah, I think it's probably best. I don't anticipate any changes will be required, but it's always best to review the code end-to-end.
I haven't checked in on that review, but if it's close to landing, you can also add a patch to this stack that is based on the in-flight patches. That way we can get all the review out of the way and then when the panel lands, we can apply your add-on with the rest of the series.
Sean
Quoted 104 lines
Another alternative is to throw this into the generic
drm_panelcode, but there's no obvious place to put it since DRM seems to leave reading the DTS up to the panel drivers themselves.Quoted 100 lines
Sean
Quoted 92 lines
--- drivers/gpu/drm/drm_panel.c | 43 +++++++++++++++++++++++++++++++++++++ include/drm/drm_panel.h | 9 ++++++++ 2 files changed, 52 insertions(+)drivers/gpu/drm/drm_panel.c +43
-0@@ -264,6 +264,49 @@ struct drm_panel *of_drm_find_panel(const struct device_node *np)return ERR_PTR (-EPROBE_DEFER ); }EXPORT_SYMBOL (of_drm_find_panel); + +/** +* of_drm_get_panel_orientation - look up the orientation of the panel through +* the "rotation" binding from a device tree node +* @np: device tree node of the panel +* @orientation: orientation enum to be filled in +* +* Looks up the rotation of a panel in the device tree. The orientation of the +* panel is expressed as a property name "rotation" in the device tree. The +* rotation in the device tree is counter clockwise. +* +* Return: 0 when a valid rotation value (0, 90, 180, or 270) is read or the +* rotation property doesn't exist. -EERROR otherwise. +*/ +int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation) +{ +int rotation, ret; + + ret =of_property_read_u32 (np,"rotation" , &rotation); +if (ret == -EINVAL ) { +/* Don't return an error if there's no rotation property. */ + *orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; +return 0 ; + } + +if (ret <0 ) +return ret; + +if (rotation ==0 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_NORMAL ; +else if (rotation ==90 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_RIGHT_UP ; +else if (rotation ==180 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP ; +else if (rotation ==270 ) + *orientation =DRM_MODE_PANEL_ORIENTATION_LEFT_UP ; +else +return -EINVAL ; + +return 0 ; +} +EXPORT_SYMBOL (of_drm_get_panel_orientation);#endif MODULE_AUTHOR ("Thierry Reding <[email protected]>" );include/drm/drm_panel.h +9
-1@@ -34,6 +34,8 @@ struct drm_device;struct drm_panel ;struct display_timing ; +enum drm_panel_orientation ; +/** * struct drm_panel_funcs - perform operations on a given panel * @@ -165,11 +167,18 @@ int drm_panel_get_modes(struct drm_panel *panel);#if defined(CONFIG_OF ) && defined(CONFIG_DRM_PANEL )struct drm_panel *of_drm_find_panel (const struct device_node *np); +int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation);#else static inline struct drm_panel *of_drm_find_panel (const struct device_node *np) {return ERR_PTR (-ENODEV ); } +static inline int of_drm_get_panel_orientation (const struct device_node *np, +enum drm_panel_orientation *orientation) +{ +return -ENODEV ; +}#endif #endif --Quoted 2 lines
2.23.0.351.gc4317032e6-goog
--
Sean Paul, Software Engineer, Google / Chromium OS
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 2/4 drm/panel: set display info in panel attach
In reply to Derek BasehoreDevicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added.
To address this, this patch sets orientation, as well as other fixed values for the panel, in the drm_panel_attach function. These values are stored from probe in the drm_panel struct.
--- drivers/gpu/drm/drm_panel.c | 28 +++++++++++++++++++++ include/drm/drm_panel.h | 50 +++++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+)
drivers/gpu/drm/drm_panel.c +28 -0
@@ -104,11 +104,23 @@ EXPORT_SYMBOL(drm_panel_remove);*/ int drm_panel_attach (struct drm_panel *panel,struct drm_connector *connector) { +struct drm_display_info *info; +if (panel->connector)return -EBUSY ; panel->connector = connector; panel->drm = connector->dev; + info = &connector->display_info; + info->width_mm = panel->width_mm; + info->height_mm = panel->height_mm; + info->bpc = panel->bpc; + info->panel_orientation = panel->orientation; + info->bus_flags = panel->bus_flags; +if (panel->bus_formats) +drm_display_info_set_bus_formats (&connector->display_info, + panel->bus_formats, + panel->num_bus_formats);return 0 ; }
@@ -126,6 +138,22 @@ EXPORT_SYMBOL(drm_panel_attach);*/ void drm_panel_detach (struct drm_panel *panel) { +struct drm_display_info *info; + +if (!panel->connector) + goto out; + + info = &panel->connector->display_info; + info->width_mm =0 ; + info->height_mm =0 ; + info->bpc =0 ; + info->panel_orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; + info->bus_flags =0 ; +kfree (info->bus_formats); + info->bus_formats =NULL ; + info->num_bus_formats =0 ; + +out: panel->connector =NULL ; panel->drm =NULL ; }
include/drm/drm_panel.h +50 -0
56 lines not on this page · raw message
Signature · 1 line
2.23.0.351.gc4317032e6-goog
Re: [v8,2/4] drm/panel: set display info in panel attach
Quoted 70 lines · Derek Basehore
Devicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added.
To address this, this patch sets orientation, as well as other fixed values for the panel, in thedrm_panel_attachfunction. These values are stored from probe in thedrm_panelstruct.Signed-off-by Derek Basehore <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>--- drivers/gpu/drm/drm_panel.c | 28 +++++++++++++++++++++ include/drm/drm_panel.h | 50 +++++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+)drivers/gpu/drm/drm_panel.c +28
-0@@ -104,11 +104,23 @@ EXPORT_SYMBOL(drm_panel_remove);*/ int drm_panel_attach (struct drm_panel *panel,struct drm_connector *connector) { +struct drm_display_info *info; +if (panel->connector)return -EBUSY ; panel->connector = connector; panel->drm = connector->dev; + info = &connector->display_info; + info->width_mm = panel->width_mm; + info->height_mm = panel->height_mm; + info->bpc = panel->bpc; + info->panel_orientation = panel->orientation; + info->bus_flags = panel->bus_flags; +if (panel->bus_formats) +drm_display_info_set_bus_formats (&connector->display_info, + panel->bus_formats, + panel->num_bus_formats);return 0 ; }@@ -126,6 +138,22 @@ EXPORT_SYMBOL(drm_panel_attach);*/ void drm_panel_detach (struct drm_panel *panel) { +struct drm_display_info *info; + +if (!panel->connector) + goto out; + + info = &panel->connector->display_info; + info->width_mm =0 ; + info->height_mm =0 ; + info->bpc =0 ; + info->panel_orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; + info->bus_flags =0 ; +kfree (info->bus_formats); + info->bus_formats =NULL ; + info->num_bus_formats =0 ; + +out: panel->connector =NULL ; panel->drm =NULL ; }include/drm/drm_panel.h +0
-0
include/drm/drm_panel.h struct drm_panel { · line 143
Quoted 3 lines
include/drm/drm_panel.h +0
-0@@ -141,6 +141,56 @@ struct drm_panel {*/ const struct drm_panel_funcs *funcs;
All these new added members seems dupliated with drm_display_info, So I think, can we add a new drm_plane_funcs func:
int (*set_display_info)(struct drm_panel *panel,
struct drm_display_info *info);
Then in drm_panel_attach(), via this interface the specific panel driver can directly set connector->display_info. like
...
if (panel->funcs && panel->funcs->set_display_info)
panel->funcs->unprepare(panel, connector->display_info);
...
Thanks
James
Quoted 43 lines
include/drm/drm_panel.h +43
-0+/** +* @width_mm: +* +* Physical width in mm. +*/ +unsigned int width_mm; + +/** +* @height_mm: +* +* Physical height in mm. +*/ +unsigned int height_mm; + +/** +* @bpc: +* +* Maximum bits per color channel. Used by HDMI and DP outputs. +*/ +unsigned int bpc; + +/** +* @orientation +* +* Installation orientation of the panel with respect to the chassis. +*/ +int orientation; + +/** +* @bus_formats +* +* Pixel data format on the wire. +*/ +const u32 *bus_formats; + +/** +* @num_bus_formats: +* +* Number of elements pointed to by @bus_formats +*/ +unsigned int num_bus_formats; + +/**
include/drm/drm_panel.h struct drm_panel { · line 196
Quoted 10 lines
include/drm/drm_panel.h +7
-0+* @bus_flags: +* +* Additional information (like pixel signal polarity) for the pixel +* data on the bus. +*/ +u32 bus_flags; +/** * @list: *
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [v8,2/4] drm/panel: set display info in panel attach
Quoted 79 lines · james qian wang (Arm Technology China)
Quoted 70 lines · Derek Basehore
Devicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added.
To address this, this patch sets orientation, as well as other fixed values for the panel, in thedrm_panel_attachfunction. These values are stored from probe in thedrm_panelstruct.Signed-off-by Derek Basehore <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>--- drivers/gpu/drm/drm_panel.c | 28 +++++++++++++++++++++ include/drm/drm_panel.h | 50 +++++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+)drivers/gpu/drm/drm_panel.c +28
-0@@ -104,11 +104,23 @@ EXPORT_SYMBOL(drm_panel_remove);*/ int drm_panel_attach (struct drm_panel *panel,struct drm_connector *connector) { +struct drm_display_info *info; +if (panel->connector)return -EBUSY ; panel->connector = connector; panel->drm = connector->dev; + info = &connector->display_info; + info->width_mm = panel->width_mm; + info->height_mm = panel->height_mm; + info->bpc = panel->bpc; + info->panel_orientation = panel->orientation; + info->bus_flags = panel->bus_flags; +if (panel->bus_formats) +drm_display_info_set_bus_formats (&connector->display_info, + panel->bus_formats, + panel->num_bus_formats);return 0 ; }@@ -126,6 +138,22 @@ EXPORT_SYMBOL(drm_panel_attach);*/ void drm_panel_detach (struct drm_panel *panel) { +struct drm_display_info *info; + +if (!panel->connector) + goto out; + + info = &panel->connector->display_info; + info->width_mm =0 ; + info->height_mm =0 ; + info->bpc =0 ; + info->panel_orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; + info->bus_flags =0 ; +kfree (info->bus_formats); + info->bus_formats =NULL ; + info->num_bus_formats =0 ; + +out: panel->connector =NULL ; panel->drm =NULL ; }include/drm/drm_panel.h +0
-0include/drm/drm_panel.h struct drm_panel { · line 143
Quoted 3 lines
include/drm/drm_panel.h +0
-0@@ -141,6 +141,56 @@ struct drm_panel {*/ const struct drm_panel_funcs *funcs;All these new added members seems dupliated with
drm_display_info, So I think, can we add a newdrm_plane_funcsfunc:
Quoted 2 lines
int (*set_display_info)(struct
drm_panel*panel,struct drm_display_info *info);
I don't disagree personally, since I originally wrote it this way, but 2 maintainers, Daniel Vetter and Thierry Reding, requested that it be changed. Unless that decision is reversed, I won't be changing this.
Quoted 57 lines
Then in
drm_panel_attach(), via this interface the specific panel driver can directly setconnector->display_info. like... if (panel->funcs && panel->funcs->set_display_info) panel->funcs->unprepare(panel, connector->display_info); ...Thanks
JamesQuoted 45 lines
include/drm/drm_panel.h +45
-0+/** +* @width_mm: +* +* Physical width in mm. +*/ +unsigned int width_mm; + +/** +* @height_mm: +* +* Physical height in mm. +*/ +unsigned int height_mm; + +/** +* @bpc: +* +* Maximum bits per color channel. Used by HDMI and DP outputs. +*/ +unsigned int bpc; + +/** +* @orientation +* +* Installation orientation of the panel with respect to the chassis. +*/ +int orientation; + +/** +* @bus_formats +* +* Pixel data format on the wire. +*/ +const u32 *bus_formats; + +/** +* @num_bus_formats: +* +* Number of elements pointed to by @bus_formats +*/ +unsigned int num_bus_formats; + +/** +* @bus_flags: +*
Quoted 8 lines
include/drm/drm_panel.h struct drm_panel { · line 196
Quoted 8 lines
include/drm/drm_panel.h +5
-0+* Additional information (like pixel signal polarity) for the pixel +* data on the bus. +*/ +u32 bus_flags; +/** * @list: *
Thanks for the review
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [v8,2/4] drm/panel: set display info in panel attach
Quoted 81 lines · dbasehore .
Quoted 79 lines · james qian wang (Arm Technology China)
Quoted 70 lines · Derek Basehore
Devicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added.
To address this, this patch sets orientation, as well as other fixed values for the panel, in thedrm_panel_attachfunction. These values are stored from probe in thedrm_panelstruct.Signed-off-by Derek Basehore <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>--- drivers/gpu/drm/drm_panel.c | 28 +++++++++++++++++++++ include/drm/drm_panel.h | 50 +++++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+)drivers/gpu/drm/drm_panel.c +28
-0@@ -104,11 +104,23 @@ EXPORT_SYMBOL(drm_panel_remove);*/ int drm_panel_attach (struct drm_panel *panel,struct drm_connector *connector) { +struct drm_display_info *info; +if (panel->connector)return -EBUSY ; panel->connector = connector; panel->drm = connector->dev; + info = &connector->display_info; + info->width_mm = panel->width_mm; + info->height_mm = panel->height_mm; + info->bpc = panel->bpc; + info->panel_orientation = panel->orientation; + info->bus_flags = panel->bus_flags; +if (panel->bus_formats) +drm_display_info_set_bus_formats (&connector->display_info, + panel->bus_formats, + panel->num_bus_formats);return 0 ; }@@ -126,6 +138,22 @@ EXPORT_SYMBOL(drm_panel_attach);*/ void drm_panel_detach (struct drm_panel *panel) { +struct drm_display_info *info; + +if (!panel->connector) + goto out; + + info = &panel->connector->display_info; + info->width_mm =0 ; + info->height_mm =0 ; + info->bpc =0 ; + info->panel_orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; + info->bus_flags =0 ; +kfree (info->bus_formats); + info->bus_formats =NULL ; + info->num_bus_formats =0 ; + +out: panel->connector =NULL ; panel->drm =NULL ; }include/drm/drm_panel.h +0
-0include/drm/drm_panel.h struct drm_panel { · line 143
Quoted 3 lines
include/drm/drm_panel.h +0
-0@@ -141,6 +141,56 @@ struct drm_panel {*/ const struct drm_panel_funcs *funcs;All these new added members seems dupliated with
drm_display_info, So I think, can we add a newdrm_plane_funcsfunc:
Quoted 7 lines
Quoted 2 lines
int (*set_display_info)(struct
drm_panel*panel,struct drm_display_info *info);I don't disagree personally, since I originally wrote it this way, but 2 maintainers, Daniel Vetter and Thierry Reding, requested that it be changed. Unless that decision is reversed, I won't be changing this.
Reading back the feedback on v1, I don't think anyone said they were against storing a drm_display_info struct in drm_panel (no one really weighed in on it one way or another). IMO duplicating a bunch of fields feels pretty icky.
I think most fields in drm_display_info have pretty reasonable defaults, so I'd recommend just storing a copy in drm_panel. As Thierry suggests, we can populate the dt parts in probe (orientation) and then copy over all or a subset of the struct to connector on attach.
Sean
Quoted 67 lines
Quoted 57 lines
Then in
drm_panel_attach(), via this interface the specific panel driver can directly setconnector->display_info. like... if (panel->funcs && panel->funcs->set_display_info) panel->funcs->unprepare(panel, connector->display_info); ...Thanks
JamesQuoted 45 lines
include/drm/drm_panel.h +45
-0+/** +* @width_mm: +* +* Physical width in mm. +*/ +unsigned int width_mm; + +/** +* @height_mm: +* +* Physical height in mm. +*/ +unsigned int height_mm; + +/** +* @bpc: +* +* Maximum bits per color channel. Used by HDMI and DP outputs. +*/ +unsigned int bpc; + +/** +* @orientation +* +* Installation orientation of the panel with respect to the chassis. +*/ +int orientation; + +/** +* @bus_formats +* +* Pixel data format on the wire. +*/ +const u32 *bus_formats; + +/** +* @num_bus_formats: +* +* Number of elements pointed to by @bus_formats +*/ +unsigned int num_bus_formats; + +/** +* @bus_flags: +* Quoted 8 lines
include/drm/drm_panel.h struct drm_panel { · line 196
Quoted 8 lines
include/drm/drm_panel.h +5
-0+* Additional information (like pixel signal polarity) for the pixel +* data on the bus. +*/ +u32 bus_flags; +/** * @list: * Thanks for the review
Signature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS
Re: [v8,2/4] drm/panel: set display info in panel attach
Quoted 86 lines · Sean Paul
Quoted 84 lines · dbasehore .
Quoted 81 lines · james qian wang (Arm Technology China)
Quoted 70 lines · Derek Basehore
Devicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added.
To address this, this patch sets orientation, as well as other fixed values for the panel, in thedrm_panel_attachfunction. These values are stored from probe in thedrm_panelstruct.Signed-off-by Derek Basehore <[email protected]>Reviewed-by Sam Ravnborg <[email protected]>--- drivers/gpu/drm/drm_panel.c | 28 +++++++++++++++++++++ include/drm/drm_panel.h | 50 +++++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+)drivers/gpu/drm/drm_panel.c +28
-0@@ -104,11 +104,23 @@ EXPORT_SYMBOL(drm_panel_remove);*/ int drm_panel_attach (struct drm_panel *panel,struct drm_connector *connector) { +struct drm_display_info *info; +if (panel->connector)return -EBUSY ; panel->connector = connector; panel->drm = connector->dev; + info = &connector->display_info; + info->width_mm = panel->width_mm; + info->height_mm = panel->height_mm; + info->bpc = panel->bpc; + info->panel_orientation = panel->orientation; + info->bus_flags = panel->bus_flags; +if (panel->bus_formats) +drm_display_info_set_bus_formats (&connector->display_info, + panel->bus_formats, + panel->num_bus_formats);return 0 ; }@@ -126,6 +138,22 @@ EXPORT_SYMBOL(drm_panel_attach);*/ void drm_panel_detach (struct drm_panel *panel) { +struct drm_display_info *info; + +if (!panel->connector) + goto out; + + info = &panel->connector->display_info; + info->width_mm =0 ; + info->height_mm =0 ; + info->bpc =0 ; + info->panel_orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; + info->bus_flags =0 ; +kfree (info->bus_formats); + info->bus_formats =NULL ; + info->num_bus_formats =0 ; + +out: panel->connector =NULL ; panel->drm =NULL ; }include/drm/drm_panel.h +0
-0include/drm/drm_panel.h struct drm_panel { · line 143
Quoted 3 lines
include/drm/drm_panel.h +0
-0@@ -141,6 +141,56 @@ struct drm_panel {*/ const struct drm_panel_funcs *funcs;All these new added members seems dupliated with
drm_display_info, So I think, can we add a newdrm_plane_funcsfunc:int (*set_display_info)(struct
drm_panel*panel,struct drm_display_info *info);
Quoted 8 lines
Quoted 4 lines
I don't disagree personally, since I originally wrote it this way, but 2 maintainers, Daniel Vetter and Thierry Reding, requested that it be changed. Unless that decision is reversed, I won't be changing this.
Reading back the feedback on v1, I don't think anyone said they were against storing a
drm_display_infostruct indrm_panel(no one really weighed in on it one way or another). IMO duplicating a bunch of fields feels pretty icky.
Thanks for the review. Should we duplicate the entire struct, or just create a sub-struct, say, physical_properties that will be part of drm_display_info and drm_panel?
Quoted 78 lines
I think most fields in
drm_display_infohave pretty reasonable defaults, so I'd recommend just storing a copy indrm_panel. As Thierry suggests, we can populate the dt parts in probe (orientation) and then copy over all or a subset of the struct to connector on attach.Sean
Quoted 59 lines
Quoted 59 lines
Then in
drm_panel_attach(), via this interface the specific panel driver can directly setconnector->display_info. like... if (panel->funcs && panel->funcs->set_display_info) panel->funcs->unprepare(panel, connector->display_info); ...Thanks
JamesQuoted 47 lines
include/drm/drm_panel.h +47
-0+/** +* @width_mm: +* +* Physical width in mm. +*/ +unsigned int width_mm; + +/** +* @height_mm: +* +* Physical height in mm. +*/ +unsigned int height_mm; + +/** +* @bpc: +* +* Maximum bits per color channel. Used by HDMI and DP outputs. +*/ +unsigned int bpc; + +/** +* @orientation +* +* Installation orientation of the panel with respect to the chassis. +*/ +int orientation; + +/** +* @bus_formats +* +* Pixel data format on the wire. +*/ +const u32 *bus_formats; + +/** +* @num_bus_formats: +* +* Number of elements pointed to by @bus_formats +*/ +unsigned int num_bus_formats; + +/** +* @bus_flags: +* +* Additional information (like pixel signal polarity) for the pixel +* data on the bus. Quoted 8 lines
Quoted 6 lines
include/drm/drm_panel.h struct drm_panel { · line 196
Quoted 6 lines
include/drm/drm_panel.h +3
-0+*/ +u32 bus_flags; +/** * @list: * Thanks for the review
--
Sean Paul, Software Engineer, Google / Chromium OS
Re: [v8,2/4] drm/panel: set display info in panel attach
/snip
Quoted 20 lines
Quoted 20 lines
Quoted 19 lines
Quoted 12 lines
include/drm/drm_panel.h struct drm_panel { · line 143
Quoted 8 lines
include/drm/drm_panel.h +0
-0@@ -141,6 +141,56 @@ struct drm_panel {*/ const struct drm_panel_funcs *funcs;All these new added members seems dupliated with
drm_display_info, So I think, can we add a newdrm_plane_funcsfunc:Quoted 2 lines
int (*set_display_info)(struct
drm_panel*panel,struct drm_display_info *info);I don't disagree personally, since I originally wrote it this way, but 2 maintainers, Daniel Vetter and Thierry Reding, requested that it be changed. Unless that decision is reversed, I won't be changing this.
Quoted 7 lines
Quoted 3 lines
Reading back the feedback on v1, I don't think anyone said they were against storing a
drm_display_infostruct indrm_panel(no one really weighed in on it one way or another). IMO duplicating a bunch of fields feels pretty icky.Thanks for the review. Should we duplicate the entire struct, or just create a sub-struct, say,
physical_propertiesthat will be part ofdrm_display_infoanddrm_panel?
That's a good idea, but I think you can use the entire struct. Everything has reasonable default values and I think it might be difficult to draw a line in the sand as to which fields will or won't be useful for panels going forward. Best for drivers to just treat the info in drm_display_info as best effort and have good defaults IMO.
Sean
Quoted 79 lines
Quoted 79 lines
I think most fields in
drm_display_infohave pretty reasonable defaults, so I'd recommend just storing a copy indrm_panel. As Thierry suggests, we can populate the dt parts in probe (orientation) and then copy over all or a subset of the struct to connector on attach.Sean
Quoted 59 lines
Quoted 59 lines
Then in
drm_panel_attach(), via this interface the specific panel driver can directly setconnector->display_info. like... if (panel->funcs && panel->funcs->set_display_info) panel->funcs->unprepare(panel, connector->display_info); ...Thanks
JamesQuoted 47 lines
include/drm/drm_panel.h +47
-0+/** +* @width_mm: +* +* Physical width in mm. +*/ +unsigned int width_mm; + +/** +* @height_mm: +* +* Physical height in mm. +*/ +unsigned int height_mm; + +/** +* @bpc: +* +* Maximum bits per color channel. Used by HDMI and DP outputs. +*/ +unsigned int bpc; + +/** +* @orientation +* +* Installation orientation of the panel with respect to the chassis. +*/ +int orientation; + +/** +* @bus_formats +* +* Pixel data format on the wire. +*/ +const u32 *bus_formats; + +/** +* @num_bus_formats: +* +* Number of elements pointed to by @bus_formats +*/ +unsigned int num_bus_formats; + +/** +* @bus_flags: +* +* Additional information (like pixel signal polarity) for the pixel +* data on the bus. Quoted 8 lines
Quoted 6 lines
include/drm/drm_panel.h struct drm_panel { · line 196
Quoted 6 lines
include/drm/drm_panel.h +3
-0+*/ +u32 bus_flags; +/** * @list: * Thanks for the review
--
Sean Paul, Software Engineer, Google / Chromium OS
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 3/4 drm/connector: Split out orientation quirk detection
In reply to Derek BasehoreNot every platform needs quirk detection for panel orientation, so split the drm_connector_init_panel_orientation_property into two functions. One for platforms without the need for quirks, and the other for platforms that need quirks.
--- drivers/gpu/drm/drm_connector.c | 45 ++++++++++++++++++------- drivers/gpu/drm/i915/display/icl_dsi.c | 2 +- drivers/gpu/drm/i915/display/intel_dp.c | 4 +-- drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +- include/drm/drm_connector.h | 2 ++ 5 files changed, 39 insertions(+), 16 deletions(-)
drivers/gpu/drm/drm_connector.c +33 -12
@@ -1989,31 +1989,23 @@ EXPORT_SYMBOL(drm_connector_set_vrr_capable_property);* drm_connector_init_panel_orientation_property - * initialize the connecters panel_orientation property * @connector: connector for which to init the panel-orientation property. -* @width: width in pixels of the panel, used for panel quirk detection -* @height: height in pixels of the panel, used for panel quirk detection * * This function should only be called for built-in panels, after setting * connector->display_info.panel_orientation first (if known). * -* This function will check for platform specific (e.g. DMI based) quirks -* overriding display_info.panel_orientation first, then if panel_orientation -* is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the -* "panel orientation" property to the connector. +* This function will check if the panel_orientation is not +* DRM_MODE_PANEL_ORIENTATION_UNKNOWN. If not, it will attach the "panel +* orientation" property to the connector. * * Returns: * Zero on success, negative errno on failure. */ int drm_connector_init_panel_orientation_property ( -struct drm_connector *connector,int width,int height) +struct drm_connector *connector) {struct drm_device *dev = connector->dev;struct drm_display_info *info = &connector->display_info;struct drm_property *prop; -int orientation_quirk; - - orientation_quirk =drm_get_panel_orientation_quirk (width, height); -if (orientation_quirk !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN ) - info->panel_orientation = orientation_quirk;if (info->panel_orientation ==DRM_MODE_PANEL_ORIENTATION_UNKNOWN )return 0 ;
@@ -2036,6 +2028,35 @@ int drm_connector_init_panel_orientation_property( }EXPORT_SYMBOL (drm_connector_init_panel_orientation_property); +/** +* drm_connector_init_panel_orientation_property_quirk - +* initialize the connecters panel_orientation property with a quirk +* override +* @connector: connector for which to init the panel-orientation property. +* @width: width in pixels of the panel, used for panel quirk detection +* @height: height in pixels of the panel, used for panel quirk detection +* +* This function will check for platform specific (e.g. DMI based) quirks +* overriding display_info.panel_orientation first, then if panel_orientation +* is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the +* "panel orientation" property to the connector. +* +* Returns: +* Zero on success, negative errno on failure. +*/ +int drm_connector_init_panel_orientation_property_quirk ( +struct drm_connector *connector,int width,int height) +{ +int orientation_quirk; + + orientation_quirk =drm_get_panel_orientation_quirk (width, height); +if (orientation_quirk !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN ) + connector->display_info.panel_orientation = orientation_quirk; + +return drm_connector_init_panel_orientation_property (connector); +} +EXPORT_SYMBOL (drm_connector_init_panel_orientation_property_quirk); +int drm_connector_set_obj_prop (struct drm_mode_object *obj,struct drm_property *property,uint64_t value)
drivers/gpu/drm/i915/display/icl_dsi.c +1 -1
@@ -1538,7 +1538,7 @@ static void icl_dsi_add_properties(struct intel_connector *connector) connector->base.display_info.panel_orientation =intel_dsi_get_panel_orientation (connector); -drm_connector_init_panel_orientation_property (&connector->base, +drm_connector_init_panel_orientation_property_quirk (&connector->base, connector->panel.fixed_mode->hdisplay, connector->panel.fixed_mode->vdisplay); }
drivers/gpu/drm/i915/display/intel_dp.c +2 -2
@@ -7076,8 +7076,8 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,intel_panel_setup_backlight (connector, pipe);if (fixed_mode) -drm_connector_init_panel_orientation_property ( - connector, fixed_mode->hdisplay, fixed_mode->vdisplay); +drm_connector_init_panel_orientation_property_quirk (connector, + fixed_mode->hdisplay, fixed_mode->vdisplay);return true;
drivers/gpu/drm/i915/display/vlv_dsi.c +1 -1
@@ -1634,7 +1634,7 @@ static void vlv_dsi_add_properties(struct intel_connector *connector) connector->base.display_info.panel_orientation =vlv_dsi_get_panel_orientation (connector); -drm_connector_init_panel_orientation_property ( +drm_connector_init_panel_orientation_property_quirk ( &connector->base, connector->panel.fixed_mode->hdisplay, connector->panel.fixed_mode->vdisplay);
include/drm/drm_connector.h +2 -0
@@ -1540,6 +1540,8 @@ void drm_connector_set_link_status_property(struct drm_connector *connector,void drm_connector_set_vrr_capable_property (struct drm_connector *connector,bool capable);int drm_connector_init_panel_orientation_property ( +struct drm_connector *connector); +int drm_connector_init_panel_orientation_property_quirk (struct drm_connector *connector,int width,int height);int drm_connector_attach_max_bpc_property (struct drm_connector *connector,int min,int max);
Signature · 1 line
2.23.0.351.gc4317032e6-goog
Re: [PATCH v8 3/4] drm/connector: Split out orientation quirk detection
Quoted 7 lines · Derek Basehore
Not every platform needs quirk detection for panel orientation, so split the
drm_connector_init_panel_orientation_propertyinto two functions. One for platforms without the need for quirks, and the other for platforms that need quirks.Signed-off-by Derek Basehore <[email protected]>Acked-by Sam Ravnborg <[email protected]>
Quoted 141 lines
--- drivers/gpu/drm/drm_connector.c | 45 ++++++++++++++++++------- drivers/gpu/drm/i915/display/icl_dsi.c | 2 +- drivers/gpu/drm/i915/display/intel_dp.c | 4 +-- drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +- include/drm/drm_connector.h | 2 ++ 5 files changed, 39 insertions(+), 16 deletions(-)drivers/gpu/drm/drm_connector.c +33
-12@@ -1989,31 +1989,23 @@ EXPORT_SYMBOL(drm_connector_set_vrr_capable_property);* drm_connector_init_panel_orientation_property - * initialize the connecters panel_orientation property * @connector: connector for which to init the panel-orientation property. -* @width: width in pixels of the panel, used for panel quirk detection -* @height: height in pixels of the panel, used for panel quirk detection * * This function should only be called for built-in panels, after setting * connector->display_info.panel_orientation first (if known). * -* This function will check for platform specific (e.g. DMI based) quirks -* overriding display_info.panel_orientation first, then if panel_orientation -* is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the -* "panel orientation" property to the connector. +* This function will check if the panel_orientation is not +* DRM_MODE_PANEL_ORIENTATION_UNKNOWN. If not, it will attach the "panel +* orientation" property to the connector. * * Returns: * Zero on success, negative errno on failure. */ int drm_connector_init_panel_orientation_property ( -struct drm_connector *connector,int width,int height) +struct drm_connector *connector) {struct drm_device *dev = connector->dev;struct drm_display_info *info = &connector->display_info;struct drm_property *prop; -int orientation_quirk; - - orientation_quirk =drm_get_panel_orientation_quirk (width, height); -if (orientation_quirk !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN ) - info->panel_orientation = orientation_quirk;if (info->panel_orientation ==DRM_MODE_PANEL_ORIENTATION_UNKNOWN )return 0 ;@@ -2036,6 +2028,35 @@ int drm_connector_init_panel_orientation_property( }EXPORT_SYMBOL (drm_connector_init_panel_orientation_property); +/** +* drm_connector_init_panel_orientation_property_quirk - +* initialize the connecters panel_orientation property with a quirk +* override +* @connector: connector for which to init the panel-orientation property. +* @width: width in pixels of the panel, used for panel quirk detection +* @height: height in pixels of the panel, used for panel quirk detection +* +* This function will check for platform specific (e.g. DMI based) quirks +* overriding display_info.panel_orientation first, then if panel_orientation +* is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN it will attach the +* "panel orientation" property to the connector. +* +* Returns: +* Zero on success, negative errno on failure. +*/ +int drm_connector_init_panel_orientation_property_quirk ( +struct drm_connector *connector,int width,int height) +{ +int orientation_quirk; + + orientation_quirk =drm_get_panel_orientation_quirk (width, height); +if (orientation_quirk !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN ) + connector->display_info.panel_orientation = orientation_quirk; + +return drm_connector_init_panel_orientation_property (connector); +} +EXPORT_SYMBOL (drm_connector_init_panel_orientation_property_quirk); +int drm_connector_set_obj_prop (struct drm_mode_object *obj,struct drm_property *property,uint64_t value)drivers/gpu/drm/i915/display/icl_dsi.c +1
-1@@ -1538,7 +1538,7 @@ static void icl_dsi_add_properties(struct intel_connector *connector) connector->base.display_info.panel_orientation =intel_dsi_get_panel_orientation (connector); -drm_connector_init_panel_orientation_property (&connector->base, +drm_connector_init_panel_orientation_property_quirk (&connector->base, connector->panel.fixed_mode->hdisplay, connector->panel.fixed_mode->vdisplay); }drivers/gpu/drm/i915/display/intel_dp.c +2
-2@@ -7076,8 +7076,8 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,intel_panel_setup_backlight (connector, pipe);if (fixed_mode) -drm_connector_init_panel_orientation_property ( - connector, fixed_mode->hdisplay, fixed_mode->vdisplay); +drm_connector_init_panel_orientation_property_quirk (connector, + fixed_mode->hdisplay, fixed_mode->vdisplay);return true;drivers/gpu/drm/i915/display/vlv_dsi.c +1
-1@@ -1634,7 +1634,7 @@ static void vlv_dsi_add_properties(struct intel_connector *connector) connector->base.display_info.panel_orientation =vlv_dsi_get_panel_orientation (connector); -drm_connector_init_panel_orientation_property ( +drm_connector_init_panel_orientation_property_quirk ( &connector->base, connector->panel.fixed_mode->hdisplay, connector->panel.fixed_mode->vdisplay);include/drm/drm_connector.h +2
-0@@ -1540,6 +1540,8 @@ void drm_connector_set_link_status_property(struct drm_connector *connector,void drm_connector_set_vrr_capable_property (struct drm_connector *connector,bool capable);int drm_connector_init_panel_orientation_property ( +struct drm_connector *connector); +int drm_connector_init_panel_orientation_property_quirk (struct drm_connector *connector,int width,int height);int drm_connector_attach_max_bpc_property (struct drm_connector *connector,int min,int max);Signature · 1 line
2.23.0.351.gc4317032e6-goog
Signature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS
PATCH v8 4/4 drm/mtk: add panel orientation property
In reply to Derek BasehoreThis inits the panel orientation property for the mediatek dsi driver if the panel orientation (connector.display_info.panel_orientation) is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN.
--- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/mediatek/mtk_dsi.c +8 -0
@@ -792,10 +792,18 @@ static int mtk_dsi_create_connector(struct drm_device *drm, struct mtk_dsi *dsi)DRM_ERROR ("Failed to attach panel to drm\n" ); goto err_connector_cleanup; } + + ret =drm_connector_init_panel_orientation_property (&dsi->conn); +if (ret) { +DRM_ERROR ("Failed to init panel orientation\n" ); + goto err_panel_detach; + } }return 0 ; +err_panel_detach: +drm_panel_detach (dsi->panel); err_connector_cleanup:drm_connector_cleanup (&dsi->conn);return ret;
Signature · 6 lines
2.23.0.351.gc4317032e6-goog _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v8 4/4] drm/mtk: add panel orientation property
Quoted 7 lines · Derek Basehore
This inits the panel orientation property for the mediatek dsi driver if the panel orientation (connector.display_info.panel_orientation) is not
DRM_MODE_PANEL_ORIENTATION_UNKNOWN.Signed-off-by Derek Basehore <[email protected]>Acked-by Sam Ravnborg <[email protected]>Reviewed-by CK Hu <[email protected]>
Quoted 30 lines
--- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/mediatek/mtk_dsi.c +8
-0@@ -792,10 +792,18 @@ static int mtk_dsi_create_connector(struct drm_device *drm, struct mtk_dsi *dsi)DRM_ERROR ("Failed to attach panel to drm\n" ); goto err_connector_cleanup; } + + ret =drm_connector_init_panel_orientation_property (&dsi->conn); +if (ret) { +DRM_ERROR ("Failed to init panel orientation\n" ); + goto err_panel_detach; + } }return 0 ; +err_panel_detach: +drm_panel_detach (dsi->panel); err_connector_cleanup:drm_connector_cleanup (&dsi->conn);return ret;Signature · 1 line
2.23.0.351.gc4317032e6-goog
Signature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS
Patchwork
CI✗ Fi.CI.BUILD: failure for Panel rotation patches (rev8)
In reply to Derek Basehore== Series Details ==
== Series Details ==
Series: Panel rotation patches (rev8)
URL : https://patchwork.freedesktop.org/series/61870/
State : failure
== Summary ==
Applying: drm/panel: Add helper for reading DT rotation
Applying: drm/panel: set display info in panel attach
error: sha1 information is lacking or useless (drivers/gpu/drm/drm_panel.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch Patch failed at 0002 drm/panel: set display info in panel attach When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx