Skip to contentSkip to conversation

ARM: i.MX6: TARGET_NITROGEN6X: add 'select MX6QDL'

PATCH New Troy Kisky 2 participants 4 messages Sep 26, 2019 – Nov 3, 2019

Subsystems (3)
lore
Share & tools
lore

Troy Kisky

author
#0 lore raw

PATCH 1/1 ARM: i.MX6: TARGET_NITROGEN6X: add 'select MX6QDL'

This fixes commit <91435cd40d30> "ARM: i.MX6: exclude the ARM errata
from i.MX6 UP system"

for nitrogen6x. The above commit removed the errata for the board since MX6Q/MXDL/MX6S is selected via CONFIG_SYS_EXTRA_OPTIONS

This restores the errata configs.

---
Note:
marsboard, mx6qarm2, seem to have same problem.

---
 arch/arm/mach-imx/mx6/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-imx/mx6/Kconfig +1 -0
index 01f0121beb..2c2edaa093 100644
@@ -412,6 +412,7 @@ config TARGET_NITROGEN6X
 	imply USB_ETHER_MCS7830
 	imply USB_ETHER_SMSC95XX
 	imply USB_HOST_ETHER
+	select MX6QDL
 
 config TARGET_OPOS6ULDEV
 	bool "Armadeus OPOS6ULDev board"
Signature · 1 line
2.18.0
author
#1 lore raw

PATCH 1/1 ARM: i.MX6: TARGET_NITROGEN6X: add 'select MX6QDL'

Quoted 23 lines · Troy Kisky

This fixes commit <91435cd40d30> "ARM: i.MX6: exclude the ARM errata
from i.MX6 UP system"

for nitrogen6x. The above commit removed the errata for the board since MX6Q/MXDL/MX6S is selected via CONFIG_SYS_EXTRA_OPTIONS

This restores the errata configs.

---
Note:
marsboard, mx6qarm2, seem to have same problem.

---
 arch/arm/mach-imx/mx6/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-imx/mx6/Kconfig +0 -0
index 01f0121beb..2c2edaa093 100644

arch/arm/mach-imx/mx6/Kconfig config TARGET_NITROGEN6X · line 418

Quoted 7 lines
arch/arm/mach-imx/mx6/Kconfig +1 -0
@@ -412,6 +412,7 @@ config TARGET_NITROGEN6X
 	imply USB_ETHER_MCS7830
 	imply USB_ETHER_SMSC95XX
 	imply USB_HOST_ETHER
+	select MX6QDL
 
 config TARGET_OPOS6ULDEV
 	bool "Armadeus OPOS6ULDev board"

Maybe the more correct fix is to allow MX6Q/MX6DL/MX6S to be selected in the defconfig (add a text string in the Kconfig). That way MX6S boards won't have unneeded errata applied.

Thoughts?

Troy

#2 lore raw

PATCH 1/1 ARM: i.MX6: TARGET_NITROGEN6X: add 'select MX6QDL'

Quoted 28 lines · Troy Kisky
Quoted 27 lines · Troy Kisky

This fixes commit <91435cd40d30> "ARM: i.MX6: exclude the ARM errata
from i.MX6 UP system"

for nitrogen6x. The above commit removed the errata for the board since MX6Q/MXDL/MX6S is selected via CONFIG_SYS_EXTRA_OPTIONS

This restores the errata configs.

---
Note:
marsboard, mx6qarm2, seem to have same problem.

---
 arch/arm/mach-imx/mx6/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-imx/mx6/Kconfig +1 -0
index 01f0121beb..2c2edaa093 100644
@@ -412,6 +412,7 @@ config TARGET_NITROGEN6X
 	imply USB_ETHER_MCS7830
 	imply USB_ETHER_SMSC95XX
 	imply USB_HOST_ETHER
+	select MX6QDL
 
Quoted 7 lines

arch/arm/mach-imx/mx6/Kconfig config TARGET_NITROGEN6X · line 418

Quoted 3 lines
arch/arm/mach-imx/mx6/Kconfig +0 -0
 config TARGET_OPOS6ULDEV
 	bool "Armadeus OPOS6ULDev board"

Maybe the more correct fix is to allow MX6Q/MX6DL/MX6S to be selected in the defconfig (add a text string in the Kconfig). That way MX6S boards won't have unneeded errata applied.

Not sure. This is really that cannot be configured. If a board has just a i.MX6DL, well, it should not simply configured via menuconfig. It is bound with the hardware.

By the way, this simple patch breaks all nitrogen boards, I have to reject it.

Regards,
Stefano

Quoted 5 lines

Thoughts?

Troy

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#3 lore raw

PATCH 1/1 ARM: i.MX6: TARGET_NITROGEN6X: add 'select MX6QDL'

Quoted 37 lines · Stefano Babic
Quoted 28 lines · Troy Kisky
Quoted 27 lines · Troy Kisky

This fixes commit <91435cd40d30> "ARM: i.MX6: exclude the ARM errata
from i.MX6 UP system"

for nitrogen6x. The above commit removed the errata for the board since MX6Q/MXDL/MX6S is selected via CONFIG_SYS_EXTRA_OPTIONS

This restores the errata configs.

---
Note:
marsboard, mx6qarm2, seem to have same problem.

---
 arch/arm/mach-imx/mx6/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-imx/mx6/Kconfig +1 -0
index 01f0121beb..2c2edaa093 100644
@@ -412,6 +412,7 @@ config TARGET_NITROGEN6X
 	imply USB_ETHER_MCS7830
 	imply USB_ETHER_SMSC95XX
 	imply USB_HOST_ETHER
+	select MX6QDL
 
Quoted 7 lines

arch/arm/mach-imx/mx6/Kconfig config TARGET_NITROGEN6X · line 418

Quoted 3 lines
arch/arm/mach-imx/mx6/Kconfig +0 -0
 config TARGET_OPOS6ULDEV
 	bool "Armadeus OPOS6ULDev board"

Maybe the more correct fix is to allow MX6Q/MX6DL/MX6S to be selected in the defconfig (add a text string in the Kconfig). That way MX6S boards won't have unneeded errata applied.

Quoted 6 lines

Not sure. This is really that cannot be configured. If a board has just a i.MX6DL, well, it should not simply configured via menuconfig. It is bound with the hardware.

By the way, this simple patch breaks all nitrogen boards, I have to reject it.

Oops! sorry about that. I'll send a V2.

Quoted 10 lines

Regards,
Stefano

Quoted 5 lines

Thoughts?

Troy