staging: media: imx: Use devm_platform_ioremap_resource().
PATCH 1/1 staging: media: imx: Use devm_platform_ioremap_resource().
This patch fixes a warning by coccicheck:
drivers/staging/media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use devm_platform_ioremap_resource for state -> regs
Use devm_platform_ioremap_resource helper which wraps platform_get_resource() and devm_ioremap_resource() together.
Signed-off-by Jeeeun Evans <[email protected]>
--- drivers/staging/media/imx/imx7-mipi-csis.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/media/imx/imx7-mipi-csis.c +1 -3
@@ -947,7 +947,6 @@ static void mipi_csis_debugfs_exit(struct csi_state *state)static int mipi_csis_probe (struct platform_device *pdev) {struct device *dev = &pdev->dev; -struct resource *mem_res;struct csi_state *state;int ret;
@@ -969,8 +968,7 @@ static int mipi_csis_probe(struct platform_device *pdev)mipi_csis_phy_init (state);mipi_csis_phy_reset (state); - mem_res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - state->regs =devm_ioremap_resource (dev, mem_res); + state->regs =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (state->regs))return PTR_ERR (state->regs);
Signature · 1 line
2.20.1
Hi Jeeeun,
Quoted 8 lines · Jeeeun Evans
This patch fixes a warning by coccicheck:
drivers/staging/media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Usedevm_platform_ioremap_resourcefor state -> regsUse
devm_platform_ioremap_resourcehelper which wrapsplatform_get_resource()anddevm_ioremap_resource()together.Signed-off-by Jeeeun Evans <[email protected]>
Thanks for the patch.
LGTM.
Reviewed-by Rui Miguel Silva <[email protected]>
---
Cheers,
Rui
Quoted 24 lines
drivers/staging/media/imx/imx7-mipi-csis.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/staging/media/imx/imx7-mipi-csis.c +1
-3@@ -947,7 +947,6 @@ static void mipi_csis_debugfs_exit(struct csi_state *state)static int mipi_csis_probe (struct platform_device *pdev) {struct device *dev = &pdev->dev; -struct resource *mem_res;struct csi_state *state;int ret;@@ -969,8 +968,7 @@ static int mipi_csis_probe(struct platform_device *pdev)mipi_csis_phy_init (state);mipi_csis_phy_reset (state); - mem_res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - state->regs =devm_ioremap_resource (dev, mem_res); + state->regs =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (state->regs))return PTR_ERR (state->regs);