Skip to contentSkip to conversation

spice: append -Wno-error=address-of-packed-member only for target

PATCH In review Martin Jansa 4 participants 10 messages Sep 26, 2019 – Sep 27, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 spice: append -Wno-error=address-of-packed-member only for target

* with older native gcc on host this will break spice-native with:
cc1: error: -Werror=address-of-packed-member: no option -Waddress-of-packed-member

---
 meta-networking/recipes-support/spice/spice_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/spice/spice_git.bb +1 -1
index 30e939ac07..2829a59d15 100644
@@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
 export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
 export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
 
-CFLAGS_append = " -Wno-error=address-of-packed-member"
+CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
 
 PACKAGECONFIG_class-nativesdk = ""
 PACKAGECONFIG ?= "sasl"
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 Revert "spice: Drop broken native"

This reverts commit 5f32fd6b08d79b9a4d1bffb9b2bcbc535a5b27d2.

* fixed by restricting -Wno-error=address-of-packed-member only for target, spice-native is still useful for qemu-native when spice PACKAGECONFIG is enabled

---
 meta-networking/recipes-support/spice/spice_git.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta-networking/recipes-support/spice/spice_git.bb +2 -1
index 2829a59d15..39bee99a4a 100644
@@ -39,6 +39,7 @@ export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
 
 CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
 
+PACKAGECONFIG_class-native = ""
 PACKAGECONFIG_class-nativesdk = ""
 PACKAGECONFIG ?= "sasl"
 
@@ -53,6 +54,6 @@ PACKAGECONFIG[xinerama] = "--enable-xinerama,--disable-xinerama,libxinerama,"
 
 COMPATIBLE_HOST = '(x86_64|i.86).*-linux'
 
-BBCLASSEXTEND = "nativesdk"
+BBCLASSEXTEND = "native nativesdk"
 
 EXTRA_OECONF_append_toolchain-clang = " --disable-werror"
Signature · 1 line
2.17.1
#2 lore raw
In reply to Martin Jansa

It looks like it's also needed for nativesdk. Will send v2 soon.

Quoted 28 lines · Martin Jansa

* with older native gcc on host this will break spice-native with:
cc1: error: -Werror=address-of-packed-member: no option
-Waddress-of-packed-member

---
 meta-networking/recipes-support/spice/spice_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/spice/spice_git.bb +0 -0
index 30e939ac07..2829a59d15 100644
@@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
 export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
 export

PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"

meta-networking/recipes-support/spice/spice_git.bb +1 -2
-CFLAGS_append = " -Wno-error=address-of-packed-member"
+CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
 
 PACKAGECONFIG_class-nativesdk = ""
 PACKAGECONFIG ?= "sasl"
--

2.17.1

#3 lore raw
In reply to Martin Jansa
Quoted 13 lines · Martin Jansa

* with older native gcc on host this will break spice-native with:
cc1: error: -Werror=address-of-packed-member: no option -Waddress-of-packed-member

---
  meta-networking/recipes-support/spice/spice_git.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/spice/spice_git.bb +0 -0
index 30e939ac07..2829a59d15 100644

meta-networking/recipes-support/spice/spice_git.bb DEPENDS_append_class-nativesdk = "nativesdk-openssl" · line 41

Quoted 6 lines
meta-networking/recipes-support/spice/spice_git.bb +1 -1
@@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
  export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
  export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
 
-CFLAGS_append = " -Wno-error=address-of-packed-member"
+CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
 

There are hosts with newer version of gcc and I think they will start to fail. So I guess we could try to use ${@oe.utils.host_gcc_version(d, taskcontextonly=True)} to deduce host gcc version, another option is to add something like --disable-werror and move on.

Quoted 3 lines
meta-networking/recipes-support/spice/spice_git.bb +0 -0
  PACKAGECONFIG_class-nativesdk = ""
  PACKAGECONFIG ?= "sasl"
#4 lore raw
In reply to Martin Jansa
Quoted 13 lines · Martin Jansa

* with older native gcc on host this will break spice-native with:
cc1: error: -Werror=address-of-packed-member: no option -Waddress-of-packed-member

---
 meta-networking/recipes-support/spice/spice_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/spice/spice_git.bb +0 -0
index 30e939ac07..2829a59d15 100644

meta-networking/recipes-support/spice/spice_git.bb DEPENDS_append_class-nativesdk = "nativesdk-openssl" · line 40

Quoted 6 lines
meta-networking/recipes-support/spice/spice_git.bb +1 -1
@@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
 export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
 export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
 
-CFLAGS_append = " -Wno-error=address-of-packed-member"
+CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
...

Least hassle would be
CFLAGS_append = " -Wno-error"

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#5 lore raw
Quoted 17 lines · Adrian Bunk
Quoted 16 lines · Martin Jansa

* with older native gcc on host this will break spice-native with:
cc1: error: -Werror=address-of-packed-member: no option -Waddress-of-packed-member

---
  meta-networking/recipes-support/spice/spice_git.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/spice/spice_git.bb +0 -0
index 30e939ac07..2829a59d15 100644
@@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
  export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
  export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
 
Quoted 2 lines

meta-networking/recipes-support/spice/spice_git.bb DEPENDS_append_class-nativesdk = "nativesdk-openssl" · line 40

Quoted 2 lines
meta-networking/recipes-support/spice/spice_git.bb +1 -1
-CFLAGS_append = " -Wno-error=address-of-packed-member"
+CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"

Yes, the error was the same as you mentioned in the commit message, and "bitbake spice-native" works with this change.

Quoted 4 lines
Quoted 1 line

...

Least hassle would be
CFLAGS_append = " -Wno-error"

"bitbake nativesdk-spice" works with this change, otherwise, it doesn't work.

This patch works for me.

// Robert

Quoted 4 lines

cu
Adrian

#6 lore raw

Hi Martin,

We found another problem on spice_git.bb:

PACKAGECONFIG[smartcard] = "--enable-smartcard,--disable-smartcard,libcacard,"

I can't find libcacard:

http://layers.openembedded.org/layerindex/branch/master/recipes/?q=libcacard

So it seems that this PACKAGECONFIG is invalid, should we remove it?

// Robert

Quoted 41 lines · Robert Yang
Quoted 10 lines · Adrian Bunk
Quoted 9 lines · Martin Jansa

* with older native gcc on host this will break spice-native with:
   cc1: error: -Werror=address-of-packed-member: no option -Waddress-of-packed-member

---
  meta-networking/recipes-support/spice/spice_git.bb | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 9 lines

meta-networking/recipes-support/spice/spice_git.bb DEPENDS_append_class-nativesdk = "nativesdk-openssl" · line 40

Quoted 9 lines
meta-networking/recipes-support/spice/spice_git.bb +0 -0
index 30e939ac07..2829a59d15 100644
@@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"

  export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python" export PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"

meta-networking/recipes-support/spice/spice_git.bb +1 -1
-CFLAGS_append = " -Wno-error=address-of-packed-member"
+CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"

Yes, the error was the same as you mentioned in the commit message, and "bitbake spice-native" works with this change.

Quoted 4 lines
Quoted 1 line

...

Least hassle would be
   CFLAGS_append = " -Wno-error"

"bitbake nativesdk-spice" works with this change, otherwise, it doesn't work.

This patch works for me.

// Robert

Quoted 4 lines

cu
Adrian

#7 lore raw

Why? there are many PACKAGECONFIGs for optional dependencies which aren't in the same layer as the recipe with that PACKAGECONFIG.

As long as it's not enabled by default it is correct to have the PACKAGECONFIG to control the dependency explicitly.

Cheers,

Quoted 63 lines · Robert Yang

Hi Martin,

We found another problem on spice_git.bb:

PACKAGECONFIG[smartcard] = "--enable-smartcard,--disable-smartcard,libcacard,"

I can't find libcacard:

http://layers.openembedded.org/layerindex/branch/master/recipes/?q=libcacard

So it seems that this PACKAGECONFIG is invalid, should we remove it?

// Robert

Quoted 13 lines · Robert Yang
Quoted 10 lines · Adrian Bunk
Quoted 9 lines · Martin Jansa

* with older native gcc on host this will break spice-native with:
cc1: error: -Werror=address-of-packed-member: no option
-Waddress-of-packed-member

---
  meta-networking/recipes-support/spice/spice_git.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
Quoted 8 lines

meta-networking/recipes-support/spice/spice_git.bb DEPENDS_append_class-nativesdk = "nativesdk-openssl" · line 38

Quoted 8 lines
meta-networking/recipes-support/spice/spice_git.bb +0 -0
index 30e939ac07..2829a59d15 100644
@@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
  export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
  export

PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"

Quoted 6 lines
Quoted 2 lines

meta-networking/recipes-support/spice/spice_git.bb DEPENDS_append_class-nativesdk = "nativesdk-openssl" · line 40

Quoted 2 lines
meta-networking/recipes-support/spice/spice_git.bb +1 -1
-CFLAGS_append = " -Wno-error=address-of-packed-member"
+CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"

Yes, the error was the same as you mentioned in the commit message, and "bitbake spice-native" works with this change.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

...

Least hassle would be
CFLAGS_append = " -Wno-error"

"bitbake nativesdk-spice" works with this change, otherwise, it doesn't

work.

Quoted 9 lines

This patch works for me.

// Robert

Quoted 4 lines

cu
Adrian

#8 lore raw
Quoted 7 lines · Martin Jansa

Why? there are many PACKAGECONFIGs for optional dependencies which aren't in the same layer as the recipe with that PACKAGECONFIG.

As long as it's not enabled by default it is correct to have the PACKAGECONFIG to control the dependency explicitly.

right

Quoted 73 lines

Cheers,

Quoted 46 lines · Robert Yang

Hi Martin,

We found another problem on spice_git.bb:

PACKAGECONFIG[smartcard] = "--enable-smartcard,--disable-smartcard,libcacard,"

I can't find libcacard:

http://layers.openembedded.org/layerindex/branch/master/recipes/?q=libcacard

So it seems that this PACKAGECONFIG is invalid, should we remove it?

// Robert

Quoted 13 lines · Robert Yang
Quoted 10 lines · Adrian Bunk
Quoted 9 lines · Martin Jansa

* with older native gcc on host this will break spice-native with:
cc1: error: -Werror=address-of-packed-member: no option
-Waddress-of-packed-member

---
  meta-networking/recipes-support/spice/spice_git.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
Quoted 8 lines

meta-networking/recipes-support/spice/spice_git.bb DEPENDS_append_class-nativesdk = "nativesdk-openssl" · line 38

Quoted 8 lines
meta-networking/recipes-support/spice/spice_git.bb +0 -0
index 30e939ac07..2829a59d15 100644
@@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
  export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
  export

PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"

Quoted 6 lines
Quoted 2 lines

meta-networking/recipes-support/spice/spice_git.bb DEPENDS_append_class-nativesdk = "nativesdk-openssl" · line 40

Quoted 2 lines
meta-networking/recipes-support/spice/spice_git.bb +1 -1
-CFLAGS_append = " -Wno-error=address-of-packed-member"
+CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"

Yes, the error was the same as you mentioned in the commit message, and "bitbake spice-native" works with this change.

Quoted 17 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

...

Least hassle would be
CFLAGS_append = " -Wno-error"

"bitbake nativesdk-spice" works with this change, otherwise, it doesn't

work.

Quoted 9 lines

This patch works for me.

// Robert

Quoted 4 lines

cu
Adrian

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#9 lore raw
Quoted 10 lines · Khem Raj
Quoted 7 lines · Martin Jansa

Why? there are many PACKAGECONFIGs for optional dependencies which aren't in the same layer as the recipe with that PACKAGECONFIG.

As long as it's not enabled by default it is correct to have the PACKAGECONFIG to control the dependency explicitly.

right

Got it, thanks.

// Robert

Quoted 75 lines
Quoted 74 lines

Cheers,

Quoted 46 lines · Robert Yang

Hi Martin,

We found another problem on spice_git.bb:

PACKAGECONFIG[smartcard] = "--enable-smartcard,--disable-smartcard,libcacard,"

I can't find libcacard:

http://layers.openembedded.org/layerindex/branch/master/recipes/?q=libcacard

So it seems that this PACKAGECONFIG is invalid, should we remove it?

// Robert

Quoted 13 lines · Robert Yang
Quoted 10 lines · Adrian Bunk
Quoted 9 lines · Martin Jansa

* with older native gcc on host this will break spice-native with:
cc1: error: -Werror=address-of-packed-member: no option
-Waddress-of-packed-member

---
   meta-networking/recipes-support/spice/spice_git.bb | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
Quoted 8 lines

meta-networking/recipes-support/spice/spice_git.bb DEPENDS_append_class-nativesdk = "nativesdk-openssl" · line 38

Quoted 8 lines
meta-networking/recipes-support/spice/spice_git.bb +0 -0
index 30e939ac07..2829a59d15 100644
@@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
   export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
   export

PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"

Quoted 6 lines
Quoted 2 lines

meta-networking/recipes-support/spice/spice_git.bb DEPENDS_append_class-nativesdk = "nativesdk-openssl" · line 40

Quoted 2 lines
meta-networking/recipes-support/spice/spice_git.bb +1 -1
-CFLAGS_append = " -Wno-error=address-of-packed-member"
+CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"

Yes, the error was the same as you mentioned in the commit message, and "bitbake spice-native" works with this change.

Quoted 17 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

...

Least hassle would be
CFLAGS_append = " -Wno-error"

"bitbake nativesdk-spice" works with this change, otherwise, it doesn't

work.

Quoted 9 lines

This patch works for me.

// Robert

Quoted 4 lines

cu
Adrian

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel