drm/amd/powerplay: initlialize smu->is_apu is false by default
Subsystems (2)
PATCH 1/1 drm/amd/powerplay: initlialize smu->is_apu is false by default
the member of is_apu in smu_context need to initlialize by default.
set default value is false (dGPU)
for patch:
drm/amd/powerplay: bypass dpm_context null pointer check guard for some smu series
--- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +1 -0
@@ -712,6 +712,7 @@ static int smu_early_init(void *handle) smu->adev = adev; smu->pm_enabled = !!amdgpu_dpm; + smu->is_apu = false;mutex_init (&smu->mutex);return smu_set_funcs (adev);
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Liang, Prike
Reviewed-by Prike LiangDoes use the default value (false) for the Boolean variable of is_apu not enough for identifying DGPU? Anyway, initialize the is_apu during smu early initialize also fine and the patch is
Thanks,
Prike
Quoted 37 lines
-----Original Message-----
From: Wang, Kevin(Yang) <[email protected]>
Sent: Friday, September 27, 2019 2:58 PM
To: [email protected]
Cc: Huang, Ray <[email protected]>; Feng, Kenneth <[email protected]>; Liang, Prike <[email protected]>; Wang, Kevin(Yang) <[email protected]>
Subject: [PATCH] drm/amd/powerplay: initlializesmu->is_apuis false by defaultthe member of
is_apuinsmu_contextneed to initlialize by default.set default value is false (dGPU)
for patch:
drm/amd/powerplay: bypassdpm_contextnull pointer check guard for some smu seriesSigned-off-by Kevin Wang <[email protected]>--- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +1
-1@@ -712,6 +712,7 @@ static int smu_early_init(void *handle) smu->adev = adev; smu->pm_enabled = !!amdgpu_dpm; + smu->is_apu = false;mutex_init (&smu->mutex);return smu_set_funcs (adev); --
Quoted 1 line
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): MN2PR12MB3536BA16A58AE0E5E6424063FB810-rweVpJHSKTovpq7YPKzLfQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
Wang, Kevin(Yang)
Reviewed-by Prike Liangthis member should be initialize in smu driver.
by default should be set "false".
Best Regards,
Kevin
________________________________
From: Liang, Prike <[email protected]>
Sent: Friday, September 27, 2019 4:37 PM
To: Wang, Kevin(Yang) <[email protected]>; [email protected] <[email protected]>
Cc: Huang, Ray <[email protected]>; Feng, Kenneth <[email protected]>
Subject: RE: [PATCH] drm/amd/powerplay: initlialize smu->is_apu is false by default
Does use the default value (false) for the Boolean variable of is_apu not enough for identifying DGPU? Anyway, initialize the is_apu during smu early initialize also fine and the patch is
Thanks,
Prike
Quoted 37 lines
-----Original Message-----
From: Wang, Kevin(Yang) <[email protected]>
Sent: Friday, September 27, 2019 2:58 PM
To: [email protected]
Cc: Huang, Ray <[email protected]>; Feng, Kenneth <[email protected]>; Liang, Prike <[email protected]>; Wang, Kevin(Yang) <[email protected]>
Subject: [PATCH] drm/amd/powerplay: initlializesmu->is_apuis false by
defaultthe member of
is_apuinsmu_contextneed to initlialize by default.set default value is false (dGPU)
for patch:
drm/amd/powerplay: bypassdpm_contextnull pointer check guard for some smu seriesSigned-off-by Kevin Wang <[email protected]>--- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +1
-1@@ -712,6 +712,7 @@ static int smu_early_init(void *handle) smu->adev = adev; smu->pm_enabled = !!amdgpu_dpm; + smu->is_apu = false;mutex_init (&smu->mutex);return smu_set_funcs (adev); --
Quoted 1 line
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Feng, Kenneth
Reviewed-by Kenneth Feng-----Original Message-----
From: Wang, Kevin(Yang)
Sent: Friday, September 27, 2019 2:58 PM
To: [email protected]
Cc: Huang, Ray <[email protected]>; Feng, Kenneth <[email protected]>; Liang, Prike <[email protected]>; Wang, Kevin(Yang) <[email protected]>
Subject: [PATCH] drm/amd/powerplay: initlialize smu->is_apu is false by default
the member of is_apu in smu_context need to initlialize by default.
set default value is false (dGPU)
for patch:
drm/amd/powerplay: bypass dpm_context null pointer check guard for some smu series
--- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +1 -0
@@ -712,6 +712,7 @@ static int smu_early_init(void *handle) smu->adev = adev; smu->pm_enabled = !!amdgpu_dpm; + smu->is_apu = false;mutex_init (&smu->mutex);return smu_set_funcs (adev);
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx