selftests/ftrace: Fix same probe error test
Steven Rostedt
maintainerPATCH 1/1 selftests/ftrace: Fix same probe error test
From: "Steven Rostedt (VMware)" <[email protected]>
The "same probe" selftest that tests that adding the same probe fails doesn't add the same probe and passes, which fails the test.
Fixes b78b94b82122 ("selftests/ftrace: Update kprobe event error testcase")
Signed-off-by Steven Rostedt (VMware) <[email protected]>
--- .../selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc +1 -1
@@ -95,7 +95,7 @@ echo 'p:kprobes/testevent _do_fork abcd=\1' > kprobe_events check_error 'p:kprobes/testevent _do_fork ^bcd=\1' # DIFF_ARG_TYPE check_error 'p:kprobes/testevent _do_fork ^abcd=\1:u8' # DIFF_ARG_TYPE check_error 'p:kprobes/testevent _do_fork ^abcd=\"foo"' # DIFF_ARG_TYPE -check_error '^p:kprobes/testevent _do_fork' # SAME_PROBE +check_error '^p:kprobes/testevent _do_fork abcd=\1' # SAME_PROBE fi exit 0
Signature · 1 line
2.20.1
Quoted 8 lines · On Fri, 27 Sep 2019 11:25:14 -0400 Steven Rostedt <[email protected]> wrote:
From: "Steven Rostedt (VMware)" <[email protected]>
The "same probe" selftest that tests that adding the same probe fails doesn't add the same probe and passes, which fails the test.
Fixes b78b94b82122 ("selftests/ftrace: Update kprobe event error testcase")Signed-off-by Steven Rostedt (VMware) <[email protected]>
Oops, thanks!
Acked-by Masami Hiramatsu <[email protected]>
Quoted 20 lines
--- .../selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc +1
-1@@ -95,7 +95,7 @@ echo 'p:kprobes/testevent _do_fork abcd=\1' > kprobe_events check_error 'p:kprobes/testevent _do_fork ^bcd=\1' # DIFF_ARG_TYPE check_error 'p:kprobes/testevent _do_fork ^abcd=\1:u8' # DIFF_ARG_TYPE check_error 'p:kprobes/testevent _do_fork ^abcd=\"foo"' # DIFF_ARG_TYPE -check_error '^p:kprobes/testevent _do_fork' # SAME_PROBE +check_error '^p:kprobes/testevent _do_fork abcd=\1' # SAME_PROBE fi exit 0Signature · 1 line
2.20.1
Signature · 1 line
Masami Hiramatsu <[email protected]>