timer_create01: accept ENOTSUP
PATCH 1/1 timer_create01: accept ENOTSUP
CLOCK_REALTIME_ALARM and CLOCK_BOOTTIME_ALARM require an RTC with alarm support, which may not be present on a system. In that case, the kernel will return EOPNOTSUPP, which is defined as ENOTSUP in userspace.
As these clocks are already possibly unsupported, accept that as an error code besides the EINVAL code.
Note that previously the kernel would incorrectly return the ENOTSUPP code, which is undefined in userspace. With these unfixed kernels, the test will fail when those RTCs are not present.
--- testcases/kernel/syscalls/timer_create/timer_create01.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
testcases/kernel/syscalls/timer_create/timer_create01.c +2 -1
@@ -77,7 +77,8 @@ static void run(unsigned int n) &created_timer_id));if (TST_RET !=0 ) { -if (possibly_unsupported (clock) &&TST_ERR ==EINVAL ) { +if (possibly_unsupported (clock) && + (TST_ERR ==EINVAL ||TST_ERR ==ENOTSUP )) {tst_res (TPASS |TTERRNO ,"%s unsupported, failed as expected" ,get_clock_str (clock));
Signature · 1 line
2.20.1
PATCH 1/1 timer_create01: accept ENOTSUP
Hi!
Quoted 10 lines
CLOCK_REALTIME_ALARMandCLOCK_BOOTTIME_ALARMrequire an RTC with alarm support, which may not be present on a system. In that case, the kernel will return EOPNOTSUPP, which is defined as ENOTSUP in userspace.As these clocks are already possibly unsupported, accept that as an error code besides the EINVAL code.
Note that previously the kernel would incorrectly return the ENOTSUPP code, which is undefined in userspace. With these unfixed kernels, the test will fail when those RTCs are not present.
Can you please include the kernel commit id that fixed the kernel here?
Otherwise this patch is fine.
Quoted 25 lines
Signed-off-by Thadeu Lima de Souza Cascardo <[email protected]>--- testcases/kernel/syscalls/timer_create/timer_create01.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)testcases/kernel/syscalls/timer_create/timer_create01.c +2
-1@@ -77,7 +77,8 @@ static void run(unsigned int n) &created_timer_id));if (TST_RET !=0 ) { -if (possibly_unsupported (clock) &&TST_ERR ==EINVAL ) { +if (possibly_unsupported (clock) && + (TST_ERR ==EINVAL ||TST_ERR ==ENOTSUP )) {tst_res (TPASS |TTERRNO ,"%s unsupported, failed as expected" ,get_clock_str (clock));Signature · 5 lines
2.20.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH 1/1 timer_create01: accept ENOTSUP
Quoted 8 lines · Cyril Hrubis
Hi!
Quoted 7 lines
CLOCK_REALTIME_ALARMandCLOCK_BOOTTIME_ALARMrequire an RTC with alarm support, which may not be present on a system. In that case, the kernel will return EOPNOTSUPP, which is defined as ENOTSUP in userspace.As these clocks are already possibly unsupported, accept that as an error code besides the EINVAL code.
Quoted 7 lines
Quoted 3 lines
Note that previously the kernel would incorrectly return the ENOTSUPP code, which is undefined in userspace. With these unfixed kernels, the test will fail when those RTCs are not present.
Can you please include the kernel commit id that fixed the kernel here?
Otherwise this patch is fine.
f18ddc13af981ce3c7b7f26925f099e7c6929aba ("alarmtimer: Use EOPNOTSUPP instead of ENOTSUPP")
Do you want me to send a v2, or will you fixup the patch?
Thanks a lot.
Cascardo.
Quoted 30 lines
Quoted 26 lines
Signed-off-by Thadeu Lima de Souza Cascardo <[email protected]>--- testcases/kernel/syscalls/timer_create/timer_create01.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)testcases/kernel/syscalls/timer_create/timer_create01.c +2
-1@@ -77,7 +77,8 @@ static void run(unsigned int n) &created_timer_id));if (TST_RET !=0 ) { -if (possibly_unsupported (clock) &&TST_ERR ==EINVAL ) { +if (possibly_unsupported (clock) && + (TST_ERR ==EINVAL ||TST_ERR ==ENOTSUP )) {tst_res (TPASS |TTERRNO ,"%s unsupported, failed as expected" ,get_clock_str (clock));Signature · 5 lines
2.20.1 -- Mailing list info: https://lists.linux.it/listinfo/ltpSignature · 2 lines
Cyril Hrubis [email protected]
PATCH 1/1 timer_create01: accept ENOTSUP
Hi!
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
CLOCK_REALTIME_ALARMandCLOCK_BOOTTIME_ALARMrequire an RTC with alarm support, which may not be present on a system. In that case, the kernel will return EOPNOTSUPP, which is defined as ENOTSUP in userspace.As these clocks are already possibly unsupported, accept that as an error code besides the EINVAL code.
Note that previously the kernel would incorrectly return the ENOTSUPP code, which is undefined in userspace. With these unfixed kernels, the test will fail when those RTCs are not present.
Quoted 7 lines
Quoted 3 lines
Can you please include the kernel commit id that fixed the kernel here?
Otherwise this patch is fine.
f18ddc13af981ce3c7b7f26925f099e7c6929aba("alarmtimer: Use EOPNOTSUPP instead of ENOTSUPP")Do you want me to send a v2, or will you fixup the patch?
No need, I will add that info, thanks.
Signature · 2 lines
Cyril Hrubis [email protected]