drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
Subsystems (3)
PATCH 1/1 drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
Commit 554b3529fe01 ("thermal/drivers/core: Remove the module Kconfig's option") changed the type of THERMAL from tristate to bool, so THERMAL || !THERMAL is now always y. Remove the redundant dependency.
Discovered through Kconfiglib detecting a dependency loop. The C tools simplify the expression to y before running dependency loop detection, and so don't see it. Changing the type of THERMAL back to tristate makes the C tools detect the same loop.
Not sure if running dep. loop detection after simplification can be called a bug. Fixing this nit unbreaks Kconfiglib on the kernel at least.
--- drivers/gpu/drm/tiny/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/tiny/Kconfig +0 -1
@@ -63,7 +63,6 @@ config TINYDRM_REPAPER depends on DRM && SPI select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER - depends on THERMAL || !THERMAL help DRM driver for the following Pervasive Displays panels: 1.44" TFT EPD Panel (E1144CS021)
Signature · 1 line
2.20.1
Noralf Trønnes
AppliedDen 27.09.2019 19.42, skrev Ulf Magnusson:
Quoted 9 lines
Commit
554b3529fe01("thermal/drivers/core: Remove the module Kconfig's option") changed the type of THERMAL from tristate to bool, so THERMAL || !THERMAL is now always y. Remove the redundant dependency.Discovered through Kconfiglib detecting a dependency loop. The C tools simplify the expression to y before running dependency loop detection, and so don't see it. Changing the type of THERMAL back to tristate makes the C tools detect the same loop.
Quoted 6 lines
Not sure if running dep. loop detection after simplification can be called a bug. Fixing this nit unbreaks Kconfiglib on the kernel at least.
Signed-off-by Ulf Magnusson <[email protected]>---
Thanks, applied to drm-misc-next.
Noralf.
Den 01.10.2019 12.58, skrev Noralf Trønnes:
Quoted 12 lines
Den 27.09.2019 19.42, skrev Ulf Magnusson:
Quoted 9 lines
Commit
554b3529fe01("thermal/drivers/core: Remove the module Kconfig's option") changed the type of THERMAL from tristate to bool, so THERMAL || !THERMAL is now always y. Remove the redundant dependency.Discovered through Kconfiglib detecting a dependency loop. The C tools simplify the expression to y before running dependency loop detection, and so don't see it. Changing the type of THERMAL back to tristate makes the C tools detect the same loop.
Quoted 9 lines
Quoted 6 lines
Not sure if running dep. loop detection after simplification can be called a bug. Fixing this nit unbreaks Kconfiglib on the kernel at least.
Signed-off-by Ulf Magnusson <[email protected]>---
Thanks, applied to drm-misc-next.
This has now been queued for the next -rc pull.
Discussion: https://patchwork.freedesktop.org/patch/319826/
Noralf.