net: sched: cbs: Avoid division by zero when calculating the port rate
Subsystems (4)
PATCH 1/1 net: sched: cbs: Avoid division by zero when calculating the port rate
As explained in the "net: sched: taprio: Avoid division by zero on invalid link speed" commit, it is legal for the ethtool API to return zero as a link speed. So guard against it to ensure we don't perform a division by zero in kernel.
--- net/sched/sch_cbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/sched/sch_cbs.c +1 -1
@@ -306,7 +306,7 @@ static void cbs_set_port_rate(struct net_device *dev, struct cbs_sched_data *q)if (err <0 ) goto skip; -if (ecmd.base.speed !=SPEED_UNKNOWN ) +if (ecmd.base.speed && ecmd.base.speed !=SPEED_UNKNOWN ) speed = ecmd.base.speed; skip:
Signature · 1 line
2.17.1
Quoted 8 lines · Vladimir Oltean
As explained in the "net: sched: taprio: Avoid division by zero on invalid link speed" commit, it is legal for the ethtool API to return zero as a link speed. So guard against it to ensure we don't perform a division by zero in kernel.
Fixes e0a7683d30e9 ("net/sched: cbs: fix port_rate miscalculation")Signed-off-by Vladimir Oltean <[email protected]>---
David Miller
maintainerFrom: Vladimir Oltean <[email protected]>
Date: Sun, 29 Sep 2019 02:39:48 +0300
Quoted 7 lines
As explained in the "net: sched: taprio: Avoid division by zero on invalid link speed" commit, it is legal for the ethtool API to return zero as a link speed. So guard against it to ensure we don't perform a division by zero in kernel.
Fixes e0a7683d30e9 ("net/sched: cbs: fix port_rate miscalculation")Signed-off-by Vladimir Oltean <[email protected]>
Applied and queued up for -stable.