arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
--- arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +2 -2
@@ -644,7 +644,7 @@ status = "okay"; u2phy0_host: host-port { - phy-supply = <&vcc5v0_host>; + phy-supply = <&vcc5v0_typec>; status = "okay"; };
@@ -712,7 +712,7 @@ &usbdrd_dwc3_0 { status = "okay"; - dr_mode = "otg"; + dr_mode = "host"; }; &usbdrd3_1 {
Signature · 1 line
2.17.1
Quoted 21 lines · Vivek Unune
Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
Signed-off-by Vivek Unune <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +1
-1@@ -644,7 +644,7 @@ status = "okay"; u2phy0_host: host-port { - phy-supply = <&vcc5v0_host>; + phy-supply = <&vcc5v0_typec>; status = "okay"; };
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts line 718
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +1
-1@@ -712,7 +712,7 @@ &usbdrd_dwc3_0 { status = "okay"; - dr_mode = "otg"; + dr_mode = "host"; }; &usbdrd3_1 {
Hi Vivek,
which is the relationship of your patch and this commit:
e1d9149e8389f1690cdd4e4056766dd26488a0fe
arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
with respect to this other commit:
c09b73cfac2a9317f1104169045c519c6021aa1d
usb: dwc3: don't set gadget->is_otg flag
?
I did not test reverting e1d9149e since c09b73cf was applied.
Regards,
Vicenç.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 40 lines · Vicente Bergas
Quoted 20 lines · Vivek Unune
Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
Signed-off-by Vivek Unune <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +1
-1@@ -644,7 +644,7 @@ status = "okay"; u2phy0_host: host-port { - phy-supply = <&vcc5v0_host>; + phy-supply = <&vcc5v0_typec>; status = "okay"; };arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts line 716
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +1
-1@@ -712,7 +712,7 @@ &usbdrd_dwc3_0 { status = "okay"; - dr_mode = "otg"; + dr_mode = "host"; }; &usbdrd3_1 {Hi Vivek,
which is the relationship of your patch and this commit:
e1d9149e8389f1690cdd4e4056766dd26488a0fe
arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphirewith respect to this other commit:
c09b73cfac2a9317f1104169045c519c6021aa1d
usb: dwc3: don't setgadget->is_otgflag
Quoted 7 lines
?
I did not test reverting
e1d9149esincec09b73cfwas applied.Regards,
Vicenç.
Hi Vicenç,
Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms with usb-c port. After applying the fix, it worked.
I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
flag") and it will be interesting to test it. This might render
my fix unecessary.
Thanks,
Vivek
Heiko Stuebner
maintainerHi Vivek,
Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune:
Quoted 51 lines · Vicente Bergas
Quoted 40 lines · Vivek Unune
Quoted 20 lines
Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
Signed-off-by Vivek Unune <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +1
-1@@ -644,7 +644,7 @@ status = "okay"; u2phy0_host: host-port { - phy-supply = <&vcc5v0_host>; + phy-supply = <&vcc5v0_typec>; status = "okay"; };arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts line 716
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +1
-1@@ -712,7 +712,7 @@ &usbdrd_dwc3_0 { status = "okay"; - dr_mode = "otg"; + dr_mode = "host"; }; &usbdrd3_1 {Hi Vivek,
which is the relationship of your patch and this commit:
e1d9149e8389f1690cdd4e4056766dd26488a0fe
arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphirewith respect to this other commit:
c09b73cfac2a9317f1104169045c519c6021aa1d
usb: dwc3: don't setgadget->is_otgflagQuoted 7 lines
?
I did not test reverting
e1d9149esincec09b73cfwas applied.Regards,
Vicenç.Hi Vicenç,
Quoted 7 lines
Indeed, I was motivated by
e1d9149e("arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms with usb-c port. After applying the fix, it worked.I was not aware of
c09b73cf("usb: dwc3: don't setgadget->is_otg
flag") and it will be interesting to test it. This might render
my fix unecessary.
So I'll let this patch sit here for now.
Once you've done the testing, can you please respond with the result (both positive and negative results please).
Thanks
Heiko
Quoted 62 lines · Heiko Stuebner
Hi Vivek,
Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune:
Quoted 51 lines · Vicente Bergas
Quoted 40 lines · Vivek Unune
Quoted 20 lines
Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
Signed-off-by Vivek Unune <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +1
-1@@ -644,7 +644,7 @@ status = "okay"; u2phy0_host: host-port { - phy-supply = <&vcc5v0_host>; + phy-supply = <&vcc5v0_typec>; status = "okay"; };arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts line 716
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts +1
-1@@ -712,7 +712,7 @@ &usbdrd_dwc3_0 { status = "okay"; - dr_mode = "otg"; + dr_mode = "host"; }; &usbdrd3_1 {Hi Vivek,
which is the relationship of your patch and this commit:
e1d9149e8389f1690cdd4e4056766dd26488a0fe
arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphirewith respect to this other commit:
c09b73cfac2a9317f1104169045c519c6021aa1d
usb: dwc3: don't setgadget->is_otgflagQuoted 7 lines
?
I did not test reverting
e1d9149esincec09b73cfwas applied.Regards,
Vicenç.Hi Vicenç,
Quoted 7 lines
Indeed, I was motivated by
e1d9149e("arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms with usb-c port. After applying the fix, it worked.I was not aware of
c09b73cf("usb: dwc3: don't setgadget->is_otg
flag") and it will be interesting to test it. This might render
my fix unecessary.
Quoted 8 lines
So I'll let this patch sit here for now.
Once you've done the testing, can you please respond with the result (both positive and negative results please).Thanks
Heiko
Hi Heiko,
I tested the c09b73cf patch without modifying exsisting dts. I can confirm that that patch doesn't work for me. No usb-c devices were recognized.
Vicenç - were you able to test it?
As soon as I apply dts patch, usb-c devices are recognized.
Thanks,
Vivek
Quoted 11 lines · Vivek Unune
Quoted 3 lines · Heiko Stuebner
Hi Vivek,
Am Montag, 30. September 2019, 01:46:15 CEST schrieb Vivek Unune: ...
Hi Heiko,
I tested the
c09b73cfpatch without modifying exsisting dts. I can confirm that that patch doesn't work for me. No usb-c devices were recognized.Vicenç - were you able to test it?
I can also confirm that
c09b73cfac2a9317f1104169045c519c6021aa1d
usb: dwc3: don't set gadget->is_otg flag
alone does not fix the issue.
e1d9149e8389f1690cdd4e4056766dd26488a0fe
arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
is still required for the USB-C to work on the Sapphire board.
Regards,
Vicenç.
Quoted 5 lines
As soon as I apply dts patch, usb-c devices are recognized.
Thanks,
Vivek
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Am Sonntag, 29. September 2019, 05:22:30 CEST schrieb Vivek Unune:
Quoted 3 lines
Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
Signed-off-by Vivek Unune <[email protected]>
applied as fix for 5.4
Thanks
Heiko