net: dsa: rtl8366rb: add missing of_node_put after calling of_get_child_by_name
Subsystems (4)
PATCH 1/1 net: dsa: rtl8366rb: add missing of_node_put after calling of_get_child_by_name
of_node_put needs to be called when the device node which is got from of_get_child_by_name finished using. irq_domain_add_linear() also calls of_node_get() to increase refcount, so irq_domain will not be affected when it is released.
--- drivers/net/dsa/rtl8366rb.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/net/dsa/rtl8366rb.c +10 -6
@@ -507,7 +507,8 @@ static int rtl8366rb_setup_cascaded_irq(struct realtek_smi *smi) irq =of_irq_get (intc,0 );if (irq <=0 ) {dev_err (smi->dev,"failed to get parent IRQ\n" ); -return irq ? irq : -EINVAL ; + ret = irq ? irq : -EINVAL ; + goto out_put_node; }/* This clears the IRQ status register */
@@ -515,7 +516,7 @@ static int rtl8366rb_setup_cascaded_irq(struct realtek_smi *smi) &val);if (ret) {dev_err (smi->dev,"can't read interrupt status\n" ); -return ret; + goto out_put_node; }/* Fetch IRQ edge information from the descriptor */
@@ -537,7 +538,7 @@ static int rtl8366rb_setup_cascaded_irq(struct realtek_smi *smi) val);if (ret) {dev_err (smi->dev,"could not configure IRQ polarity\n" ); -return ret; + goto out_put_node; } ret = devm_request_threaded_irq(smi->dev, irq, NULL,
@@ -545,7 +546,7 @@ static int rtl8366rb_setup_cascaded_irq(struct realtek_smi *smi) "RTL8366RB", smi);if (ret) {dev_err (smi->dev,"unable to request irq: %d\n" , ret); -return ret; + goto out_put_node; } smi->irqdomain = irq_domain_add_linear(intc, RTL8366RB_NUM_INTERRUPT,
@@ -553,12 +554,15 @@ static int rtl8366rb_setup_cascaded_irq(struct realtek_smi *smi) smi);if (!smi->irqdomain) {dev_err (smi->dev,"failed to create IRQ domain\n" ); -return -EINVAL ; + ret = -EINVAL ; + goto out_put_node; }for (i =0 ; i < smi->num_ports; i++)irq_set_parent (irq_create_mapping (smi->irqdomain, i), irq); -return 0 ; +out_put_node: +of_node_put (intc); +return ret; }static int rtl8366rb_set_addr (struct realtek_smi *smi)
Signature · 1 line
1.8.3.1
On Sun, Sep 29, 2019 at 9:01 AM Wen Yang <[email protected]> wrote:
It's nice to see some Alibaba kernel contributions!
Quoted 5 lines
of_node_putneeds to be called when the device node which is got fromof_get_child_by_namefinished using.irq_domain_add_linear()also callsof_node_get()to increase refcount, soirq_domainwill not be affected when it is released.
Quoted 9 lines
Fixes d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")Signed-off-by Wen Yang <[email protected]>Cc Linus Walleij <[email protected]>Cc Andrew Lunn <[email protected]>Cc Vivien Didelot <[email protected]>Cc Florian Fainelli <[email protected]>Cc "David S. Miller" <[email protected]>
Yours,
Linus Walleij
David Miller
maintainerFrom: Wen Yang <[email protected]>
Date: Sun, 29 Sep 2019 15:00:47 +0800
Quoted 7 lines
of_node_putneeds to be called when the device node which is got fromof_get_child_by_namefinished using.irq_domain_add_linear()also callsof_node_get()to increase refcount, soirq_domainwill not be affected when it is released.Fixes d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")Signed-off-by Wen Yang <[email protected]>
Please capitalize Fixes:, seriously I am very curious where did you learned to specify the fixes tag non-capitalized?
Patch applied, t hanks.
Quoted 8 lines · David Miller
From: Wen Yang <[email protected]>
Date: Sun, 29 Sep 2019 15:00:47 +0800Quoted 5 lines
of_node_putneeds to be called when the device node which is got fromof_get_child_by_namefinished using.irq_domain_add_linear()also callsof_node_get()to increase refcount, soirq_domainwill not be affected when it is released.
Quoted 8 lines
Quoted 2 lines
Fixes d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")Signed-off-by Wen Yang <[email protected]>Please capitalize Fixes:, seriously I am very curious where did you learned to specify the fixes tag non-capitalized?
Patch applied, t hanks.
Thank you for your comments.
We checked the code repository and found that both ‘Fixes’ and ‘fixes’ are being used, such as:
commit a53651ec93a8d7ab5b26c5390e0c389048b4b4b6
…
net: ena: don't wake up tx queue when down
…
Network Adapters (ENA))
…
And,
commit 1df379924304b687263942452836db1d725155df …
clk: consoldiate the __clk_get_hw() declarations
…
clk-provider.h")
__clk_get() w/ CCF")
…
It is also found that the sha1 following ‘Fixes:’ requires at least 12 digits.
So we plan to modify the checkpatch.pl script to check for these issues.
scripts/checkpatch.pl +0 -1
@@ -2925,7 +2925,7 @@ sub process { } # check for invalid commit id - if ($in_commit_log && $line =~
/(^fixes:|\bcommit)\s+([0-9a-f]{6,40})\b/i) {
+ if ($in_commit_log && $line =~ /(\bcommit)\s+([0-9a-f]{6,40})\b/i) {
my $id;
my $description;
($id, $description) = git_commit_info($2, undef, undef);
@@ -2935,6 +2935,25 @@ sub process {
}
}
+# check for fixes tag
+ if ($in_commit_log && $line =~ /(^fixes:)\s+([0-9a-f]{6,40})\b/i) {
+ my $id;
+ my $description;
+ ($id, $description) = git_commit_info($2, undef, undef);
+ if (!defined($id)) {
+ WARN("UNKNOWN_COMMIT_ID",
+ "Unknown commit id '$2', maybe rebased or not pulled?\n" .
$herecurr);
+ }
+ if ($1 ne "Fixes") {
+ WARN("FIXES_TAG_STYLE",
+ "The fixes tag should be capitalized (Fixes:).\n" . $hereprev);
+ }
+ if (length($2) < 12) {
+ WARN("FIXES_TAG_STYLE",
+ "SHA1 should be at least 12 digits long.\n" . $hereprev);
+ }
+ }
+
# ignore non-hunk lines and lines being removed next if (!$hunk_line || $line =~ /^-/);
--
Best wishes,
Wen Yang