Staging: exfat: exfat_super.c Fixed coding style issues.
PATCH 3/3 Staging: exfat: exfat_super.c Fixed coding style issues.
Fixed Coding Style issues
Signed-off-by Jesse Barton <[email protected]>
--- drivers/staging/exfat/exfat_super.c | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-)
drivers/staging/exfat/exfat_super.c +9 -20
@@ -640,8 +640,7 @@ static int ffs_lookup_file(struct inode *inode, char *path, struct file_id_t *fireturn ret; } -static int ffs_create_file (struct inode *inode,char *path,u8 mode, -struct file_id_t *fid) +static int ffs_create_file (struct inode *inode,char *path,u8 mode,struct file_id_t *fid) {struct chain_t dir;struct uni_name_t uni_name;
@@ -681,8 +680,7 @@ static int ffs_create_file(struct inode *inode, char *path, u8 mode,return ret; } -static int ffs_read_file (struct inode *inode,struct file_id_t *fid,void *buffer, -u64 count,u64 *rcount) +static int ffs_read_file (struct inode *inode,struct file_id_t *fid,void *buffer,u64 count,u64 *rcount) {s32 offset, sec_offset, clu_offset;u32 clu;
@@ -805,8 +803,7 @@ static int ffs_read_file(struct inode *inode, struct file_id_t *fid, void *buffereturn ret; } -static int ffs_write_file (struct inode *inode,struct file_id_t *fid, -void *buffer,u64 count,u64 *wcount) +static int ffs_write_file (struct inode *inode,struct file_id_t *fid,void *buffer,u64 count,u64 *wcount) {bool modified = false;s32 offset, sec_offset, clu_offset;
@@ -1212,8 +1209,7 @@ static void update_parent_info(struct file_id_t *fid, } } -static int ffs_move_file (struct inode *old_parent_inode,struct file_id_t *fid, -struct inode *new_parent_inode,struct dentry *new_dentry) +static int ffs_move_file (struct inode *old_parent_inode,struct file_id_t *fid,struct inode *new_parent_inode,struct dentry *new_dentry) {s32 ret;s32 dentry;
@@ -2061,9 +2057,7 @@ static int ffs_read_dir(struct inode *inode, struct dir_entry_t *dir_entry) fs_func->get_uni_name_from_ext_entry (sb, &dir, dentry, uni_name.name);if (*uni_name.name ==0x0 && p_fs->vol_type !=EXFAT ) -get_uni_name_from_dos_entry (sb, - (struct dos_dentry_t *)ep, - &uni_name,0x1 ); +get_uni_name_from_dos_entry (sb, (struct dos_dentry_t *)ep, &uni_name,0x1 );nls_uniname_to_cstring (sb, dir_entry->Name, &uni_name);buf_unlock (sb, sector);
@@ -2074,11 +2068,8 @@ static int ffs_read_dir(struct inode *inode, struct dir_entry_t *dir_entry) goto out; } }else { -get_uni_name_from_dos_entry (sb, - (struct dos_dentry_t *)ep, - &uni_name,0x0 ); -nls_uniname_to_cstring (sb, dir_entry->ShortName, - &uni_name); +get_uni_name_from_dos_entry (sb, (struct dos_dentry_t *)ep, &uni_name,0x0 ); +nls_uniname_to_cstring (sb, dir_entry->ShortName, &uni_name); } dir_entry->Size = fs_func->get_entry_size (ep);
@@ -2460,8 +2451,7 @@ static struct dentry *exfat_lookup(struct inode *dir, struct dentry *dentry, err = -ENOMEM ; goto error; } -ffs_read_file (dir, &fid,EXFAT_I (inode)->target, -i_size_read (inode), &ret); +ffs_read_file (dir, &fid,EXFAT_I (inode)->target,i_size_read (inode), &ret); *(EXFAT_I (inode)->target +i_size_read (inode)) ='\0' ; }
@@ -2748,8 +2738,7 @@ static int exfat_rename(struct inode *old_dir, struct dentry *old_dentry,EXFAT_I (old_inode)->fid.size =i_size_read (old_inode); - err =ffs_move_file (old_dir, &(EXFAT_I (old_inode)->fid), new_dir, - new_dentry); + err =ffs_move_file (old_dir, &(EXFAT_I (old_inode)->fid), new_dir, new_dentry);if (err) {if (err ==FFS_PERMISSIONERR ) err = -EPERM ;
Signature · 1 line
2.23.0
Greg KH
maintainerQuoted 1 line · Jesse Barton
Fixed Coding Style issues
You need to be specific as to _what_ exactly you did here. What you wrote is very vague :)
thanks,
greg k-h
Quoted 1 line · Jesse Barton
Fixed Coding Style issues
Which ones?
Quoted 11 lines
Signed-off-by Jesse Barton <[email protected]>--- drivers/staging/exfat/exfat_super.c | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-)drivers/staging/exfat/exfat_super.c +0
-0
drivers/staging/exfat/exfat_super.c static int ffs_lookup_file(struct inode *inode, char *path, struct file_id_t *fi · line 643
Quoted 6 lines
drivers/staging/exfat/exfat_super.c +1
-2@@ -640,8 +640,7 @@ static int ffs_lookup_file(struct inode *inode, char *path, struct file_id_t *fireturn ret; } -static int ffs_create_file (struct inode *inode,char *path,u8 mode, -struct file_id_t *fid) +static int ffs_create_file (struct inode *inode,char *path,u8 mode,struct file_id_t *fid)
I think now checkpatch will complain that the line is too long? What we want here is:
static int ffs_create_file(struct inode *inode, char *path, u8 mode,
struct file_id_t *fid)
[tab][tab][tab][space][space][space]struct file_id_t *fid)
So they line up.
regards,
dan carpenter