Skip to contentSkip to conversation

package/mesa3d: remove -mno-compact-eh for Code Sourcery MIPS

PATCH New Bernd Kuhls 2 participants 2 messages Sep 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mesa3d: remove -mno-compact-eh for Code Sourcery MIPS

https://git.buildroot.net/buildroot/commit/package/mesa3d?id=e032a29604e843c8adc551d5ceb3c45bc7715b4d
added -mno-compact-eh to CFLAGS/CXXFLAGS.

This breaks mesa build since its switch to meson:

Sanity check compile stderr:
cc: error: unrecognized command line option ?-mno-compact-eh?; did you mean ?-fno-compare-elim??

It turns out that mesa3d still builds now with this option.

Fixes:
http://autobuild.buildroot.net/results/37f/37fce69751aa31ae467d502e660d7db513333d4d/

---
 package/mesa3d/mesa3d.mk | 8 --------
 1 file changed, 8 deletions(-)
package/mesa3d/mesa3d.mk +0 -8
index b47c6b9b2e..35fe2bdbe5 100644
@@ -54,14 +54,6 @@ ifeq ($(BR2_PACKAGE_MESA3D_NEEDS_ELFUTILS),y)
 MESA3D_DEPENDENCIES += elfutils
 endif
 
-# The Sourcery MIPS toolchain has a special (non-upstream) feature to
-# have "compact exception handling", which unfortunately breaks with
-# mesa3d, so we disable it here by passing -mno-compact-eh.
-ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS),y)
-MESA3D_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -mno-compact-eh"
-MESA3D_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -mno-compact-eh"
-endif
-
 ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
 # Disable-mangling not yet supported by meson build system.
 # glx:
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/mesa3d: remove -mno-compact-eh for Code Sourcery MIPS

Quoted 10 lines · On Sun, 29 Sep 2019 08:47:24 +0200 Bernd Kuhls <[email protected]> wrote:

https://git.buildroot.net/buildroot/commit/package/mesa3d?id=e032a29604e843c8adc551d5ceb3c45bc7715b4d
added -mno-compact-eh to CFLAGS/CXXFLAGS.

This breaks mesa build since its switch to meson:

Sanity check compile stderr:
cc: error: unrecognized command line option ?-mno-compact-eh?; did you mean ?-fno-compare-elim??

It turns out that mesa3d still builds now with this option.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/37f/37fce69751aa31ae467d502e660d7db513333d4d/

---
 package/mesa3d/mesa3d.mk | 8 --------
 1 file changed, 8 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com