Staging: exfat: exfat_super.c: fixed camelcase coding style issue
PATCH 1/3 Staging: exfat: exfat_super.c: fixed camelcase coding style issue
Changed function names:
ffsUmountVol to ffs_umount_vol
ffsMountVol to ffs_mount_vol
ffsSyncVol to ffs_sync_vol
--- drivers/staging/exfat/exfat_super.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
drivers/staging/exfat/exfat_super.c +10 -10
@@ -342,7 +342,7 @@ static inline void exfat_save_attr(struct inode *inode, u32 attr)EXFAT_I (inode)->fid.attr = attr & (ATTR_RWMASK |ATTR_READONLY ); } -static int ffsMountVol (struct super_block *sb) +static int ffs_mount_vol (struct super_block *sb) {int i, ret;struct pbr_sector_t *p_pbr;
@@ -446,7 +446,7 @@ static int ffsMountVol(struct super_block *sb)return ret; } -static int ffsUmountVol (struct super_block *sb) +static int ffs_umount_vol (struct super_block *sb) {struct fs_info_t *p_fs = &(EXFAT_SB (sb)->fs_info);int err =FFS_SUCCESS ;
@@ -518,7 +518,7 @@ static int ffsGetVolInfo(struct super_block *sb, struct vol_info_t *info)return err; } -static int ffsSyncVol (struct super_block *sb,bool do_sync) +static int ffs_sync_vol (struct super_block *sb,bool do_sync) {int err =FFS_SUCCESS ;struct fs_info_t *p_fs = &(EXFAT_SB (sb)->fs_info);
@@ -3043,7 +3043,7 @@ static int exfat_file_release(struct inode *inode, struct file *filp)struct super_block *sb = inode->i_sb;EXFAT_I (inode)->fid.size =i_size_read (inode); -ffsSyncVol (sb, false); +ffs_sync_vol (sb, false);return 0 ; }
@@ -3460,7 +3460,7 @@ static void exfat_put_super(struct super_block *sb)if (__is_sb_dirty (sb))exfat_write_super (sb); -ffsUmountVol (sb); +ffs_umount_vol (sb); sb->s_fs_info =NULL ;exfat_free_super (sbi);
@@ -3473,7 +3473,7 @@ static void exfat_write_super(struct super_block *sb)__set_sb_clean (sb);if (!sb_rdonly (sb)) -ffsSyncVol (sb, true); +ffs_sync_vol (sb, true);__unlock_super (sb); }
@@ -3485,7 +3485,7 @@ static int exfat_sync_fs(struct super_block *sb, int wait)if (__is_sb_dirty (sb)) {__lock_super (sb);__set_sb_clean (sb); - err =ffsSyncVol (sb, true); + err =ffs_sync_vol (sb, true);__unlock_super (sb); }
@@ -3865,10 +3865,10 @@ static int exfat_fill_super(struct super_block *sb, void *data, int silent)sb_min_blocksize (sb,512 ); sb->s_maxbytes =0x7fffffffffffffffLL ;/* maximum file size */ - ret =ffsMountVol (sb); + ret =ffs_mount_vol (sb);if (ret) {if (!silent) -pr_err ("[EXFAT] ffsMountVol failed\n" ); +pr_err ("[EXFAT] ffs_mount_vol failed\n" ); goto out_fail; }
@@ -3919,7 +3919,7 @@ static int exfat_fill_super(struct super_block *sb, void *data, int silent)return 0 ; out_fail2: -ffsUmountVol (sb); +ffs_umount_vol (sb); out_fail:if (root_inode)iput (root_inode);
Signature · 1 line
2.23.0
Greg KH
maintainerQuoted 6 lines · Jesse Barton
Changed function names:
ffsUmountVol toffs_umount_vol
ffsMountVol toffs_mount_vol
ffsSyncVol toffs_sync_vol
That says _what_ you did, but not _why_ you are doing this.
And is this really the best name for these functions? Why the ffs_* prefix?
Also, you didn't include the maintainer again, and you didn't thread your emails using 'git send-email' :(
And finally, you sent a new version of the patch, but did not "version" it, saying what changed from the previous version. The documentation says how to do this, so you might want to re-read that.
Can you please fix this all up and resend the series as "v3"?
thanks,
greg k-h