Skip to contentSkip to conversation

u-boot-ti: Drop using COREBASE

PATCH In review Khem Raj 2 participants 11 messages Sep 29, 2019 – Oct 1, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/3 u-boot-ti: Drop using COREBASE

COREBASE is hardcoding the path and moreover its obsolete the better way is to use relative path which is automatically searched in BBPATH by bitbake

---
 recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-bsp/u-boot/u-boot-ti.inc +1 -1
index f1187e64..f7434712 100644
@@ -13,7 +13,7 @@ UBOOT_LOCALVERSION = "-g${@get_git_revision('${S}').__str__()[:10]}"
 UBOOT_SUFFIX ?= "img"
 SPL_BINARY ?= "MLO"
 
-require ${COREBASE}/meta/recipes-bsp/u-boot/u-boot.inc
+require recipes-bsp/u-boot/u-boot.inc
 
 FILESEXTRAPATHS_prepend := "${THISDIR}/u-boot:"
 
Signature · 1 line
2.23.0
author
#1 lore raw

PATCH 2/3 recipes-ti: Use COMMON_LICENSE_DIR instead of COREBASE

Fixes
beaglebone-capes-1.0-r4 do_populate_lic: ${COREBASE}/LICENSE is not a valid license file, please use '${COMMON_LICENSE_DIR}/MIT' for a MIT License file in LIC_FILES_CHKSUM. This will become an error in the future

---
 recipes-ti/beagleboard/beaglebone-capes.bb | 2 +-
 recipes-ti/beagleboard/gadget-init.bb      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
recipes-ti/beagleboard/beaglebone-capes.bb +1 -1
index 30b985b5..569a3e5a 100644
@@ -1,7 +1,7 @@
 DESCRIPTION = "Userspace setup for beaglebone capes"
 
 LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=b97a012949927931feb7793eee5ed924 "
+LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
 
 PR = "r4"
 
recipes-ti/beagleboard/gadget-init.bb +1 -1
index 8b899c51..b546efbb 100644
@@ -3,7 +3,7 @@ DESCRIPTION = "Units to initialize usb gadgets"
 PR = "r19"
 
 LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690"
+LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
 
 COMPATIBLE_MACHINE = "(ti33x)"
 PACKAGE_ARCH = "${MACHINE_ARCH}"
Signature · 1 line
2.23.0
author
#2 lore raw

PATCH 3/3 beaglebone-getting-started: Mention CC-BY-SA-3.0 and correct GPL version

In reply to Khem Raj

This is as per
https://github.com/jadonk/beaglebone-getting-started/blob/master/LICENSE.txt

---
 recipes-ti/beagleboard/beaglebone-getting-started.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-ti/beagleboard/beaglebone-getting-started.bb +1 -1
index 6c61a4e9..c86e3518 100644
@@ -4,7 +4,7 @@ PR = "r21"
 
 inherit allarch
 
-LICENSE = "GPLv2+ & MIT & PD & others"
+LICENSE = "CC-BY-SA-3.0 & GPLv3+ & MIT & PD & others"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=603591dea023c3c75b48e07cb47ce639"
 
 SRCREV = "6c548a307c948b28a99d48fd17d9790b56182196"
Signature · 1 line
2.23.0
#3 lore raw

Re: [PATCH 3/3] beaglebone-getting-started: Mention CC-BY-SA-3.0 and correct GPL version

Quoted 2 lines · Khem Raj

This is as per
https://github.com/jadonk/beaglebone-getting-started/blob/master/LICENSE.txt

You are looking at the latest LICENSE file, while the recipe hasn't updated its SRCREV since early 2012, back when beagleboard.org was still active in OE. Specifically, GPLv3+ was added in 2013:
https://github.com/jadonk/beaglebone-getting-started/commits/master/LICENSE.txt

We don't use this package, but I kept it in case someone still needs it. I did put a README with a note in that directory:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/tree/recipes-ti/README

Probably, this can be updated to the latest, as part of fixing the LICENSE? :)

Denys

Quoted 26 lines
---
 recipes-ti/beagleboard/beaglebone-getting-started.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-ti/beagleboard/beaglebone-getting-started.bb +1 -1
index 6c61a4e9..c86e3518 100644
@@ -4,7 +4,7 @@ PR = "r21"
 
 inherit allarch
 
-LICENSE = "GPLv2+ & MIT & PD & others"
+LICENSE = "CC-BY-SA-3.0 & GPLv3+ & MIT & PD & others"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=603591dea023c3c75b48e07cb47ce639"
 
 SRCREV = "6c548a307c948b28a99d48fd17d9790b56182196"
Signature · 7 lines
2.23.0

-- 
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
author
#4 lore raw

Re: [PATCH 3/3] beaglebone-getting-started: Mention CC-BY-SA-3.0 and correct GPL version

Quoted 9 lines · Denys Dmytriyenko
Quoted 2 lines · Khem Raj

This is as per
https://github.com/jadonk/beaglebone-getting-started/blob/master/LICENSE.txt

You are looking at the latest LICENSE file, while the recipe hasn't updated its SRCREV since early 2012, back when beagleboard.org was still active in OE. Specifically, GPLv3+ was added in 2013:
https://github.com/jadonk/beaglebone-getting-started/commits/master/LICENSE.txt

Quoted 6 lines

We don't use this package, but I kept it in case someone still needs it. I did put a README with a note in that directory:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/tree/recipes-ti/README

Probably, this can be updated to the latest, as part of fixing the LICENSE? :)

The README should be specific about which recipes are not maintained, it has a general statement which gives a scare, if the recipe is not maintained then this should be removed or atleast blacklisted if you still want to keep it around.

I was trying to help clearing up license warnings, other than that I dont have any interest in this recipe.

I can send a patch to blacklist it if thats fine with you.

Quoted 29 lines

Denys

Quoted 26 lines
---
 recipes-ti/beagleboard/beaglebone-getting-started.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-ti/beagleboard/beaglebone-getting-started.bb +1 -1
index 6c61a4e9..c86e3518 100644
@@ -4,7 +4,7 @@ PR = "r21"
 
 inherit allarch
 
-LICENSE = "GPLv2+ & MIT & PD & others"
+LICENSE = "CC-BY-SA-3.0 & GPLv3+ & MIT & PD & others"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=603591dea023c3c75b48e07cb47ce639"
 
 SRCREV = "6c548a307c948b28a99d48fd17d9790b56182196"
Signature · 7 lines
2.23.0

-- 
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
#5 lore raw

Re: [PATCH 3/3] beaglebone-getting-started: Mention CC-BY-SA-3.0 and correct GPL version

Quoted 24 lines · Khem Raj
Quoted 9 lines · Denys Dmytriyenko
Quoted 2 lines · Khem Raj

This is as per
https://github.com/jadonk/beaglebone-getting-started/blob/master/LICENSE.txt

You are looking at the latest LICENSE file, while the recipe hasn't updated its SRCREV since early 2012, back when beagleboard.org was still active in OE. Specifically, GPLv3+ was added in 2013:
https://github.com/jadonk/beaglebone-getting-started/commits/master/LICENSE.txt

Quoted 6 lines

We don't use this package, but I kept it in case someone still needs it. I did put a README with a note in that directory:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/tree/recipes-ti/README

Probably, this can be updated to the latest, as part of fixing the LICENSE? :)

The README should be specific about which recipes are not maintained, it has a general statement which gives a scare, if the recipe is not maintained then this should be removed or atleast blacklisted if you still want to keep it around.

Quoted 4 lines

I was trying to help clearing up license warnings, other than that I dont have any interest in this recipe.

I can send a patch to blacklist it if thats fine with you.

Fair enough, let me take a look at it myself.

Quoted 26 lines
Quoted 26 lines
Quoted 26 lines
---
 recipes-ti/beagleboard/beaglebone-getting-started.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-ti/beagleboard/beaglebone-getting-started.bb +1 -1
index 6c61a4e9..c86e3518 100644
@@ -4,7 +4,7 @@ PR = "r21"
 
 inherit allarch
 
-LICENSE = "GPLv2+ & MIT & PD & others"
+LICENSE = "CC-BY-SA-3.0 & GPLv3+ & MIT & PD & others"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=603591dea023c3c75b48e07cb47ce639"
 
 SRCREV = "6c548a307c948b28a99d48fd17d9790b56182196"
Signature · 7 lines
2.23.0

-- 
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
#6 lore raw

Re: [PATCH 3/3] beaglebone-getting-started: Mention CC-BY-SA-3.0 and correct GPL version

Quoted 20 lines · Denys Dmytriyenko
Quoted 19 lines · Khem Raj
Quoted 15 lines · Denys Dmytriyenko
Quoted 2 lines · Khem Raj

This is as per
https://github.com/jadonk/beaglebone-getting-started/blob/master/LICENSE.txt

You are looking at the latest LICENSE file, while the recipe hasn't updated its SRCREV since early 2012, back when beagleboard.org was still active in OE. Specifically, GPLv3+ was added in 2013:
https://github.com/jadonk/beaglebone-getting-started/commits/master/LICENSE.txt

We don't use this package, but I kept it in case someone still needs it. I did put a README with a note in that directory:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/tree/recipes-ti/README

Probably, this can be updated to the latest, as part of fixing the LICENSE? :)

Quoted 6 lines
Quoted 6 lines

The README should be specific about which recipes are not maintained, it has a general statement which gives a scare, if the recipe is not maintained then this should be removed or atleast blacklisted if you still want to keep it around.

I was trying to help clearing up license warnings, other than that I

BTW, the only warning I see for this recipe, is that "others" license is unknown. Your patch was not addressing it - should I just remove "others" from the list, as this was back from the days when the list wasn't checked so strictly?

Quoted 38 lines
Quoted 3 lines

dont have any interest in this recipe.

I can send a patch to blacklist it if thats fine with you.

Fair enough, let me take a look at it myself.

Quoted 26 lines
Quoted 26 lines
Quoted 26 lines
---
 recipes-ti/beagleboard/beaglebone-getting-started.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-ti/beagleboard/beaglebone-getting-started.bb +1 -1
index 6c61a4e9..c86e3518 100644
@@ -4,7 +4,7 @@ PR = "r21"
 
 inherit allarch
 
-LICENSE = "GPLv2+ & MIT & PD & others"
+LICENSE = "CC-BY-SA-3.0 & GPLv3+ & MIT & PD & others"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=603591dea023c3c75b48e07cb47ce639"
 
 SRCREV = "6c548a307c948b28a99d48fd17d9790b56182196"
Signature · 7 lines
2.23.0

-- 
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
Signature · 4 lines
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
author
#7 lore raw

Re: [PATCH 3/3] beaglebone-getting-started: Mention CC-BY-SA-3.0 and correct GPL version

Quoted 27 lines · Denys Dmytriyenko
Quoted 25 lines · Denys Dmytriyenko
Quoted 24 lines · Khem Raj
Quoted 9 lines · Denys Dmytriyenko
Quoted 2 lines · Khem Raj

This is as per
https://github.com/jadonk/beaglebone-getting-started/blob/master/LICENSE.txt

You are looking at the latest LICENSE file, while the recipe hasn't updated its SRCREV since early 2012, back when beagleboard.org was still active in OE. Specifically, GPLv3+ was added in 2013:
https://github.com/jadonk/beaglebone-getting-started/commits/master/LICENSE.txt

Quoted 6 lines

We don't use this package, but I kept it in case someone still needs it. I did put a README with a note in that directory:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/tree/recipes-ti/README

Probably, this can be updated to the latest, as part of fixing the LICENSE? :)

The README should be specific about which recipes are not maintained, it has a general statement which gives a scare, if the recipe is not maintained then this should be removed or atleast blacklisted if you still want to keep it around.

Quoted 7 lines
Quoted 1 line
Quoted 1 line

I was trying to help clearing up license warnings, other than that I

BTW, the only warning I see for this recipe, is that "others" license is unknown. Your patch was not addressing it - should I just remove "others" from the list, as this was back from the days when the list wasn't checked so strictly?

Yes, go ahead.

Quoted 39 lines
Quoted 39 lines
Quoted 4 lines

dont have any interest in this recipe.

I can send a patch to blacklist it if thats fine with you.

Fair enough, let me take a look at it myself.

Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
---
 recipes-ti/beagleboard/beaglebone-getting-started.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-ti/beagleboard/beaglebone-getting-started.bb +1 -2
index 6c61a4e9..c86e3518 100644
@@ -4,7 +4,7 @@ PR = "r21"
 
 inherit allarch
 
-LICENSE = "GPLv2+ & MIT & PD & others"
+LICENSE = "CC-BY-SA-3.0 & GPLv3+ & MIT & PD & others"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=603591dea023c3c75b48e07cb47ce639"
 
 SRCREV = "6c548a307c948b28a99d48fd17d9790b56182196"
--

2.23.0

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

--
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

#8 lore raw

Re: [PATCH 3/3] beaglebone-getting-started: Mention CC-BY-SA-3.0 and correct GPL version

Quoted 30 lines · Khem Raj
Quoted 29 lines · Denys Dmytriyenko
Quoted 26 lines · Denys Dmytriyenko
Quoted 25 lines · Khem Raj
Quoted 9 lines · Denys Dmytriyenko
Quoted 2 lines · Khem Raj

This is as per
https://github.com/jadonk/beaglebone-getting-started/blob/master/LICENSE.txt

You are looking at the latest LICENSE file, while the recipe hasn't updated its SRCREV since early 2012, back when beagleboard.org was still active in OE. Specifically, GPLv3+ was added in 2013:
https://github.com/jadonk/beaglebone-getting-started/commits/master/LICENSE.txt

Quoted 6 lines

We don't use this package, but I kept it in case someone still needs it. I did put a README with a note in that directory:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/tree/recipes-ti/README

Probably, this can be updated to the latest, as part of fixing the LICENSE? :)

The README should be specific about which recipes are not maintained, it has a general statement which gives a scare, if the recipe is not maintained then this should be removed or atleast blacklisted if you still want to keep it around.

I was trying to help clearing up license warnings, other than that I

Quoted 7 lines
Quoted 5 lines

BTW, the only warning I see for this recipe, is that "others" license is unknown. Your patch was not addressing it - should I just remove "others" from the list, as this was back from the days when the list wasn't checked so strictly?

Yes, go ahead.

https://lists.yoctoproject.org/pipermail/meta-ti/2019-September/012292.html

Quoted 38 lines
Quoted 38 lines
Quoted 38 lines
Quoted 3 lines

dont have any interest in this recipe.

I can send a patch to blacklist it if thats fine with you.

Fair enough, let me take a look at it myself.

Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
---
 recipes-ti/beagleboard/beaglebone-getting-started.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-ti/beagleboard/beaglebone-getting-started.bb +1 -2
index 6c61a4e9..c86e3518 100644
@@ -4,7 +4,7 @@ PR = "r21"
 
 inherit allarch
 
-LICENSE = "GPLv2+ & MIT & PD & others"
+LICENSE = "CC-BY-SA-3.0 & GPLv3+ & MIT & PD & others"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=603591dea023c3c75b48e07cb47ce639"
 
 SRCREV = "6c548a307c948b28a99d48fd17d9790b56182196"
--

2.23.0

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

--
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

#9 lore raw
In reply to Khem Raj
Quoted 3 lines · Khem Raj

COREBASE is hardcoding the path and moreover its obsolete the better way is to use relative path which is automatically searched in BBPATH by bitbake

This was actually done on purpose - there are many versions of u-boot.bb and u-boot.inc in different OE layers:
https://layers.openembedded.org/layerindex/branch/master/recipes/?q=u-boot

To avoid any conflicts, I specifically include the one from OE-Core.

COREBASE itself is not obsolete, just ${COREBASE}/LICENSE is:
https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#var-COREBASE
https://git.openembedded.org/openembedded-core/tree/meta/conf/layer.conf#n20
https://git.openembedded.org/openembedded-core/tree/meta/classes/insane.bbclass#n468

Signature · 1 line
Denys
Quoted 26 lines
---
 recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-bsp/u-boot/u-boot-ti.inc +1 -1
index f1187e64..f7434712 100644
@@ -13,7 +13,7 @@ UBOOT_LOCALVERSION = "-g${@get_git_revision('${S}').__str__()[:10]}"
 UBOOT_SUFFIX ?= "img"
 SPL_BINARY ?= "MLO"
 
-require ${COREBASE}/meta/recipes-bsp/u-boot/u-boot.inc
+require recipes-bsp/u-boot/u-boot.inc
 
 FILESEXTRAPATHS_prepend := "${THISDIR}/u-boot:"
 
Signature · 7 lines
2.23.0

-- 
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
author
#10 lore raw
Quoted 6 lines · Denys Dmytriyenko
Quoted 3 lines · Khem Raj

COREBASE is hardcoding the path and moreover its obsolete the better way is to use relative path which is automatically searched in BBPATH by bitbake

Quoted 6 lines

This was actually done on purpose - there are many versions of u-boot.bb and u-boot.inc in different OE layers:
https://layers.openembedded.org/layerindex/branch/master/recipes/?q=u-boot

To avoid any conflicts, I specifically include the one from OE-Core.

hmm I guess not pretty but seems fine here. Lets drop this patch.

Quoted 35 lines

COREBASE itself is not obsolete, just ${COREBASE}/LICENSE is:
https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#var-COREBASE
https://git.openembedded.org/openembedded-core/tree/meta/conf/layer.conf#n20
https://git.openembedded.org/openembedded-core/tree/meta/classes/insane.bbclass#n468

--
Denys

Quoted 26 lines
---
 recipes-bsp/u-boot/u-boot-ti.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-bsp/u-boot/u-boot-ti.inc +1 -2
index f1187e64..f7434712 100644
@@ -13,7 +13,7 @@ UBOOT_LOCALVERSION = "-g${@get_git_revision('${S}').__str__()[:10]}"
 UBOOT_SUFFIX ?= "img"
 SPL_BINARY ?= "MLO"
 
-require ${COREBASE}/meta/recipes-bsp/u-boot/u-boot.inc
+require recipes-bsp/u-boot/u-boot.inc
 
 FILESEXTRAPATHS_prepend := "${THISDIR}/u-boot:"
 
--

2.23.0

--
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti