Skip to contentSkip to conversation

PCI/switchtec: read all 64bits of part_event_bitmap

PATCH Applied Logan Gunthorpe 2 participants 2 messages Sep 10, 2019 – Sep 30, 2019

Subsystems (2)
lore
Share & tools
lore

Logan Gunthorpe

author maintainer
#0 lore raw

PATCH 1/1 PCI/switchtec: read all 64bits of part_event_bitmap

The part_event_bitmap register is 64 bits wide and should be read with ioread64 instead of the 32-bit ioread32.

---
 drivers/pci/switch/switchtec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/switch/switchtec.c +1 -1
index 8c94cd3fd1f2..465d6afd826e 100644
@@ -675,7 +675,7 @@ static int ioctl_event_summary(struct switchtec_dev *stdev,
 		return -ENOMEM;
 
 	s->global = ioread32(&stdev->mmio_sw_event->global_summary);
-	s->part_bitmap = ioread32(&stdev->mmio_sw_event->part_event_bitmap);
+	s->part_bitmap = ioread64(&stdev->mmio_sw_event->part_event_bitmap);
 	s->local_part = ioread32(&stdev->mmio_part_cfg->part_event_summary);
 
 	for (i = 0; i < stdev->partition_count; i++) {
Signature · 1 line
2.20.1
#1 lore raw
Quoted 7 lines · Logan Gunthorpe

The part_event_bitmap register is 64 bits wide and should be read with ioread64 instead of the 32-bit ioread32.

Applied to pci/switchtec for v5.5, thanks!

I added:

Fixes 52eabba5bcdb ("switchtec: Add IOCTLs to the Switchtec driver")
Cc [email protected] # v4.12+

Object if you don't want those.

Quoted 20 lines
---
 drivers/pci/switch/switchtec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/switch/switchtec.c +1 -1
index 8c94cd3fd1f2..465d6afd826e 100644
@@ -675,7 +675,7 @@ static int ioctl_event_summary(struct switchtec_dev *stdev,
 		return -ENOMEM;
 
 	s->global = ioread32(&stdev->mmio_sw_event->global_summary);
-	s->part_bitmap = ioread32(&stdev->mmio_sw_event->part_event_bitmap);
+	s->part_bitmap = ioread64(&stdev->mmio_sw_event->part_event_bitmap);
 	s->local_part = ioread32(&stdev->mmio_part_cfg->part_event_summary);
 
 	for (i = 0; i < stdev->partition_count; i++) {
Signature · 1 line
2.20.1