PCI/switchtec: read all 64bits of part_event_bitmap
Subsystems (2)
Logan Gunthorpe
maintainerPATCH 1/1 PCI/switchtec: read all 64bits of part_event_bitmap
The part_event_bitmap register is 64 bits wide and should be read with ioread64 instead of the 32-bit ioread32.
Reported-by Doug Meyer <[email protected]>
Signed-off-by Logan Gunthorpe <[email protected]>
Cc Bjorn Helgaas <[email protected]>
Cc Kelvin Cao <[email protected]>
--- drivers/pci/switch/switchtec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/switch/switchtec.c +1 -1
@@ -675,7 +675,7 @@ static int ioctl_event_summary(struct switchtec_dev *stdev,return -ENOMEM ; s->global =ioread32 (&stdev->mmio_sw_event->global_summary); - s->part_bitmap =ioread32 (&stdev->mmio_sw_event->part_event_bitmap); + s->part_bitmap =ioread64 (&stdev->mmio_sw_event->part_event_bitmap); s->local_part =ioread32 (&stdev->mmio_part_cfg->part_event_summary);for (i =0 ; i < stdev->partition_count; i++) {
Signature · 1 line
2.20.1
Bjorn Helgaas
AppliedQuoted 7 lines · Logan Gunthorpe
The
part_event_bitmapregister is 64 bits wide and should be read with ioread64 instead of the 32-bit ioread32.Reported-by Doug Meyer <[email protected]>Signed-off-by Logan Gunthorpe <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Kelvin Cao <[email protected]>
Applied to pci/switchtec for v5.5, thanks!
I added:
Fixes 52eabba5bcdb ("switchtec: Add IOCTLs to the Switchtec driver")
Cc [email protected] # v4.12+
Object if you don't want those.
Quoted 20 lines
--- drivers/pci/switch/switchtec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/switch/switchtec.c +1
-1@@ -675,7 +675,7 @@ static int ioctl_event_summary(struct switchtec_dev *stdev,return -ENOMEM ; s->global =ioread32 (&stdev->mmio_sw_event->global_summary); - s->part_bitmap =ioread32 (&stdev->mmio_sw_event->part_event_bitmap); + s->part_bitmap =ioread64 (&stdev->mmio_sw_event->part_event_bitmap); s->local_part =ioread32 (&stdev->mmio_part_cfg->part_event_summary);for (i =0 ; i < stdev->partition_count; i++) {Signature · 1 line
2.20.1