Odroid c2 missing regulator linking
Subsystems (2)
v3 cover Odroid c2 missing regulator linking
Looks like this changes got lost so resend these changes again.
Below small changes help re-configure or fix missing inter linking of regulator node.
Re-based on *next-20191001*
Changes from previous patch's series.
Build using Cross Compiler.
Added missing Reviewed-by Neil's and Martin. Added few suggestion from martin for rename of node.
Changes for previous changes.
Fix some typo.
Updated few patches as per Martin's suggestion.
Best Regards
-Anand
Anand Moon (3):
arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0
regulator
arm64: dts: meson: odroid-c2: Add missing regulator linked to
VDDIO_AO3V3 regulator
arm64: dts: meson: odroid-c2: Add missing regulator linked to HDMI
supply
.../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 53 +++++++++++++++++-- 1 file changed, 50 insertions(+), 3 deletions(-)
Signature · 1 line
2.23.0
PATCH v3 1/3 arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator
As per schematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC:
fixed regulator output which is supplied by P5V0.
---
Changes from previous.
patchv1.
- drop the rename and linking vcc3v3 regulator node.
- fix the typo spelling.
patchv2.
- change the vddc_ddr node name to ddr3_1v5 as per Martin's suggestion
- Added Matrin's and Neil's Reviewed-by.
--- .../boot/dts/amlogic/meson-gxbb-odroidc2.dts | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +30 -0
@@ -111,6 +111,36 @@ regulator-max-microvolt = <3300000>; }; + vddio_ao1v8: regulator-vddio-ao1v8 { + compatible = "regulator-fixed"; + regulator-name = "VDDIO_AO1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + /* U17 RT9179GB */ + vin-supply = <&p5v0>; + }; + + vddio_ao3v3: regulator-vddio-ao3v3 { + compatible = "regulator-fixed"; + regulator-name = "VDDIO_AO3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + /* U11 MP2161GJ-C499 */ + vin-supply = <&p5v0>; + }; + + ddr3_1v5: regulator-ddr3_1v5 { + compatible = "regulator-fixed"; + regulator-name = "DDR3_1V5"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; + regulator-always-on; + /* U15 MP2161GJ-C499 */ + vin-supply = <&p5v0>; + }; + emmc_pwrseq: emmc-pwrseq { compatible = "mmc-pwrseq-emmc"; reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.23.0
PATCH v3 2/3 arm64: dts: meson: odroid-c2: Add missing regulator linked to VDDIO_AO3V3 regulator
In reply to Anand MoonAs per schematics TFLASH_VDD, TF_IO, VCC3V3 fixed regulator output which is supplied by VDDIO_AO3V3.
While here, move the comment name with the signal name in the schematics above the gpio property to make it consistent with other regulators.
---
changes from previous.
Patchv1
- Fix the typo.
- Add the comment as per Martin's suggestion.
- Added Martin's review tags
Patchv2
- Added missing Neil's Reviewed-by tags.
--- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +10 -3
@@ -67,17 +67,19 @@ }; tflash_vdd: regulator-tflash_vdd { - /* - * signal name from schematics: TFLASH_VDD_EN - */ compatible = "regulator-fixed"; regulator-name = "TFLASH_VDD"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; + /* + * signal name from schematics: TFLASH_VDD_EN + */ gpio = <&gpio GPIOY_12 GPIO_ACTIVE_HIGH>; enable-active-high; + /* U16 RT9179GB */ + vin-supply = <&vddio_ao3v3>; }; tf_io: gpio-regulator-tf_io {
@@ -95,6 +97,8 @@ states = <3300000 0>, <1800000 1>; + /* U12/U13 RT9179GB */ + vin-supply = <&vddio_ao3v3>; }; vcc1v8: regulator-vcc1v8 {
@@ -102,6 +106,9 @@ regulator-name = "VCC1V8"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-always-on; + /* U18 RT9179GB */ + vin-supply = <&vddio_ao3v3>; }; vcc3v3: regulator-vcc3v3 {
Signature · 1 line
2.23.0
PATCH v3 3/3 arm64: dts: meson: odroid-c2: Add missing regulator linked to HDMI supply
In reply to Anand MoonAs per schematics HDMI_P5V0 is supplied by P5V0 so add missing link.
---
Changes from previous
Patchv1
- As per Martin's suggestion added the HDMI_P5V0 fix regulator node. Patchv2
- Added Matrin's and Neil's Reviewed-by.
--- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +10 -0
@@ -66,6 +66,15 @@ regulator-always-on; }; + hdmi_p5v0: regulator-hdmi_p5v0 { + compatible = "regulator-fixed"; + regulator-name = "HDMI_P5V0"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + /* AP2331SA-7 */ + vin-supply = <&p5v0>; + }; + tflash_vdd: regulator-tflash_vdd { compatible = "regulator-fixed";
@@ -220,6 +229,7 @@ status = "okay"; pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>; pinctrl-names = "default"; + hdmi-supply = <&hdmi_p5v0>; }; &hdmi_tx_tmds_port {
Signature · 1 line
2.23.0
Kevin Hilman
maintainerQuoted 1 line · Anand Moon
Looks like this changes got lost so resend these changes again.
Yeah, sorry about that. Your cover letter subjects were quite similar, and several versions of this series and the previoius series arrived close together, so some stuff fell through the cracks. Sorry about that.
Queued for v5.5 now,
Thanks,
Kevin
Hi Kevin,
Quoted 9 lines · Kevin Hilman
Quoted 1 line · Anand Moon
Looks like this changes got lost so resend these changes again.
Yeah, sorry about that. Your cover letter subjects were quite similar, and several versions of this series and the previoius series arrived close together, so some stuff fell through the cracks. Sorry about that.
I will keep this in my mind and do not repeat my silly mistakes.
Quoted 4 lines
Queued for v5.5 now,
Thanks,
No worries, thanks for the update!
Quoted 2 lines
Kevin
Best Regards
-Anand