Skip to contentSkip to conversation

rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

PATCH In review Austin Kim 3 participants 5 messages Sep 17, 2019 – Oct 1, 2019 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

Austin Kim

author
#0 lore raw

PATCH 1/1 rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

'rtstatus' local variable is not used,
so remove it for clean-up.

---
 drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c +0 -3
index 54a3aec..22441dd 100644
@@ -485,15 +485,12 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
 					    enum radio_path rfpath)
 {
 	int i;
-	bool rtstatus = true;
 	u32 *radioa_array_table;
 	u16 radioa_arraylen;
 
 	radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
 	radioa_array_table = RTL8723E_RADIOA_1TARRAY;
 
-	rtstatus = true;
-
 	switch (rfpath) {
 	case RF90_PATH_A:
 		for (i = 0; i < radioa_arraylen; i = i + 2) {
Signature · 1 line
2.6.2
author
#1 lore raw

Hello, Maintainers...
Would you please review above patch if you are available?

Thanks,
Austin Kim

2019년 9월 17일 (화) 오후 3:50, Austin Kim <[email protected]>님이 작성:

Quoted 32 lines

'rtstatus' local variable is not used,
so remove it for clean-up.

---
 drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c +0 -4
index 54a3aec..22441dd 100644
@@ -485,15 +485,12 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
                                            enum radio_path rfpath)
 {
        int i;
-       bool rtstatus = true;
        u32 *radioa_array_table;
        u16 radioa_arraylen;
 
        radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
        radioa_array_table = RTL8723E_RADIOA_1TARRAY;
 
-       rtstatus = true;
-
        switch (rfpath) {
        case RF90_PATH_A:
                for (i = 0; i < radioa_arraylen; i = i + 2) {
--

2.6.2

maintainer
#2 lore raw
Quoted 11 lines

-----Original Message-----
From: Austin Kim [mailto:[email protected]]
Sent: Monday, September 23, 2019 9:35 PM
To: Pkshih; [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

Hello, Maintainers...
Would you please review above patch if you are available?

You can check status of your patch here
https://patchwork.kernel.org/project/linux-wireless/list/?series=174859
If your patch is existing in patchwork, maintainer doesn't forget it.

Another thing is to avoid top posting that makes maintainer hard to read mail.

---
PK

#3 lore raw
In reply to Austin Kim
Quoted 4 lines · Austin Kim

'rtstatus' local variable is not used,
so remove it for clean-up.

Patch applied to wireless-drivers-next.git, thanks.

6e7d59776311 rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

Signature · 3 lines
https://patchwork.kernel.org/patch/11148141/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#5 lore raw

2019년 10월 1일 (화) 오후 6:20, Kalle Valo <[email protected]>님이 작성:

Quoted 9 lines
Quoted 4 lines · Austin Kim

'rtstatus' local variable is not used,
so remove it for clean-up.

Patch applied to wireless-drivers-next.git, thanks.

Thanks for information.