Staging: fbtft: fix memory leak in fbtft_framebuffer_alloc
Subsystems (3)
PATCH 1/1 Staging: fbtft: fix memory leak in fbtft_framebuffer_alloc
In fbtft_framebuffer_alloc the error handling path should take care of releasing frame buffer after it is allocated via framebuffer_alloc, too. Therefore, in two failure cases the goto destination is changed to address this issue.
Fixes c296d5f9957c ("staging: fbtft: core support")
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/staging/fbtft/fbtft-core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-core.c +5 -2
@@ -714,7 +714,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,if (par->gamma.curves && gamma) {if (fbtft_gamma_parse_str (par, par->gamma.curves, gamma,strlen (gamma))) - goto alloc_fail; + goto release_framebuf; }/* Transmit buffer */
@@ -731,7 +731,7 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,if (txbuflen >0 ) { txbuf =devm_kzalloc (par->info->device, txbuflen,GFP_KERNEL );if (!txbuf) - goto alloc_fail; + goto release_framebuf; par->txbuf.buf = txbuf; par->txbuf.len = txbuflen; }
@@ -753,6 +753,9 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,return info; +release_framebuf: +framebuffer_release (info); + alloc_fail:vfree (vmem);
Signature · 1 line
2.17.1
Quoted 7 lines · Navid Emamdoost
In
fbtft_framebuffer_allocthe error handling path should take care of releasing frame buffer after it is allocated viaframebuffer_alloc, too. Therefore, in two failure cases the goto destination is changed to address this issue.Fixes c296d5f9957c ("staging: fbtft: core support")Signed-off-by Navid Emamdoost <[email protected]>
Looks good.
Reviewed-by Dan Carpenter <[email protected]>
regards,
dan carpenter