Skip to contentSkip to conversation

RDMA/vmw_pvrdma: Free SRQ only once

PATCH Applied Adit Ranadive 3 participants 3 messages Sep 18, 2019 – Oct 1, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/vmw_pvrdma: Free SRQ only once

An extra kfree cleanup was missed since these are now deallocated by core.

Fixes 68e326dea1db ("RDMA: Handle SRQ allocations by IB/core")
---
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c | 2 --
 1 file changed, 2 deletions(-)
drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c +0 -2
index 6cac0c88cf39..36cdfbdbd325 100644
@@ -230,8 +230,6 @@ static void pvrdma_free_srq(struct pvrdma_dev *dev, struct pvrdma_srq *srq)
 
 	pvrdma_page_dir_cleanup(dev, &srq->pdir);
 
-	kfree(srq);
-
 	atomic_dec(&dev->num_srqs);
 }
 
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Adit Ranadive

An extra kfree cleanup was missed since these are now deallocated by core.

Fixes 68e326dea1db ("RDMA: Handle SRQ allocations by IB/core")

---
drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c | 2 --

1 file changed, 2 deletions(-)
drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c +0 -0
index 6cac0c88cf39..36cdfbdbd325 100644

drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c static void pvrdma_free_srq(struct pvrdma_dev *dev, struct pvrdma_srq *srq) · line 234

Quoted 7 lines
drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c +0 -2
@@ -230,8 +230,6 @@ static void pvrdma_free_srq(struct pvrdma_dev *dev, struct pvrdma_srq *srq)
 
 	pvrdma_page_dir_cleanup(dev, &srq->pdir);
 
-	kfree(srq);
-
 	atomic_dec(&dev->num_srqs);
 }

Thanks for the fix, looks good to me.

--
vishnu