Skip to contentSkip to conversation

ionic: select CONFIG_NET_DEVLINK

PATCH Applied Arnd Bergmann 3 participants 3 messages Oct 1, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ionic: select CONFIG_NET_DEVLINK

When no other driver selects the devlink library code, ionic produces a link failure:

drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc':
ionic_devlink.c:(.text+0xd): undefined reference to devlink_alloc' drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function ionic_devlink_register':
ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register'

Add the same 'select' statement that the other drivers use here.

Fixes fbfb8031533c ("ionic: Add hardware init and device commands")
---
 drivers/net/ethernet/pensando/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/pensando/Kconfig +1 -0
index bd0583e409df..d25b88f53de4 100644
@@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO
 config IONIC
 	tristate "Pensando Ethernet IONIC Support"
 	depends on 64BIT && PCI
+	select NET_DEVLINK
 	help
 	  This enables the support for the Pensando family of Ethernet
 	  adapters.  More specific information on this driver can be
Signature · 1 line
2.20.0
Acked-by on v1 1/1
#1 lore raw
Quoted 21 lines · Arnd Bergmann

When no other driver selects the devlink library code, ionic produces a link failure:

drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc':
ionic_devlink.c:(.text+0xd): undefined reference to devlink_alloc' drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function ionic_devlink_register':
ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register'

Add the same 'select' statement that the other drivers use here.

Fixes fbfb8031533c ("ionic: Add hardware init and device commands")
---
  drivers/net/ethernet/pensando/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/net/ethernet/pensando/Kconfig +0 -0
index bd0583e409df..d25b88f53de4 100644

drivers/net/ethernet/pensando/Kconfig if NET_VENDOR_PENSANDO · line 26

Quoted 7 lines
drivers/net/ethernet/pensando/Kconfig +1 -0
@@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO
  config IONIC
  	tristate "Pensando Ethernet IONIC Support"
  	depends on 64BIT && PCI
+	select NET_DEVLINK
  	help
  	  This enables the support for the Pensando family of Ethernet
  	  adapters.  More specific information on this driver can be

Thanks!

maintainer Applied
#2 lore raw
In reply to Arnd Bergmann

From: Arnd Bergmann <[email protected]>
Date: Tue, 1 Oct 2019 16:21:40 +0200

Quoted 8 lines

When no other driver selects the devlink library code, ionic produces a link failure:

drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc':
ionic_devlink.c:(.text+0xd): undefined reference to devlink_alloc' drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function ionic_devlink_register':
ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register'

Quoted 4 lines

Add the same 'select' statement that the other drivers use here.

Fixes fbfb8031533c ("ionic: Add hardware init and device commands")

Applied, thanks.