Skip to contentSkip to conversation

net: core: dev: replace state xoff flag comparison by netif_xmit_stopped method

PATCH Applied [email protected] 2 participants 2 messages Oct 1, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: core: dev: replace state xoff flag comparison by netif_xmit_stopped method

From: Julio Faracco <[email protected]>

Function netif_schedule_queue() has a hardcoded comparison between queue state and any xoff flag. This comparison does the same thing as method netif_xmit_stopped(). In terms of code clarity, it is better. See other methods like: generic_xdp_tx() and dev_direct_xmit().

---
Resubmitted as a V2 because V1 was sent during net-next closed window. This commit message and change have the same structure as V1.

---
 net/core/dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/dev.c +1 -1
index bf3ed413abaf..21a9c2987cbb 100644
@@ -2771,7 +2771,7 @@ static struct dev_kfree_skb_cb *get_kfree_skb_cb(const struct sk_buff *skb)
 void netif_schedule_queue(struct netdev_queue *txq)
 {
 	rcu_read_lock();
-	if (!(txq->state & QUEUE_STATE_ANY_XOFF)) {
+	if (!netif_xmit_stopped(txq)) {
 		struct Qdisc *q = rcu_dereference(txq->qdisc);
 
 		__netif_schedule(q);
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw

From: [email protected]
Date: Tue, 1 Oct 2019 11:39:04 -0300

Quoted 8 lines

From: Julio Faracco <[email protected]>

Function netif_schedule_queue() has a hardcoded comparison between queue state and any xoff flag. This comparison does the same thing as method netif_xmit_stopped(). In terms of code clarity, it is better. See other methods like: generic_xdp_tx() and dev_direct_xmit().

Applied to net-next.

Please explicitly put "[PATCH net-next v2]" 'net-next' in your Subject lines in the future.