Skip to contentSkip to conversation

platform/x86: peaq-wmi: switch to using polled mode of input devices

PATCH New Dmitry Torokhov 1 participant 1 message Oct 1, 2019 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: peaq-wmi: switch to using polled mode of input devices

We have added polled mode to the normal input devices with the intent of retiring input_polled_dev. This converts peaq-wmi driver to use the polling mode of standard input devices and removes dependency on INPUT_POLLDEV.

Because the new polling coded does not allow peeking inside the poller structure to get the poll interval, we change the "debounce" process to operate on the time basis, instead of counting events.

We also fix error handling during initialization, as previously we leaked input device structure when we failed to register it.

---
 drivers/platform/x86/Kconfig    |  1 -
 drivers/platform/x86/peaq-wmi.c | 64 +++++++++++++++++++++------------
 2 files changed, 41 insertions(+), 24 deletions(-)
drivers/platform/x86/Kconfig +0 -1
index f0a93f630455..c703c78c59f3 100644
@@ -804,7 +804,6 @@ config PEAQ_WMI
 	tristate "PEAQ 2-in-1 WMI hotkey driver"
 	depends on ACPI_WMI
 	depends on INPUT
-	select INPUT_POLLDEV
 	help
 	 Say Y here if you want to support WMI-based hotkeys on PEAQ 2-in-1s.
 
drivers/platform/x86/peaq-wmi.c +41 -23

109 lines not on this page · raw message

Signature · 5 lines
2.23.0.444.g18eeb5a265-goog


-- 
Dmitry