netconfig: Don't re-install IPv4 address on re-configure

PATCH New Tim Kourt 1 participant 2 messages Oct 1, 2019

Share & tools

Tim Kourt

author

2019-10-01 23:39 UTC #0 lore raw

PATCH 1/2 netconfig: Don't re-install IPv4 address on re-configure

---
 src/netconfig.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

src/netconfig.c +1 -9

index 4e294512..272a058f 100644
@@ -645,17 +645,9 @@ bool netconfig_configure(struct netconfig *netconfig,
 bool netconfig_reconfigure(struct netconfig *netconfig)
 {
 	if (netconfig->rtm_protocol == RTPROT_DHCP) {
-		/*
-		 *
-		 * TODO l_dhcp_client to try to request a
-		 * previously used address.
-		 *
-		 * return;
-		 */
+		/* TODO l_dhcp_client sending a DHCP inform request */
 	}
 
-	netconfig_ipv4_select_and_install(netconfig);
-
 	/* TODO: IPv6 addressing */
 
 	return true;

Signature · 1 line

2.13.6

Tim Kourt

author

2019-10-01 23:39 UTC #1 lore raw

PATCH 2/2 netconfig: Remove roaming logic

Previously, netconfig_ipv4_select_and_install was used to install addresses on initial connection to a network and after we have roamed. Now for the after roaming connection scenario we have netconfig_reconfigure. Remove roaming related code from netconfig_ipv4_select_and_install

---
 src/netconfig.c | 9 ---------
 1 file changed, 9 deletions(-)

src/netconfig.c +0 -9

index 272a058f..70481abf 100644
@@ -597,15 +597,6 @@ static void netconfig_ipv4_select_and_install(struct netconfig *netconfig)
 
 	netconfig->rtm_protocol = RTPROT_DHCP;
 
-	if (netconfig->station_state == STATION_STATE_ROAMING) {
-		/*
-		 * TODO l_dhcp_client to try to request a
-		 * previously used address.
-		 *
-		 * return;
-		 */
-	}
-
 	if (l_dhcp_client_start(netconfig->dhcp_client))
 		return;

Signature · 1 line

2.13.6