Skip to contentSkip to conversation

examples/ipsec-secgw: update pkttest requirements

PATCH In review Marcin Smoczynski 3 participants 4 messages Oct 2, 2019 – Oct 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples/ipsec-secgw: update pkttest requirements

Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has been used because 2.4.2 had a bug which made this version unable to install. Accept future versions of Scapy too.

---
 examples/ipsec-secgw/test/pkttest.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/ipsec-secgw/test/pkttest.py +1 -1
index bcad2156b..5250727f4 100755
@@ -21,7 +21,7 @@
 
 
 PKTTEST_REQ = [
-    "scapy==2.4.3rc1",
+    "scapy>=2.4.3",
 ]
 
 
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 23 lines

-----Original Message-----
From: Smoczynski, MarcinX
Sent: Wednesday, October 2, 2019 9:50 AM
To: [email protected]; Ananyev, Konstantin <[email protected]>; Iremonger, Bernard <[email protected]>
Cc: [email protected]; Smoczynski, MarcinX <[email protected]>
Subject: [PATCH] examples/ipsec-secgw: update pkttest requirements

Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has been used because 2.4.2 had a bug which made this version unable to install. Accept future versions of Scapy too.

---
 examples/ipsec-secgw/test/pkttest.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
examples/ipsec-secgw/test/pkttest.py +0 -0
index bcad2156b..5250727f4 100755

examples/ipsec-secgw/test/pkttest.py

Quoted 9 lines
examples/ipsec-secgw/test/pkttest.py +1 -2
@@ -21,7 +21,7 @@
 
 
 PKTTEST_REQ = [
-    "scapy==2.4.3rc1",
+    "scapy>=2.4.3",
 ]
 
 
--
Quoted 1 line

2.17.1

#3 lore raw

I've used 2.4.3rc1 in the first place because 2.4.2 which was the latest version at that time had a bug which made it unable to install. 2.4.3rc1 worked fine.

2.4.3 has been released recently so we are moving from pre-release RC to stable version. Thanks to ">=" in the requirement we won't need to update it in the future.

Quoted 22 lines

-----Original Message-----
From: Akhil Goyal [mailto:[email protected]]
Sent: Thursday, October 3, 2019 10:30 AM
To: Ananyev, Konstantin <[email protected]>; Smoczynski, MarcinX <[email protected]>; Iremonger, Bernard <[email protected]>
Cc: [email protected]
Subject: RE: [PATCH] examples/ipsec-secgw: update pkttest requirements

Quoted 3 lines
Quoted 3 lines

Update Scapy version requirement from 2.4.3rc1 to 2.4.3, which has been used because 2.4.2 had a bug which made this version unable to

install.

Is this 2.4.2 or 2.4.3??

Quoted 6 lines
Quoted 3 lines

Accept future versions of Scapy too.