input: ixp4xx-beeper: include linux/io.h
Subsystems (2)
PATCH 1/1 input: ixp4xx-beeper: include linux/io.h
asm/io.h may not be included implicitly, causing a rare randconfig build error:
drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration]
__raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE,
--- drivers/input/misc/ixp4xx-beeper.c | 1 + 1 file changed, 1 insertion(+)
drivers/input/misc/ixp4xx-beeper.c +1 -0
@@ -17,6 +17,7 @@#include <linux/platform_device.h> #include <linux/interrupt.h> #include <linux/gpio.h> +#include <linux/io.h> MODULE_AUTHOR ("Alessandro Zummo <[email protected]>" );MODULE_DESCRIPTION ("ixp4xx beeper driver" );
Signature · 1 line
2.20.0
Quoted 7 lines · Arnd Bergmann
asm/io.hmay not be included implicitly, causing a rare randconfig build error:
drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration]__raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE,Signed-off-by Arnd Bergmann <[email protected]>
I am thinking a bit about the future of this driver. Isn't it more reasonable to just make a hrtimer-driven PWM and use the existing PWM userspace ABI and timer framework in Linux for this? Not that there is a generic timer-driven PWM but ... that is essentially what this driver is.
Yours,
Linus Walleij
Quoted 8 lines · Arnd Bergmann
asm/io.hmay not be included implicitly, causing a rare randconfig build error:
drivers/input/misc/ixp4xx-beeper.c:48:3: error: implicit declaration of function '__raw_writel' [-Werror,-Wimplicit-function-declaration]__raw_writel((count & ~IXP4XX_OST_RELOAD_MASK) | IXP4XX_OST_ENABLE,Signed-off-by Arnd Bergmann <[email protected]>
Please ignore, this does not apply to mainline and is probably only needed on top of another patch that I will submit in the future.
Arnd