Skip to contentSkip to conversation

drivers: musb: removed unused status variable

PATCH In review [email protected] 2 participants 2 messages Oct 2, 2019 – Oct 4, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: musb: removed unused status variable

From: Aliasgar Surti <[email protected]>

Status variable is initialized and returned without updating it's value. Removed status variable and returned value directly.

---
 drivers/usb/musb/musb_gadget.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/musb/musb_gadget.c +1 -2
index ffe462a657b1..2cb31fc0cd60 100644
@@ -1085,7 +1085,6 @@ static int musb_gadget_disable(struct usb_ep *ep)
 	u8		epnum;
 	struct musb_ep	*musb_ep;
 	void __iomem	*epio;
-	int		status = 0;
 
 	musb_ep = to_musb_ep(ep);
 	musb = musb_ep->musb;
@@ -1118,7 +1117,7 @@ static int musb_gadget_disable(struct usb_ep *ep)
 
 	musb_dbg(musb, "%s", musb_ep->end_point.name);
 
-	return status;
+	return 0;
 }
 
 /*
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 34 lines · On Wed, Oct 02, 2019 at 11:09:13PM +0530, [email protected] wrote:

From: Aliasgar Surti <[email protected]>

Status variable is initialized and returned without updating it's value. Removed status variable and returned value directly.

---
 drivers/usb/musb/musb_gadget.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/musb/musb_gadget.c +1 -2
index ffe462a657b1..2cb31fc0cd60 100644
@@ -1085,7 +1085,6 @@ static int musb_gadget_disable(struct usb_ep *ep)
 	u8		epnum;
 	struct musb_ep	*musb_ep;
 	void __iomem	*epio;
-	int		status = 0;
 
 	musb_ep = to_musb_ep(ep);
 	musb = musb_ep->musb;
@@ -1118,7 +1117,7 @@ static int musb_gadget_disable(struct usb_ep *ep)
 
 	musb_dbg(musb, "%s", musb_ep->end_point.name);
 
-	return status;
+	return 0;
 }
 
 /*
Signature · 1 line
2.17.1

Someone else sent this same patch 2 hours before you did, sorry :(