Skip to contentSkip to conversation

package/znc: fix build with cmake < 3.10

PATCH New Fabrice Fontaine 3 participants 3 messages Oct 2, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/znc: fix build with cmake < 3.10

Fixes:
- http://autobuild.buildroot.org/results/991dd1d74f00f027a905d2ec3ad1a1b2b723f978

---
 package/znc/znc.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/znc/znc.mk +5 -0
index 78e1410b68..54dc63f4ea 100644
@@ -11,6 +11,11 @@ ZNC_LICENSE_FILES = LICENSE
 ZNC_DEPENDENCIES = host-pkgconf
 ZNC_CONF_OPTS = -DWANT_CYRUS=OFF -DWANT_I18N=OFF -DWANT_PERL=OFF
 
+# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
+# disable a try_run() call in the FindThreads tests, which caused a
+# build failure when cross-compiling.
+ZNC_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
+
 ifeq ($(BR2_PACKAGE_ICU),y)
 ZNC_DEPENDENCIES += icu
 ZNC_CONF_OPTS += -DWANT_ICU=ON
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/znc: fix build with cmake < 3.10

Am Wed, 02 Oct 2019 19:51:20 +0200 schrieb Fabrice Fontaine:

Quoted 1 line

+# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to

Hi,

good catch, the old cmake version was the reason why I could not reproduce the error here (cmake version 3.13.4).

Regards, Bernd

#2 lore raw

PATCH 1/1 package/znc: fix build with cmake < 3.10

In reply to Fabrice Fontaine
Quoted 7 lines · On Wed, 2 Oct 2019 19:51:20 +0200 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/991dd1d74f00f027a905d2ec3ad1a1b2b723f978

---
 package/znc/znc.mk | 5 +++++
 1 file changed, 5 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com