Skip to contentSkip to conversation

NVMe: do PCI enumerate before nvme scan

PATCH Superseded Patrick Wildt 3 participants 5 messages Oct 2, 2019 – Nov 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NVMe: do PCI enumerate before nvme scan

Make sure that the PCI busses are enumerated before trying to find a NVMe device.

include/config_distro_bootcmd.h +1 -0
index 3570a32dff..563f1bf5fa 100644
@@ -185,6 +185,7 @@
 	"nvme_init=" \
 		"if ${nvme_need_init}; then " \
 			"setenv nvme_need_init false; " \
+			BOOTENV_RUN_PCI_ENUM \
 			"nvme scan; " \
 		"fi\0" \
 	\
#1 lore raw

PATCH 1/1 NVMe: do PCI enumerate before nvme scan

Hi Patrick,

Quoted 11 lines · Patrick Wildt

Make sure that the PCI busses are enumerated before trying to find a NVMe device.

include/config_distro_bootcmd.h +0 -0
index 3570a32dff..563f1bf5fa 100644

include/config_distro_bootcmd.h line 188

Quoted 4 lines
include/config_distro_bootcmd.h +1 -0
@@ -185,6 +185,7 @@
        "nvme_init=" \
                "if ${nvme_need_init}; then " \
                        "setenv nvme_need_init false; " \
+                       BOOTENV_RUN_PCI_ENUM \

I think we need insert this to "nvme_boot=", just like "virtio_boot=" does.

include/config_distro_bootcmd.h line 191

Quoted 3 lines
include/config_distro_bootcmd.h +0 -0
                        "nvme scan; " \
                "fi\0" \
        \

Regards,
Bin

#2 lore raw

PATCH v2 1/1 NVMe: do PCI enumerate before nvme scan

Make sure that the PCI busses are enumerated before trying to find a NVMe device.

---
Changes for v2:
- moved from nvme_init to nvme_boot

include/config_distro_bootcmd.h +1 -0
index 3570a32dff..fc0935fa21 100644
@@ -189,6 +189,7 @@
 		"fi\0" \
 	\
 	"nvme_boot=" \
+		BOOTENV_RUN_PCI_ENUM \
 		BOOTENV_RUN_NVME_INIT \
 		BOOTENV_SHARED_BLKDEV_BODY(nvme)
 #define BOOTENV_DEV_NVME	BOOTENV_DEV_BLKDEV
#4 lore raw

PATCH v2 1/1 NVMe: do PCI enumerate before nvme scan

In reply to Patrick Wildt
Quoted 5 lines · Patrick Wildt

Make sure that the PCI busses are enumerated before trying to find a NVMe device.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191101/be48873a/attachment.sig>