Skip to contentSkip to conversation

package/libv4l: bump version to 1.18.0

PATCH New Peter Seiderer 2 participants 6 messages Oct 2, 2019 – Oct 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libv4l: bump version to 1.18.0

- remove 0001-fixup-lfs-mismatch-in-preload-libraries.patch (Upstream applied [1])
- remove 0002-keytable-fix-EVIOCSCLOCKID-related-compile-failure.patch (Upstream applied [2])
- remove 0003-Build-sdlcam-only-if-jpeg-is-enabled.patch (Upstream applied [3])
- remove 0004-v4l2-compliance-needs-fork.patch
(Upstream applied [4])

[1] https://git.linuxtv.org/v4l-utils.git/commit/?id=9f0354c3320f3cc62983f726bfed66e1d0c21f83
[2] https://git.linuxtv.org/v4l-utils.git/commit/?id=a3367e92f4b06667a36fb9485f22f7df52891a2f
[3] https://git.linuxtv.org/v4l-utils.git/commit/?id=692c2f0f35dd663e84d363867f2841d387726154
[4] https://git.linuxtv.org/v4l-utils.git/commit/?id=577ab225929c4e8dce7d2b911eeed38469a559bb

---
 ...up-lfs-mismatch-in-preload-libraries.patch | 44 -----------
 ...VIOCSCLOCKID-related-compile-failure.patch | 35 ---------
 ...Build-sdlcam-only-if-jpeg-is-enabled.patch | 31 --------
 .../0004-v4l2-compliance-needs-fork.patch     | 76 -------------------
 package/libv4l/libv4l.hash                    |  5 +-
 package/libv4l/libv4l.mk                      |  2 +-
 6 files changed, 4 insertions(+), 189 deletions(-)
 delete mode 100644 package/libv4l/0001-fixup-lfs-mismatch-in-preload-libraries.patch
 delete mode 100644 package/libv4l/0002-keytable-fix-EVIOCSCLOCKID-related-compile-failure.patch
 delete mode 100644 package/libv4l/0003-Build-sdlcam-only-if-jpeg-is-enabled.patch
 delete mode 100644 package/libv4l/0004-v4l2-compliance-needs-fork.patch
package/libv4l/0001-fixup-lfs-mismatch-in-preload-libraries.patch deleted +0 -44
deleted file mode 100644
index f23eb7a350..0000000000
@@ -1,44 +0,0 @@
-From e5952b043a71fe83fbc392e498e8f77774fca0d8 Mon Sep 17 00:00:00 2001
-From: Peter Korsgaard <[email protected]>
-Date: Sat, 28 Jun 2014 09:32:53 -0300
-Subject: [PATCH] fixup lfs mismatch in preload libraries
-
-Ensure that the lfs variants are not transparently used instead of the !lfs
-ones so both can be wrapped, independently of any custom CFLAGS/CPPFLAGS.
-
-Signed-off-by: Peter Korsgaard <[email protected]>
----
- lib/libv4l1/v4l1compat.c  | 3 +++
- lib/libv4l2/v4l2convert.c | 3 +++
- 2 files changed, 6 insertions(+)
-
-diff --git a/lib/libv4l1/v4l1compat.c b/lib/libv4l1/v4l1compat.c
-index e328288..70eb74f 100644
---- a/lib/libv4l1/v4l1compat.c
-+++ b/lib/libv4l1/v4l1compat.c
-@@ -19,6 +19,9 @@
- # Foundation, Inc., 51 Franklin Street, Suite 500, Boston, MA  02110-1335  USA
-  */
-
-+/* ensure we see *64 variants and they aren't transparently used */
-+#undef _LARGEFILE_SOURCE
-+#undef _FILE_OFFSET_BITS
- #define _LARGEFILE64_SOURCE 1
-
- #include <config.h>
-diff --git a/lib/libv4l2/v4l2convert.c b/lib/libv4l2/v4l2convert.c
-index 9b46ab8..bc41056 100644
---- a/lib/libv4l2/v4l2convert.c
-+++ b/lib/libv4l2/v4l2convert.c
-@@ -23,6 +23,9 @@
- /* prevent GCC 4.7 inlining error */
- #undef _FORTIFY_SOURCE
-
-+/* ensure we see *64 variants and they aren't transparently used */
-+#undef _LARGEFILE_SOURCE
-+#undef _FILE_OFFSET_BITS
- #define _LARGEFILE64_SOURCE 1
-
- #include <config.h>
---
-1.9.1
package/libv4l/0002-keytable-fix-EVIOCSCLOCKID-related-compile-failure.patch deleted +0 -35
deleted file mode 100644
index 656008b708..0000000000
@@ -1,35 +0,0 @@
-From 663b7be9d27c979c914011a3ce707e227987bc59 Mon Sep 17 00:00:00 2001
-From: Peter Seiderer <[email protected]>
-Date: Sat, 3 Feb 2018 22:47:18 +0100
-Subject: [PATCH] keytable: fix EVIOCSCLOCKID related compile failure
-
-Fixes:
-
-  keytable.c: In function 'test_event':
-  keytable.c:1351:12: error: 'EVIOCSCLOCKID' undeclared (first use in this function)
-    ioctl(fd, EVIOCSCLOCKID, &mode);
-              ^~~~~~~~~~~~~
-
-Signed-off-by: Peter Seiderer <[email protected]>
----
- utils/keytable/keytable.c | 4 ++++
- 1 file changed, 4 insertions(+)
-
-diff --git a/utils/keytable/keytable.c b/utils/keytable/keytable.c
-index 34a1522e..925eab00 100644
---- a/utils/keytable/keytable.c
-+++ b/utils/keytable/keytable.c
-@@ -55,6 +55,10 @@ struct input_keymap_entry_v2 {
- 	u_int8_t  scancode[32];
- };
-
-+#ifndef EVIOCSCLOCKID
-+#define EVIOCSCLOCKID		_IOW('E', 0xa0, int)
-+#endif
-+
- #ifndef EVIOCGKEYCODE_V2
- #define EVIOCGKEYCODE_V2	_IOR('E', 0x04, struct input_keymap_entry_v2)
- #define EVIOCSKEYCODE_V2	_IOW('E', 0x04, struct input_keymap_entry_v2)
---
-2.16.1
-
package/libv4l/0003-Build-sdlcam-only-if-jpeg-is-enabled.patch deleted +0 -31
deleted file mode 100644
index 4c4365f907..0000000000
@@ -1,31 +0,0 @@
-From 5c407e130f8d0416f91f5a12bcdc2709f00dda65 Mon Sep 17 00:00:00 2001
-From: Fabrice Fontaine <[email protected]>
-Date: Fri, 29 Jun 2018 21:15:10 +0200
-Subject: [PATCH] Build sdlcam only if jpeg is enabled
-
-Fixes:
- - http://autobuild.buildroot.net/results/1eded8b44cc369550566c6ce0b3c042f1aec8d44
-
-Signed-off-by: Fabrice Fontaine <[email protected]>
----
- contrib/test/Makefile.am | 2 ++
- 1 file changed, 2 insertions(+)
-
-diff --git a/contrib/test/Makefile.am b/contrib/test/Makefile.am
-index 0188fe21..c7c38e7a 100644
---- a/contrib/test/Makefile.am
-+++ b/contrib/test/Makefile.am
-@@ -17,8 +17,10 @@ noinst_PROGRAMS += v4l2gl
- endif
-
- if HAVE_SDL
-+if HAVE_JPEG
- noinst_PROGRAMS += sdlcam
- endif
-+endif
-
- driver_test_SOURCES = driver-test.c
- driver_test_LDADD = ../../utils/libv4l2util/libv4l2util.la
---
-2.14.1
-
package/libv4l/0004-v4l2-compliance-needs-fork.patch deleted +0 -76

76 lines not on this page · raw message

package/libv4l/libv4l.hash +3 -2
index 78351c97e5..5b29d7d65a 100644
@@ -1,7 +1,8 @@
 # Locally calculated after checking signature
-# https://linuxtv.org/downloads/v4l-utils/v4l-utils-1.16.6.tar.bz2.asc
+# https://linuxtv.org/downloads/v4l-utils/v4l-utils-1.18.0.tar.bz2.asc
 # with key 05D0169C26E41593418129DF199A64FADFB500FF
-sha256 f9dac1878e3d5636eab7f56bb209fdfc66b94ee8a2aae54dcb4282fe63a678ae  v4l-utils-1.16.6.tar.bz2
+sha256 6cb60d822eeed20486a03cc23e0fc65956fbc1e85e0c1a7477f68bbd9802880d  v4l-utils-1.18.0.tar.bz2
+
 # Locally calculated
 sha256 391e4da1c54a422a78d83be7bf84b2dfb8bacdd8ad256fa4374e128655584a8a  COPYING
 sha256 5a7f623a50e384aaf6d2ced068339ddf93d0a50d3a0ecbe86f125b07804ecc78  COPYING.libv4l
package/libv4l/libv4l.mk +1 -1
index b31d1a4c41..e7e400a7ea 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBV4L_VERSION = 1.16.6
+LIBV4L_VERSION = 1.18.0
 LIBV4L_SOURCE = v4l-utils-$(LIBV4L_VERSION).tar.bz2
 LIBV4L_SITE = https://linuxtv.org/downloads/v4l-utils
 LIBV4L_INSTALL_STAGING = YES

--
2.23.0

#1 lore raw

PATCH 1/1 package/libv4l: bump version to 1.18.0

Quoted 8 lines · On Wed, 2 Oct 2019 21:43:16 +0200 Peter Seiderer <[email protected]> wrote:

- remove 0001-fixup-lfs-mismatch-in-preload-libraries.patch (Upstream applied [1])
- remove 0002-keytable-fix-EVIOCSCLOCKID-related-compile-failure.patch (Upstream applied [2])
- remove 0003-Build-sdlcam-only-if-jpeg-is-enabled.patch (Upstream applied [3])
- remove 0004-v4l2-compliance-needs-fork.patch
(Upstream applied [4])

Since there are no patch left, do we still need AUTORECONF = YES and the dependency on host-gettext ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/libv4l: bump version to 1.18.0

Hello Thomas,

Quoted 12 lines · Thomas Petazzoni
Quoted 8 lines · On Wed, 2 Oct 2019 21:43:16 +0200 Peter Seiderer <[email protected]> wrote:

- remove 0001-fixup-lfs-mismatch-in-preload-libraries.patch (Upstream applied [1])
- remove 0002-keytable-fix-EVIOCSCLOCKID-related-compile-failure.patch (Upstream applied [2])
- remove 0003-Build-sdlcam-only-if-jpeg-is-enabled.patch (Upstream applied [3])
- remove 0004-v4l2-compliance-needs-fork.patch
(Upstream applied [4])

Quoted 2 lines

Since there are no patch left, do we still need AUTORECONF = YES and the dependency on host-gettext ?

Good catch (autoreconf/host-gettext) was added with the 0003-Build-sdlcam-only-if-jpeg-is-enabled.patch patch ([5]), but without autoreconf I get the following build error (using the config from [6]):

.../host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: qv4l2-qv4l2.o: undefined reference to symbol '__atomic_fetch_add_4@@LIBATOMIC_1.0' .../host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: /home/seiderer/Work/Buildroot/build_sparc_qt5multimedia_001/host/sparc-buildroot-linux-uclibc/sysroot/lib/libatomic.so.1: error adding symbols: DSO missing from command line

Regards,
Peter

[5] https://git.buildroot.net/buildroot/commit/?id=d92d3ddeb1374325a7d92c885dc827317a5c90f1
[6] http://autobuild.buildroot.org/results/fc7bcc6b3ccf1e075dce43296b36e7e1cac417db

Quoted 2 lines

Thomas

#3 lore raw

PATCH 1/1 package/libv4l: bump version to 1.18.0

Quoted 12 lines · On Wed, 2 Oct 2019 22:25:16 +0200 Peter Seiderer <[email protected]> wrote:
Quoted 12 lines
Quoted 8 lines · On Wed, 2 Oct 2019 21:43:16 +0200 Peter Seiderer <[email protected]> wrote:

- remove 0001-fixup-lfs-mismatch-in-preload-libraries.patch (Upstream applied [1])
- remove 0002-keytable-fix-EVIOCSCLOCKID-related-compile-failure.patch (Upstream applied [2])
- remove 0003-Build-sdlcam-only-if-jpeg-is-enabled.patch (Upstream applied [3])
- remove 0004-v4l2-compliance-needs-fork.patch
(Upstream applied [4])

Quoted 8 lines
Quoted 2 lines

Since there are no patch left, do we still need AUTORECONF = YES and the dependency on host-gettext ?

Good catch (autoreconf/host-gettext) was added with the 0003-Build-sdlcam-only-if-jpeg-is-enabled.patch patch ([5]), but without autoreconf I get the following build error (using the config from [6]):

.../host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: qv4l2-qv4l2.o: undefined reference to symbol '__atomic_fetch_add_4@@LIBATOMIC_1.0' .../host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: /home/seiderer/Work/Buildroot/build_sparc_qt5multimedia_001/host/sparc-buildroot-linux-uclibc/sysroot/lib/libatomic.so.1: error adding symbols: DSO missing from command line

How come this is related to autoreconf ? On SPARC, you need to link with -latomic, so this build failure is not too surprising. What is surprising is that an autoreconf fixes it. Do you think you could investigate this ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/libv4l: bump version to 1.18.0

Hello Thomas,

Quoted 21 lines · Thomas Petazzoni
Quoted 18 lines · On Wed, 2 Oct 2019 22:25:16 +0200 Peter Seiderer <[email protected]> wrote:
Quoted 12 lines
Quoted 8 lines · On Wed, 2 Oct 2019 21:43:16 +0200 Peter Seiderer <[email protected]> wrote:

- remove 0001-fixup-lfs-mismatch-in-preload-libraries.patch (Upstream applied [1])
- remove 0002-keytable-fix-EVIOCSCLOCKID-related-compile-failure.patch (Upstream applied [2])
- remove 0003-Build-sdlcam-only-if-jpeg-is-enabled.patch (Upstream applied [3])
- remove 0004-v4l2-compliance-needs-fork.patch
(Upstream applied [4])

Quoted 2 lines

Since there are no patch left, do we still need AUTORECONF = YES and the dependency on host-gettext ?

Good catch (autoreconf/host-gettext) was added with the 0003-Build-sdlcam-only-if-jpeg-is-enabled.patch patch ([5]), but without autoreconf I get the following build error (using the config from [6]):

Quoted 7 lines
Quoted 2 lines

.../host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: qv4l2-qv4l2.o: undefined reference to symbol '__atomic_fetch_add_4@@LIBATOMIC_1.0' .../host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: /home/seiderer/Work/Buildroot/build_sparc_qt5multimedia_001/host/sparc-buildroot-linux-uclibc/sysroot/lib/libatomic.so.1: error adding symbols: DSO missing from command line

How come this is related to autoreconf ? On SPARC, you need to link with -latomic, so this build failure is not too surprising. What is surprising is that an autoreconf fixes it. Do you think you could investigate this ?

Can (try) to investigate, the difference seems to be how the qt compile/link flags are generated with/without autoreconf, the bug fixed with 'package/qt5base: fix libtool la file dependency_libs entries' ([6]) was only triggered on libv4l/utils/qv4l with autoreconf enabled too...

Regards,
Peter

[6] https://git.buildroot.net/buildroot/commit/?id=4ad73bf5e6326f7a414ecc94dbac0c79f5d33b31

Quoted 2 lines

Thomas

#5 lore raw

PATCH 1/1 package/libv4l: bump version to 1.18.0

Hello Thomas,

Quoted 33 lines · Peter Seiderer

Hello Thomas,

Quoted 21 lines · Thomas Petazzoni
Quoted 18 lines · On Wed, 2 Oct 2019 22:25:16 +0200 Peter Seiderer <[email protected]> wrote:
Quoted 12 lines
Quoted 8 lines · On Wed, 2 Oct 2019 21:43:16 +0200 Peter Seiderer <[email protected]> wrote:

- remove 0001-fixup-lfs-mismatch-in-preload-libraries.patch (Upstream applied [1])
- remove 0002-keytable-fix-EVIOCSCLOCKID-related-compile-failure.patch (Upstream applied [2])
- remove 0003-Build-sdlcam-only-if-jpeg-is-enabled.patch (Upstream applied [3])
- remove 0004-v4l2-compliance-needs-fork.patch
(Upstream applied [4])

Quoted 2 lines

Since there are no patch left, do we still need AUTORECONF = YES and the dependency on host-gettext ?

Good catch (autoreconf/host-gettext) was added with the 0003-Build-sdlcam-only-if-jpeg-is-enabled.patch patch ([5]), but without autoreconf I get the following build error (using the config from [6]):

Quoted 7 lines
Quoted 2 lines

.../host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: qv4l2-qv4l2.o: undefined reference to symbol '__atomic_fetch_add_4@@LIBATOMIC_1.0' .../host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: /home/seiderer/Work/Buildroot/build_sparc_qt5multimedia_001/host/sparc-buildroot-linux-uclibc/sysroot/lib/libatomic.so.1: error adding symbols: DSO missing from command line

How come this is related to autoreconf ? On SPARC, you need to link with -latomic, so this build failure is not too surprising. What is surprising is that an autoreconf fixes it. Do you think you could investigate this ?

Quoted 4 lines

Can (try) to investigate, the difference seems to be how the qt compile/link flags are generated with/without autoreconf, the bug fixed with 'package/qt5base: fix libtool la file dependency_libs entries' ([6]) was only triggered on libv4l/utils/qv4l with autoreconf enabled too...

Both versions (autoreconf-enabled/autoreconf-disabled) use the same libtool command line to link libv4l-1.18.0/utils/qv4l2/qv4l2 but the resulting command line in the the autoreconf-disabled case is missing the -latomic part.

	$ diff -u build/libv4l-1.18.0-autoreconf-disabled/libtool build/libv4l-1.18.0-autoreconf-enabled/libtool
[...]
@@ -411,7 +412,7 @@
 inherit_rpath=no

# Whether libtool must link a program against all its dependency libraries.
-link_all_deplibs=no
+link_all_deplibs=unknown

# Set to "yes" if exported symbols are required.
always_export_symbols=no
@@ -542,7 +543,7 @@

PROGRAM=libtool
PACKAGE=libtool
-VERSION="2.4.6 Debian-2.4.6-11"
+VERSION=2.4.6
package_revision=2.4.6

[...]

Searching for 'link_all_deplibs no unknown' gives the following result:

	https://lists.gnu.org/archive/html/libtool/2007-09/msg00012.html

Stating:

FYI, in GNU Libtool currently no system get link_all_deplibs set to no. (Some distributions change this in their version; Debian for example.) This is because link_all_deplibs=no exposes some bugs in libtool, that are rather nontrivial to fix.

Regards,
Peter

Quoted 13 lines

Regards,
Peter

[6] https://git.buildroot.net/buildroot/commit/?id=4ad73bf5e6326f7a414ecc94dbac0c79f5d33b31

Quoted 2 lines

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot