Skip to contentSkip to conversation

Osstest.pm: Fix main_revision_job_cond after 0964bab7a9ea

PATCH New Ian Jackson 1 participant 1 message Oct 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Osstest.pm: Fix main_revision_job_cond after 0964bab7a9ea

In
other_revision_job_suffix: Take and pass referring runvar name
we updated main_revision_job_cond to pass a dummy 'x' for the new parameter. But the parameter is a sql expression, not a value, and so an extra pair of quotes are needed.

This error broke sg-check-tested and this fix fixes it.

---
 Osstest.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Osstest.pm +1 -1
index c14531e3..d6c1b709 100644
@@ -388,7 +388,7 @@ END
 
 sub main_revision_job_cond ($) {
     my ($jobfield) = @_;
-    return "(${\ other_revision_job_suffix($jobfield,'x','x') } = '')";
+    return "(${\ other_revision_job_suffix($jobfield,\"'x'\",'x') } = '')";
 }
 
 sub get_harness_rev () {
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel