x86/vvmx: Fix the use of RDTSCP when it is intercepted at L0
PATCH 1/1 x86/vvmx: Fix the use of RDTSCP when it is intercepted at L0
Linux has started using RDTSCP as of v5.1. This has highlighted a bug in Xen, where virtual vmexit simply gives up.
(XEN) d1v1 Unhandled nested vmexit: reason 51
(XEN) domain_crash called from vvmx.c:2671
(XEN) Domain 1 (vcpu#1) crashed on cpu#2:
Handle RDTSCP in the virtual vmexit hander in the same was as RDTSC intercepts.
---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Jun Nakajima <[email protected]>
CC: Kevin Tian <[email protected]>
CC: Juergen Gross <[email protected]>
This probably wants backporting to all stable trees, even though nested virt isn't supported, and therefore ought to qualify for 4.13 at this point.
--- xen/arch/x86/hvm/vmx/vvmx.c | 3 +++ 1 file changed, 3 insertions(+)
xen/arch/x86/hvm/vmx/vvmx.c +3 -0
@@ -2491,6 +2491,7 @@ int nvmx_n2_vmexit_handler(struct cpu_user_regs *regs, nvcpu->nv_vmexit_pending =1 ;break ;case EXIT_REASON_RDTSC : +case EXIT_REASON_RDTSCP : ctrl =__n2_exec_control (v);if ( ctrl &CPU_BASED_RDTSC_EXITING ) nvcpu->nv_vmexit_pending =1 ;
@@ -2501,6 +2502,8 @@ int nvmx_n2_vmexit_handler(struct cpu_user_regs *regs,* avoiding changing guest_tsc and messing up timekeeping in L1 */ msr_split (regs,hvm_get_guest_tsc (v) +get_vvmcs (v,TSC_OFFSET )); +if ( exit_reason ==EXIT_REASON_RDTSCP ) + regs->rcx = v->arch.msrs->tsc_aux;update_guest_eip ();return 1 ;
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 7 lines · Andrew Cooper
Linux has started using RDTSCP as of v5.1. This has highlighted a bug in Xen, where virtual vmexit simply gives up.
(XEN) d1v1 Unhandled nested vmexit: reason 51
(XEN)domain_crashcalled from vvmx.c:2671
(XEN) Domain 1 (vcpu#1) crashed on cpu#2:
Quoted 6 lines
Handle RDTSCP in the virtual vmexit hander in the same was as RDTSC intercepts.
Reported-by Sarah Newman <[email protected]>Signed-off-by Andrew Cooper <[email protected]>Tested-by Chris Brannon <[email protected]>
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 7 lines · Andrew Cooper
Linux has started using RDTSCP as of v5.1. This has highlighted a bug in Xen, where virtual vmexit simply gives up.
(XEN) d1v1 Unhandled nested vmexit: reason 51
(XEN)domain_crashcalled from vvmx.c:2671
(XEN) Domain 1 (vcpu#1) crashed on cpu#2:
Quoted 6 lines
Handle RDTSCP in the virtual vmexit hander in the same was as RDTSC intercepts.
Reported-by Sarah Newman <[email protected]>Signed-off-by Andrew Cooper <[email protected]>Tested-by Chris Brannon <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel