Skip to contentSkip to conversation

package/python-matplotlib: add kiwisolver dependency

PATCH Superseded Esben Haabendal 2 participants 4 messages Sep 30, 2019 – Oct 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 package/python-matplotlib: add kiwisolver dependency

This is needed by matplotlib.pyplot, and is also documented at
https://matplotlib.org/users/installing.html#building-on-linux

---
 package/python-matplotlib/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/python-matplotlib/Config.in +1 -0
index 07160affd043..e6ed8cda2f28 100644
@@ -9,6 +9,7 @@ config BR2_PACKAGE_PYTHON_MATPLOTLIB
 	select BR2_PACKAGE_PYTHON_CYCLER
 	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
 	select BR2_PACKAGE_PYTHON_DATEUTIL # runtime
+	select BR2_PACKAGE_PYTHON_KIWISOLVER # runtime
 	select BR2_PACKAGE_PYTHON_NUMPY # runtime
 	select BR2_PACKAGE_PYTHON_PYPARSING # runtime
 	select BR2_PACKAGE_PYTHON3_ZLIB # runtime
Signature · 1 line
2.23.0
#1 lore raw

PATCH v4 1/1 package/python-matplotlib: add kiwisolver dependency

Hello Esben,

Quoted 4 lines · On Mon, 30 Sep 2019 10:47:41 +0200 Esben Haabendal <[email protected]> wrote:

This is needed by matplotlib.pyplot, and is also documented at
https://matplotlib.org/users/installing.html#building-on-linux

This is exactly the same version as v2, which was exactly the same as v3. Why do you resend the same patch multiple times ?

This version is in fact even less good than the v3, because you lost the Reviewed-by from Yegor.

It seems like you keep sending new versions with no changes, just because your patches haven't been applied. Your patches have been applied because we have a backlog of ~350 patches. We can't lose any of them, because they are recorded by patchwork.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v4 1/1 package/python-matplotlib: add kiwisolver dependency

Quoted 13 lines · Thomas Petazzoni

Hello Esben,

Quoted 4 lines · On Mon, 30 Sep 2019 10:47:41 +0200 Esben Haabendal <[email protected]> wrote:

This is needed by matplotlib.pyplot, and is also documented at
https://matplotlib.org/users/installing.html#building-on-linux

This is exactly the same version as v2, which was exactly the same as v3. Why do you resend the same patch multiple times ?

Quoted 7 lines

This version is in fact even less good than the v3, because you lost the Reviewed-by from Yegor.

It seems like you keep sending new versions with no changes, just because your patches haven't been applied. Your patches have been applied because we have a backlog of ~350 patches. We can't lose any of them, because they are recorded by patchwork.

Sorry about that. For some reason I had assumed that buildroot used the same lossy approach as is usual on kernel lists. I will do my best to not make the same mistake in the future :)

/Esben

#3 lore raw

PATCH v4 1/1 package/python-matplotlib: add kiwisolver dependency

Hello Esben,

Quoted 3 lines · On Thu, 03 Oct 2019 08:31:55 +0200 Esben Haabendal <[email protected]> wrote:

Sorry about that. For some reason I had assumed that buildroot used the same lossy approach as is usual on kernel lists. I will do my best to not make the same mistake in the future :)

Mistakes always happen, and even with patchwork it is possible for one of the maintainer to make a mistake a mark a patch as Accepted even if it was not applied.

However, you can always check at
http://patchwork.ozlabs.org/project/buildroot/list/ if your patch is still there. As long as it's there, it's not forgotten.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com