ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
Subsystems (2)
Tony Lindgren
maintainerPATCH 1/1 ARM: omap2plus_defconfig: Fix selected panels after generic panel changes
The old omapdrm panels got removed for v5.4 in favor of generic panels, and the Kconfig options changed. Let's update omap2plus_defconfig accordingly so the same panels are still enabled.
--- arch/arm/configs/omap2plus_defconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm/configs/omap2plus_defconfig +6 -6
@@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m CONFIG_DRM_OMAP_PANEL_DPI=m CONFIG_DRM_OMAP_PANEL_DSI_CM=m -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m CONFIG_DRM_TILCDC=m CONFIG_DRM_PANEL_SIMPLE=m +CONFIG_DRM_PANEL_LG_LB035Q02=m +CONFIG_DRM_PANEL_NEC_NL8048HL11=m +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m +CONFIG_DRM_PANEL_SONY_ACX565AKM=m +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m CONFIG_FB=y CONFIG_FIRMWARE_EDID=y CONFIG_FB_MODE_HELPERS=y
Signature · 1 line
2.23.0
Quoted 26 lines · Tony Lindgren
The old omapdrm panels got removed for v5.4 in favor of generic panels, and the
Kconfigoptions changed. Let's updateomap2plus_defconfigaccordingly so the same panels are still enabled.Cc Jyri Sarha <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Tomi Valkeinen <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- arch/arm/configs/omap2plus_defconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/configs/omap2plus_defconfig +0
-6@@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m CONFIG_DRM_OMAP_PANEL_DPI=m CONFIG_DRM_OMAP_PANEL_DSI_CM=m -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m CONFIG_DRM_TILCDC=m
arch/arm/configs/omap2plus_defconfig CONFIG_DRM_OMAP_CONNECTOR_HDMI=m · line 369
Quoted 10 lines
arch/arm/configs/omap2plus_defconfig +6
-0CONFIG_DRM_PANEL_SIMPLE=m +CONFIG_DRM_PANEL_LG_LB035Q02=m +CONFIG_DRM_PANEL_NEC_NL8048HL11=m +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m +CONFIG_DRM_PANEL_SONY_ACX565AKM=m +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m CONFIG_FB=y CONFIG_FIRMWARE_EDID=y CONFIG_FB_MODE_HELPERS=y
Sorry, I didn't remember to update these. Some additions:
These can be dropped, they no longer exist:
CONFIG_DRM_OMAP_ENCODER_TFP410=mCONFIG_DRM_OMAP_CONNECTOR_DVI=mCONFIG_DRM_OMAP_PANEL_DPI=m
This can be added to get the DVI output working on many of the boards:
CONFIG_DRM_TI_TFP410=m
Tomi
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Tony Lindgren
maintainerQuoted 42 lines · Tomi Valkeinen
Quoted 26 lines · Tony Lindgren
The old omapdrm panels got removed for v5.4 in favor of generic panels, and the
Kconfigoptions changed. Let's updateomap2plus_defconfigaccordingly so the same panels are still enabled.Cc Jyri Sarha <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Tomi Valkeinen <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- arch/arm/configs/omap2plus_defconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/configs/omap2plus_defconfig +0
-6@@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m CONFIG_DRM_OMAP_PANEL_DPI=m CONFIG_DRM_OMAP_PANEL_DSI_CM=m -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m CONFIG_DRM_TILCDC=march/arm/configs/omap2plus_defconfig CONFIG_DRM_OMAP_CONNECTOR_HDMI=m · line 369
Quoted 10 lines
arch/arm/configs/omap2plus_defconfig +6
-0CONFIG_DRM_PANEL_SIMPLE=m +CONFIG_DRM_PANEL_LG_LB035Q02=m +CONFIG_DRM_PANEL_NEC_NL8048HL11=m +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m +CONFIG_DRM_PANEL_SONY_ACX565AKM=m +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m CONFIG_FB=y CONFIG_FIRMWARE_EDID=y CONFIG_FB_MODE_HELPERS=ySorry, I didn't remember to update these. Some additions:
These can be dropped, they no longer exist:
Quoted 7 lines
CONFIG_DRM_OMAP_ENCODER_TFP410=mCONFIG_DRM_OMAP_CONNECTOR_DVI=mCONFIG_DRM_OMAP_PANEL_DPI=mThis can be added to get the DVI output working on many of the boards:
CONFIG_DRM_TI_TFP410=m
We have patches already posted for these by Adam and me so we should be good to go with just $subject patch missing now.
Regards,
Tony
Tomi Valkeinen
Reviewed-byQuoted 47 lines · Tony Lindgren
Quoted 46 lines · Tomi Valkeinen
Quoted 26 lines · Tony Lindgren
The old omapdrm panels got removed for v5.4 in favor of generic panels, and the
Kconfigoptions changed. Let's updateomap2plus_defconfigaccordingly so the same panels are still enabled.Cc Jyri Sarha <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Tomi Valkeinen <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- arch/arm/configs/omap2plus_defconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/configs/omap2plus_defconfig +0
-6@@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m CONFIG_DRM_OMAP_PANEL_DPI=m CONFIG_DRM_OMAP_PANEL_DSI_CM=m -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m CONFIG_DRM_TILCDC=march/arm/configs/omap2plus_defconfig CONFIG_DRM_OMAP_CONNECTOR_HDMI=m · line 369
Quoted 10 lines
arch/arm/configs/omap2plus_defconfig +6
-0CONFIG_DRM_PANEL_SIMPLE=m +CONFIG_DRM_PANEL_LG_LB035Q02=m +CONFIG_DRM_PANEL_NEC_NL8048HL11=m +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m +CONFIG_DRM_PANEL_SONY_ACX565AKM=m +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m CONFIG_FB=y CONFIG_FIRMWARE_EDID=y CONFIG_FB_MODE_HELPERS=ySorry, I didn't remember to update these. Some additions:
These can be dropped, they no longer exist:
CONFIG_DRM_OMAP_ENCODER_TFP410=mCONFIG_DRM_OMAP_CONNECTOR_DVI=mCONFIG_DRM_OMAP_PANEL_DPI=m
Quoted 6 lines
Quoted 3 lines
This can be added to get the DVI output working on many of the boards:
CONFIG_DRM_TI_TFP410=mWe have patches already posted for these by Adam and me so we should be good to go with just $subject patch missing now.
Ok.
Tomi
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Hi Tomi,
Quoted 40 lines
Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <[email protected]>:
Quoted 24 lines · Tony Lindgren
The old omapdrm panels got removed for v5.4 in favor of generic panels, and the
Kconfigoptions changed. Let's updateomap2plus_defconfigaccordingly so the same panels are still enabled.Cc Jyri Sarha <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Tomi Valkeinen <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- arch/arm/configs/omap2plus_defconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/configs/omap2plus_defconfig +0
-6@@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m CONFIG_DRM_OMAP_PANEL_DPI=m CONFIG_DRM_OMAP_PANEL_DSI_CM=m -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m CONFIG_DRM_TILCDC=march/arm/configs/omap2plus_defconfig CONFIG_DRM_OMAP_CONNECTOR_HDMI=m · line 369
Quoted 10 lines
arch/arm/configs/omap2plus_defconfig +6
-0CONFIG_DRM_PANEL_SIMPLE=m +CONFIG_DRM_PANEL_LG_LB035Q02=m +CONFIG_DRM_PANEL_NEC_NL8048HL11=m +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m +CONFIG_DRM_PANEL_SONY_ACX565AKM=m +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m CONFIG_FB=y CONFIG_FIRMWARE_EDID=y CONFIG_FB_MODE_HELPERS=ySorry, I didn't remember to update these. Some additions:
Quoted 5 lines
These can be dropped, they no longer exist:
CONFIG_DRM_OMAP_ENCODER_TFP410=mCONFIG_DRM_OMAP_CONNECTOR_DVI=mCONFIG_DRM_OMAP_PANEL_DPI=m
After being hit by the __always_inline issue [1] I am now back with being able to test v5.4-rc1.
Now this patch fixes the build problem, but we still have
one: panel drivers are no longer automatically loaded at boot. We now need to manually modprobe them.
This has been observed with GTA04 (TD028TTEC1) and OpenPandora (TD043MTEA1). So moving the drivers seems to have changed/broken something with DT based driver matching.
BR and thanks,
Nikolaus
Hi Nikolaus,
Quoted 49 lines · H. Nikolaus Schaller
Quoted 40 lines
Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <[email protected]>:
Quoted 24 lines · Tony Lindgren
The old omapdrm panels got removed for v5.4 in favor of generic panels, and the
Kconfigoptions changed. Let's updateomap2plus_defconfigaccordingly so the same panels are still enabled.Cc Jyri Sarha <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Tomi Valkeinen <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- arch/arm/configs/omap2plus_defconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/configs/omap2plus_defconfig +0
-6@@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m CONFIG_DRM_OMAP_PANEL_DPI=m CONFIG_DRM_OMAP_PANEL_DSI_CM=m -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m CONFIG_DRM_TILCDC=march/arm/configs/omap2plus_defconfig CONFIG_DRM_OMAP_CONNECTOR_HDMI=m · line 369
Quoted 10 lines
arch/arm/configs/omap2plus_defconfig +6
-0CONFIG_DRM_PANEL_SIMPLE=m +CONFIG_DRM_PANEL_LG_LB035Q02=m +CONFIG_DRM_PANEL_NEC_NL8048HL11=m +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m +CONFIG_DRM_PANEL_SONY_ACX565AKM=m +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m CONFIG_FB=y CONFIG_FIRMWARE_EDID=y CONFIG_FB_MODE_HELPERS=ySorry, I didn't remember to update these. Some additions:
Quoted 5 lines
These can be dropped, they no longer exist:
CONFIG_DRM_OMAP_ENCODER_TFP410=mCONFIG_DRM_OMAP_CONNECTOR_DVI=mCONFIG_DRM_OMAP_PANEL_DPI=mAfter being hit by the
__always_inlineissue [1] I am now back with being able to test v5.4-rc1.
Quoted 7 lines
Now this patch fixes the build problem, but we still have
one: panel drivers are no longer automatically loaded at boot. We now need to manually modprobe them.This has been observed with GTA04 (TD028TTEC1) and OpenPandora (TD043MTEA1). So moving the drivers seems to have changed/broken something with DT based driver matching.
That's really weird, the driver name, the SPI device table and the OF device table are the same (except for the "omapdss," prefix that we don't add anymore in omapdss-boot-init.c). Would you be able to investigate what broke ?
Quoted 1 line
Signature · 3 lines
Regards, Laurent Pinchart
Hi Laurent,
Quoted 58 lines
Am 06.10.2019 um 16:53 schrieb Laurent Pinchart <[email protected]>:
Hi Nikolaus,
Quoted 53 lines · H. Nikolaus Schaller
Quoted 40 lines
Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <[email protected]>:
Quoted 31 lines · Tony Lindgren
The old omapdrm panels got removed for v5.4 in favor of generic panels, and the
Kconfigoptions changed. Let's updateomap2plus_defconfigaccordingly so the same panels are still enabled.Cc Jyri Sarha <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Tomi Valkeinen <[email protected]>Signed-off-by Tony Lindgren <[email protected]>---
arch/arm/configs/omap2plus_defconfig| 12 ++++++------1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/configs/omap2plus_defconfig +0
-0@@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m
CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=mCONFIG_DRM_OMAP_PANEL_DPI=mCONFIG_DRM_OMAP_PANEL_DSI_CM=march/arm/configs/omap2plus_defconfig +0
-6-CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m
CONFIG_DRM_TILCDC=mCONFIG_DRM_PANEL_SIMPLE=march/arm/configs/omap2plus_defconfig +6
-0+CONFIG_DRM_PANEL_LG_LB035Q02=m +CONFIG_DRM_PANEL_NEC_NL8048HL11=m +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m +CONFIG_DRM_PANEL_SONY_ACX565AKM=m +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m +CONFIG_DRM_PANEL_TPO_TD043MTEA1=mQuoted 3 lines
CONFIG_FB=yCONFIG_FIRMWARE_EDID=yCONFIG_FB_MODE_HELPERS=ySorry, I didn't remember to update these. Some additions:
Quoted 5 lines
These can be dropped, they no longer exist:
CONFIG_DRM_OMAP_ENCODER_TFP410=mCONFIG_DRM_OMAP_CONNECTOR_DVI=mCONFIG_DRM_OMAP_PANEL_DPI=mAfter being hit by the
__always_inlineissue [1] I am now back with being able to test v5.4-rc1.Now this patch fixes the build problem, but we still have
one: panel drivers are no longer automatically loaded at boot. We now need to manually modprobe them.
Quoted 6 lines
Quoted 3 lines
This has been observed with GTA04 (TD028TTEC1) and OpenPandora (TD043MTEA1). So moving the drivers seems to have changed/broken something with DT based driver matching.
That's really weird, the driver name, the SPI device table and the OF device table are the same
Yes, that is what I wonder as well. The panels are child nodes of the SPI nodes and should be probed through the SPI bus.
Quoted 3 lines
(except for the "omapdss," prefix that we
don't add anymore inomapdss-boot-init.c). Would you be able to investigate what broke ?
Yes, they have been removed from the omapdss_of_fixups_whitelist but that shouldn't make a difference... And other generic dpi panels work on other omap3 boards.
Most likely something with deferred probing?
I'll try to find clues in the next days.
BR,
Nikolaus
Andreas Kemnade
maintainerQuoted 56 lines · On Sun, 6 Oct 2019 17:53:48 +0300 Laurent Pinchart…
Hi Nikolaus,
Quoted 53 lines · H. Nikolaus Schaller
Quoted 40 lines
Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <[email protected]>:
Quoted 24 lines · Tony Lindgren
The old omapdrm panels got removed for v5.4 in favor of generic panels, and the
Kconfigoptions changed. Let's updateomap2plus_defconfigaccordingly so the same panels are still enabled.Cc Jyri Sarha <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Tomi Valkeinen <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- arch/arm/configs/omap2plus_defconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/configs/omap2plus_defconfig +0
-6@@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m CONFIG_DRM_OMAP_PANEL_DPI=m CONFIG_DRM_OMAP_PANEL_DSI_CM=m -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m CONFIG_DRM_TILCDC=march/arm/configs/omap2plus_defconfig CONFIG_DRM_OMAP_CONNECTOR_HDMI=m · line 369
Quoted 10 lines
arch/arm/configs/omap2plus_defconfig +6
-0CONFIG_DRM_PANEL_SIMPLE=m +CONFIG_DRM_PANEL_LG_LB035Q02=m +CONFIG_DRM_PANEL_NEC_NL8048HL11=m +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m +CONFIG_DRM_PANEL_SONY_ACX565AKM=m +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m CONFIG_FB=y CONFIG_FIRMWARE_EDID=y CONFIG_FB_MODE_HELPERS=ySorry, I didn't remember to update these. Some additions:
Quoted 5 lines
These can be dropped, they no longer exist:
CONFIG_DRM_OMAP_ENCODER_TFP410=mCONFIG_DRM_OMAP_CONNECTOR_DVI=mCONFIG_DRM_OMAP_PANEL_DPI=mAfter being hit by the
__always_inlineissue [1] I am now back with being able to test v5.4-rc1.Now this patch fixes the build problem, but we still have
one: panel drivers are no longer automatically loaded at boot. We now need to manually modprobe them.
Quoted 9 lines
Quoted 3 lines
This has been observed with GTA04 (TD028TTEC1) and OpenPandora (TD043MTEA1). So moving the drivers seems to have changed/broken something with DT based driver matching.
That's really weird, the driver name, the SPI device table and the OF device table are the same (except for the "omapdss," prefix that we don't add anymore in
omapdss-boot-init.c). Would you be able to investigate what broke ?
in earlier times:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias spi:tpo,td028ttec1
now in 5.4-rc1:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias spi:td028ttec1
root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko license: GPL description: Toppoly TD028TTEC1 panel driver author: H. Nikolaus Schaller <[email protected]> srcversion: 6B3E224BCD3D76253CF361C alias: of:N*T*Ctoppoly,td028ttec1C* alias: of:N*T*Ctoppoly,td028ttec1 alias: of:N*T*Ctpo,td028ttec1C* alias: of:N*T*Ctpo,td028ttec1 alias: spi:toppoly,td028ttec1 alias: spi:tpo,td028ttec1 depends: drm intree: Y name: panel_tpo_td028ttec1 vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
That alias is not in the list.
Regards,
Andreas
Andreas Kemnade
maintainerQuoted 94 lines · On Sun, 6 Oct 2019 22:39:58 +0200 Andreas Kemnade <[email protected]> wrote:
Quoted 56 lines · On Sun, 6 Oct 2019 17:53:48 +0300 Laurent Pinchart…
Hi Nikolaus,
Quoted 53 lines · H. Nikolaus Schaller
Quoted 40 lines
Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <[email protected]>:
Quoted 24 lines · Tony Lindgren
The old omapdrm panels got removed for v5.4 in favor of generic panels, and the
Kconfigoptions changed. Let's updateomap2plus_defconfigaccordingly so the same panels are still enabled.Cc Jyri Sarha <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Tomi Valkeinen <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- arch/arm/configs/omap2plus_defconfig | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm/configs/omap2plus_defconfig +0
-6@@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m CONFIG_DRM_OMAP_PANEL_DPI=m CONFIG_DRM_OMAP_PANEL_DSI_CM=m -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m CONFIG_DRM_TILCDC=march/arm/configs/omap2plus_defconfig CONFIG_DRM_OMAP_CONNECTOR_HDMI=m · line 369
Quoted 10 lines
arch/arm/configs/omap2plus_defconfig +6
-0CONFIG_DRM_PANEL_SIMPLE=m +CONFIG_DRM_PANEL_LG_LB035Q02=m +CONFIG_DRM_PANEL_NEC_NL8048HL11=m +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m +CONFIG_DRM_PANEL_SONY_ACX565AKM=m +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m CONFIG_FB=y CONFIG_FIRMWARE_EDID=y CONFIG_FB_MODE_HELPERS=ySorry, I didn't remember to update these. Some additions:
Quoted 5 lines
These can be dropped, they no longer exist:
CONFIG_DRM_OMAP_ENCODER_TFP410=mCONFIG_DRM_OMAP_CONNECTOR_DVI=mCONFIG_DRM_OMAP_PANEL_DPI=mAfter being hit by the
__always_inlineissue [1] I am now back with being able to test v5.4-rc1.Now this patch fixes the build problem, but we still have
one: panel drivers are no longer automatically loaded at boot. We now need to manually modprobe them.Quoted 9 lines
Quoted 3 lines
This has been observed with GTA04 (TD028TTEC1) and OpenPandora (TD043MTEA1). So moving the drivers seems to have changed/broken something with DT based driver matching.
That's really weird, the driver name, the SPI device table and the OF device table are the same (except for the "omapdss," prefix that we don't add anymore in
omapdss-boot-init.c). Would you be able to investigate what broke ?in earlier times:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias spi:tpo,td028ttec1now in 5.4-rc1:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias spi:td028ttec1root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko license: GPL description: Toppoly TD028TTEC1 panel driver author: H. Nikolaus Schaller <[email protected]> srcversion: 6B3E224BCD3D76253CF361C alias: of:N*T*Ctoppoly,td028ttec1C* alias: of:N*T*Ctoppoly,td028ttec1 alias: of:N*T*Ctpo,td028ttec1C* alias: of:N*T*Ctpo,td028ttec1 alias: spi:toppoly,td028ttec1 alias: spi:tpo,td028ttec1 depends: drm intree: Y name: panel_tpo_td028ttec1 vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
Quoted 2 lines
That alias is not in the list.
some more research:
in former timesof_modalias_node() has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1 now it strips the tpo prefix because there is no omapdss prefix anymore.
Regards,
Andreas
Quoted 31 lines · Andreas Kemnade
Quoted 31 lines
Quoted 5 lines
That's really weird, the driver name, the SPI device table and the OF device table are the same (except for the "omapdss," prefix that we don't add anymore in
omapdss-boot-init.c). Would you be able to investigate what broke ?in earlier times:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias spi:tpo,td028ttec1now in 5.4-rc1:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias spi:td028ttec1root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko license: GPL description: Toppoly TD028TTEC1 panel driver author: H. Nikolaus Schaller <[email protected]> srcversion: 6B3E224BCD3D76253CF361C alias: of:N*T*Ctoppoly,td028ttec1C* alias: of:N*T*Ctoppoly,td028ttec1 alias: of:N*T*Ctpo,td028ttec1C* alias: of:N*T*Ctpo,td028ttec1 alias: spi:toppoly,td028ttec1 alias: spi:tpo,td028ttec1 depends: drm intree: Y name: panel_tpo_td028ttec1 vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8
Quoted 6 lines
Quoted 2 lines
That alias is not in the list.
some more research:
in former timesof_modalias_node()has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1 now it strips the tpo prefix because there is no omapdss prefix anymore.
I haven't studied this more yet, but yes, I can see of_modalias_node stripping the vendor prefix on purpose. I do wonder how this is supposed to work, it would make more sense to me to keep the vendor prefix.
Is the spi_device_id supposed to be without vendor prefix? With a quick grep, this seems to be the case.
Tomi
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Andreas Kemnade
maintainerQuoted 40 lines · On Mon, 7 Oct 2019 17:29:20 +0300 Tomi Valkeinen <[email protected]> wrote:
Quoted 31 lines · Andreas Kemnade
Quoted 31 lines
Quoted 5 lines
That's really weird, the driver name, the SPI device table and the OF device table are the same (except for the "omapdss," prefix that we don't add anymore in
omapdss-boot-init.c). Would you be able to investigate what broke ?in earlier times:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias spi:tpo,td028ttec1now in 5.4-rc1:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias spi:td028ttec1root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko license: GPL description: Toppoly TD028TTEC1 panel driver author: H. Nikolaus Schaller <[email protected]> srcversion: 6B3E224BCD3D76253CF361C alias: of:N*T*Ctoppoly,td028ttec1C* alias: of:N*T*Ctoppoly,td028ttec1 alias: of:N*T*Ctpo,td028ttec1C* alias: of:N*T*Ctpo,td028ttec1 alias: spi:toppoly,td028ttec1 alias: spi:tpo,td028ttec1 depends: drm intree: Y name: panel_tpo_td028ttec1 vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8Quoted 6 lines
Quoted 2 lines
That alias is not in the list.
some more research:
in former timesof_modalias_node()has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1 now it strips the tpo prefix because there is no omapdss prefix anymore.
Quoted 7 lines
I haven't studied this more yet, but yes, I can see
of_modalias_nodestripping the vendor prefix on purpose. I do wonder how this is supposed to work, it would make more sense to me to keep the vendor prefix.Is the
spi_device_idsupposed to be without vendor prefix? With a quick grep, this seems to be the case.
as it is done in drivers/spi/spi.c we have no influence from drm side. So we must live with it. Also checked several drivers, no vendor-prefix there.
Regards,
Andreas
Quoted 45 lines · Andreas Kemnade
Quoted 44 lines · On Mon, 7 Oct 2019 17:29:20 +0300 Tomi Valkeinen wrote:
Quoted 31 lines · Andreas Kemnade
Quoted 31 lines
Quoted 5 lines
That's really weird, the driver name, the SPI device table and the OF device table are the same (except for the "omapdss," prefix that we don't add anymore in
omapdss-boot-init.c). Would you be able to investigate what broke ?in earlier times:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias spi:tpo,td028ttec1now in 5.4-rc1:
root@gta04:/sys/bus/spi/devices/spi4.0# cat modalias spi:td028ttec1root@gta04:~# modinfo /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko filename: /lib/modules/5.4.0-rc1-letux+/kernel/drivers/gpu/drm/panel/panel-tpo-td028ttec1.ko license: GPL description: Toppoly TD028TTEC1 panel driver author: H. Nikolaus Schaller <[email protected]> srcversion: 6B3E224BCD3D76253CF361C alias: of:N*T*Ctoppoly,td028ttec1C* alias: of:N*T*Ctoppoly,td028ttec1 alias: of:N*T*Ctpo,td028ttec1C* alias: of:N*T*Ctpo,td028ttec1 alias: spi:toppoly,td028ttec1 alias: spi:tpo,td028ttec1 depends: drm intree: Y name: panel_tpo_td028ttec1 vermagic: 5.4.0-rc1-letux+ SMP preempt mod_unload ARMv7 p2v8Quoted 6 lines
Quoted 2 lines
That alias is not in the list.
some more research:
in former timesof_modalias_node()has stripped the omapdss prefix, result: modalias=spi:tpo,td028ttec1 now it strips the tpo prefix because there is no omapdss prefix anymore.I haven't studied this more yet, but yes, I can see
of_modalias_nodestripping the vendor prefix on purpose. I do wonder how this is supposed to work, it would make more sense to me to keep the vendor prefix.
Quoted 6 lines
Quoted 2 lines
Is the
spi_device_idsupposed to be without vendor prefix? With a quick grep, this seems to be the case.as it is done in
drivers/spi/spi.cwe have no influence from drm side. So we must live with it. Also checked several drivers, no vendor-prefix there.
I *think* SPI drivers are not supposed to include any prefix. The fix would then simply be to strip the prefix from the SPI table (leaving it there for the OF table of course). I've submitted a patch series to do so.
Signature · 3 lines
Regards, Laurent Pinchart