Skip to contentSkip to conversation

igmp: uninline ip_mc_validate_checksum()

PATCH Applied Alexey Dobriyan 2 participants 2 messages Oct 3, 2019 – Oct 4, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igmp: uninline ip_mc_validate_checksum()

This function is only used via function pointer.

"inline" doesn't hurt given that taking address of an inline function forces out-of-line version but it doesn't help either.

---

 net/ipv4/igmp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/igmp.c +1 -1
@@ -1563,7 +1563,7 @@ static int ip_mc_check_igmp_msg(struct sk_buff *skb)
 	}
 }
 
-static inline __sum16 ip_mc_validate_checksum(struct sk_buff *skb)
+static __sum16 ip_mc_validate_checksum(struct sk_buff *skb)
 {
 	return skb_checksum_simple_validate(skb);
 }
maintainer Applied
#1 lore raw

From: Alexey Dobriyan <[email protected]>
Date: Fri, 4 Oct 2019 00:26:52 +0300

Quoted 6 lines

This function is only used via function pointer.

"inline" doesn't hurt given that taking address of an inline function forces out-of-line version but it doesn't help either.

Applied.