Skip to contentSkip to conversation

perf: add support for logging debug messages to file

PATCH Superseded Changbin Du 2 participants 5 messages Oct 4, 2019 – Oct 8, 2019 perf events

v3 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v3 cover perf: add support for logging debug messages to file

When in TUI mode, it is impossible to show all the debug messages to console. This make it hard to debug perf issues using debug messages. This patch adds support for logging debug messages to file to resolve this problem.

v3:
o fix a segfault issue.
v2:
o specific all debug options one time.

Changbin Du (2):
perf: support multiple debug options separated by ','
perf: add support for logging debug messages to file

 tools/perf/Documentation/perf.txt |  15 ++--
 tools/perf/util/debug.c           | 124 +++++++++++++++++++-----------
 2 files changed, 90 insertions(+), 49 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH v3 1/2 perf: support multiple debug options separated by ','

This patch adds support for multiple debug options separated by ',' and non-int values.
--debug verbose=2,stderr

---
 tools/perf/Documentation/perf.txt | 10 ++--
 tools/perf/util/debug.c           | 86 ++++++++++++++++---------------
 2 files changed, 50 insertions(+), 46 deletions(-)
tools/perf/Documentation/perf.txt +5 -5
index 401f0ed67439..c05a94b2488e 100644
@@ -19,11 +19,11 @@ OPTIONS
 	  --debug verbose=2 # sets verbose = 2
 
 	List of debug variables allowed to set:
-	  verbose          - general debug messages
-	  ordered-events   - ordered events object debug messages
-	  data-convert     - data convert command debug messages
-	  stderr           - write debug output (option -v) to stderr
-	                     in browser mode
+	  verbose=level		- general debug messages
+	  ordered-events=level	- ordered events object debug messages
+	  data-convert=level	- data convert command debug messages
+	  stderr		- write debug output (option -v) to stderr
+				  in browser mode
 
 --buildid-dir::
 	Setup buildid cache directory. It has higher priority than
tools/perf/util/debug.c +45 -41

113 lines not on this page · raw message

Signature · 1 line
2.20.1
#2 lore raw

PATCH v3 2/2 perf: add support for logging debug messages to file

In reply to Changbin Du

When in TUI mode, it is impossible to show all the debug messages to console. This make it hard to debug perf issues using debug messages. This patch adds support for logging debug messages to file to resolve this problem.

The usage is:
perf -debug verbose=2,file=~/perf.log COMMAND

--
v3: fix a segfault issue.

---
 tools/perf/Documentation/perf.txt | 15 ++++++-----
 tools/perf/util/debug.c           | 44 +++++++++++++++++++++++++++----
 2 files changed, 48 insertions(+), 11 deletions(-)
tools/perf/Documentation/perf.txt +9 -6
index c05a94b2488e..a6b19661e5c3 100644
@@ -16,14 +16,17 @@ OPTIONS
 	Setup debug variable (see list below) in value
 	range (0, 10). Use like:
 	  --debug verbose   # sets verbose = 1
-	  --debug verbose=2 # sets verbose = 2
+	  --debug verbose=2,file=~/perf.log
+	                    # sets verbose = 2 and save log to file
 
 	List of debug variables allowed to set:
-	  verbose=level		- general debug messages
-	  ordered-events=level	- ordered events object debug messages
-	  data-convert=level	- data convert command debug messages
-	  stderr		- write debug output (option -v) to stderr
-				  in browser mode
+	  verbose=level         - general debug messages
+	  ordered-events=level  - ordered events object debug messages
+	  data-convert=level    - data convert command debug messages
+	  stderr                - write debug output (option -v) to stderr
+	                          in browser mode
+	  file=path             - write debug output to log file (stderr and
+	                          file options are exclusive)
 
 --buildid-dir::
 	Setup buildid cache directory. It has higher priority than
tools/perf/util/debug.c +39 -5

76 lines not on this page · raw message

Signature · 1 line
2.20.1
#3 lore raw
In reply to Changbin Du
Quoted 7 lines · Changbin Du

When in TUI mode, it is impossible to show all the debug messages to console. This make it hard to debug perf issues using debug messages. This patch adds support for logging debug messages to file to resolve this problem.

v3:
o fix a segfault issue.

heya,
getting segfault for this:

[jolsa@krava perf]$ ./perf report -vv 2>out
Segmentation fault (core dumped)

jirka

Quoted 14 lines

v2:
o specific all debug options one time.

Changbin Du (2):
perf: support multiple debug options separated by ','
perf: add support for logging debug messages to file

 tools/perf/Documentation/perf.txt |  15 ++--
 tools/perf/util/debug.c           | 124 +++++++++++++++++++-----------
 2 files changed, 90 insertions(+), 49 deletions(-)
Signature · 1 line
2.20.1
#4 lore raw
Quoted 6 lines · Jiri Olsa
Quoted 5 lines · Changbin Du

When in TUI mode, it is impossible to show all the debug messages to console. This make it hard to debug perf issues using debug messages. This patch adds support for logging debug messages to file to resolve this problem.

Quoted 9 lines
Quoted 2 lines

v3:
o fix a segfault issue.

heya,
getting segfault for this:

[jolsa@krava perf]$ ./perf report -vv 2>out
Segmentation fault (core dumped)

This can be fixed by below change. In this case, log_file is NULL.

tools/perf/util/debug.c +3 -1
@@ -37,8 +37,10 @@ int veprintf(int level, int var, const char *fmt, va_list args)
        if (var >= level) {
                if (use_browser >= 1 && !log_file)
                        ui_helpline__vshow(fmt, args);
-               else
+               else if (log_file)
                        ret = vfprintf(log_file, fmt, args);
+               else
+                       ret = vfprintf(stderr, fmt, args);
        }
 
        return ret;
Quoted 16 lines

jirka

Quoted 14 lines

v2:
o specific all debug options one time.

Changbin Du (2):
perf: support multiple debug options separated by ','
perf: add support for logging debug messages to file

 tools/perf/Documentation/perf.txt |  15 ++--
 tools/perf/util/debug.c           | 124 +++++++++++++++++++-----------
 2 files changed, 90 insertions(+), 49 deletions(-)
Signature · 1 line
2.20.1
Signature · 2 lines
Cheers,
Changbin Du