Skip to contentSkip to conversation

audio: add -audiodev pa,in|out.latency= to documentation

PATCH In review Stefan Hajnoczi 3 participants 3 messages Oct 4, 2019 – Nov 5, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 audio: add -audiodev pa,in|out.latency= to documentation

The "latency" parameter wasn't covered by the documentation.

---
Hi Gerd,
You asked me to resend this patch because there was a conflict. I have rebased it onto qemu.git/master (4f59102571fc).

 qemu-options.hx | 5 +++++
 1 file changed, 5 insertions(+)
qemu-options.hx +5 -0
index 2a04ca6ac5..5c27c57273 100644
@@ -470,6 +470,7 @@ DEF("audiodev", HAS_ARG, QEMU_OPTION_audiodev,
     "-audiodev pa,id=id[,prop[=value][,...]]\n"
     "                server= PulseAudio server address\n"
     "                in|out.name= source/sink device name\n"
+    "                in|out.latency= desired latency in microseconds\n"
 #endif
 #ifdef CONFIG_AUDIO_SDL
     "-audiodev sdl,id=id[,prop[=value][,...]]\n"
@@ -630,6 +631,10 @@ Sets the PulseAudio @var{server} to connect to.
 @item in|out.name=@var{sink}
 Use the specified source/sink for recording/playback.
 
+@item in|out.latency=@var{usecs}
+Desired latency in microseconds.  The PulseAudio server will try to honor this
+value but actual latencies may be lower or higher.
+
 @end table
 
 @item -audiodev sdl,id=@var{id}[,@var{prop}[=@var{value}][,...]]
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw

Hi

Quoted 25 lines · Stefan Hajnoczi

The "latency" parameter wasn't covered by the documentation.

---
Hi Gerd,
You asked me to resend this patch because there was a conflict. I have rebased it onto qemu.git/master (4f59102571fc).

 qemu-options.hx | 5 +++++
 1 file changed, 5 insertions(+)
qemu-options.hx +1 -0
index 2a04ca6ac5..5c27c57273 100644
@@ -470,6 +470,7 @@ DEF("audiodev", HAS_ARG, QEMU_OPTION_audiodev,
     "-audiodev pa,id=id[,prop[=value][,...]]\n"
     "                server= PulseAudio server address\n"
     "                in|out.name= source/sink device name\n"
+    "                in|out.latency= desired latency in microseconds\n"
 #endif
 #ifdef CONFIG_AUDIO_SDL
     "-audiodev sdl,id=id[,prop[=value][,...]]\n"

qemu-options.hx Sets the PulseAudio @var{server} to connect to. · line 636

Quoted 6 lines
qemu-options.hx +3 -0
@@ -630,6 +631,10 @@ Sets the PulseAudio @var{server} to connect to.
 @item in|out.name=@var{sink}
 Use the specified source/sink for recording/playback.
 
+@item in|out.latency=@var{usecs}
+Desired latency in microseconds.  The PulseAudio server will try to honor this
+value but actual latencies may be lower or higher.

default is 15ms according to f6142777659f2e7ad143f2850f1f036f899f475f, might be worth to document.

otherwise, looks good:

Quoted 8 lines
qemu-options.hx +1 -1
+
 @end table
 
 @item -audiodev sdl,id=@var{id}[,@var{prop}[=@var{value}][,...]]
--

2.21.0

Signature · 1 line
Marc-André Lureau
#2 lore raw
In reply to Stefan Hajnoczi
Quoted 10 lines · Stefan Hajnoczi

The "latency" parameter wasn't covered by the documentation.

---
Hi Gerd,
You asked me to resend this patch because there was a conflict. I have rebased it onto qemu.git/master (4f59102571fc).

 qemu-options.hx | 5 +++++
 1 file changed, 5 insertions(+)

Ping?

Quoted 27 lines
qemu-options.hx +5 -0
index 2a04ca6ac5..5c27c57273 100644
@@ -470,6 +470,7 @@ DEF("audiodev", HAS_ARG, QEMU_OPTION_audiodev,
     "-audiodev pa,id=id[,prop[=value][,...]]\n"
     "                server= PulseAudio server address\n"
     "                in|out.name= source/sink device name\n"
+    "                in|out.latency= desired latency in microseconds\n"
 #endif
 #ifdef CONFIG_AUDIO_SDL
     "-audiodev sdl,id=id[,prop[=value][,...]]\n"
@@ -630,6 +631,10 @@ Sets the PulseAudio @var{server} to connect to.
 @item in|out.name=@var{sink}
 Use the specified source/sink for recording/playback.
 
+@item in|out.latency=@var{usecs}
+Desired latency in microseconds.  The PulseAudio server will try to honor this
+value but actual latencies may be lower or higher.
+
 @end table
 
 @item -audiodev sdl,id=@var{id}[,@var{prop}[=@var{value}][,...]]
Signature · 1 line
2.21.0