uacme: fix c99 detection on microblazeel, powerpc
PATCH 1/1 uacme: fix c99 detection on microblazeel, powerpc
Fixes:
microblazeel http://autobuild.buildroot.net/results/bc715a2f53f72630ae13e3d226e6a029915c4ee4
powerpc http://autobuild.buildroot.net/results/07d5e454ffd11527d70268681fe15e9de77379e4
--- package/uacme/uacme.mk | 4 ++++ 1 file changed, 4 insertions(+)
package/uacme/uacme.mk +4 -0
@@ -13,6 +13,10 @@ UACME_LICENSE = GPL-3.0+ UACME_LICENSE_FILES = COPYING UACME_DEPENDENCIES = libcurl +ifneq (,$(filter $(ARCH),microblazeel powerpc)) +UACME_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99' +endif + ifeq ($(BR2_PACKAGE_MBEDTLS),y) UACME_CONF_OPTS += --with-mbedtls UACME_DEPENDENCIES += mbedtls
Signature · 1 line
2.1.4
PATCH 1/1 uacme: fix c99 detection on microblazeel, powerpc
Hello Nicola,
Quoted 15 lines · On Fri, 4 Oct 2019 11:53:15 +0200 Nicola Di Lieto <[email protected]>…
Fixes:
microblazeel http://autobuild.buildroot.net/results/bc715a2f53f72630ae13e3d226e6a029915c4ee4
powerpc http://autobuild.buildroot.net/results/07d5e454ffd11527d70268681fe15e9de77379e4Signed-off-by Nicola Di Lieto <[email protected]>--- package/uacme/uacme.mk | 4 ++++ 1 file changed, 4 insertions(+)package/uacme/uacme.mk +0
-0
package/uacme/uacme.mk UACME_LICENSE = GPL-3.0+ · line 18
Quoted 6 lines
package/uacme/uacme.mk +3
-0@@ -13,6 +13,10 @@ UACME_LICENSE = GPL-3.0+ UACME_LICENSE_FILES = COPYING UACME_DEPENDENCIES = libcurl +ifneq (,$(filter $(ARCH),microblazeel powerpc)) +UACME_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99' +endif
This is not correct: as I told you privately, this issue is not at all related to Microblaze or PowerPC architectures, but it's related to the toolchain lacking wide-char support, and the AC_PROG_CC_C99 macro testing C99 support using wide-char, even if in the end the package doesn't need wchar support. You can try yourself: build an ARM configuration without wide-char support, and you should get the same problem.
So, the commit title should be:
package/uacme: fix c99 detection on !wchar toolchains
and the code should be just:
UACME_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
i.e, unconditional.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 uacme: fix c99 detection on microblazeel, powerpc
Quoted 10 lines · Thomas Petazzoni
So, the commit title should be:
package/uacme: fix c99 detection on !wchar toolchains
and the code should be just:
UACME_CONF_ENV= ac_cv_prog_cc_c99='-std=gnu99'i.e, unconditional.
Hello Thomas,
as suggested, new patch version
http://lists.busybox.net/pipermail/buildroot/2019-October/261605.html
Thanks for your time
Nicola