Skip to contentSkip to conversation

crypto: user - fix memory leak in crypto_report

PATCH In review Navid Emamdoost 3 participants 3 messages Oct 4, 2019 – Oct 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: user - fix memory leak in crypto_report

In crypto_report, a new skb is created via nlmsg_new(). This skb should be released if crypto_report_alg() fails.

Fixes a38f7907b926 ("crypto: Add userspace configuration API")
---
 crypto/crypto_user_base.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
crypto/crypto_user_base.c +3 -1
index 910e0b46012e..b785c476de67 100644
@@ -213,8 +213,10 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
 drop_alg:
 	crypto_mod_put(alg);
 
-	if (err)
+	if (err) {
+		kfree_skb(skb);
 		return err;
+	}
 
 	return nlmsg_unicast(net->crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
 }
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines

In crypto_report, a new skb is created via nlmsg_new(). This skb should be released if crypto_report_alg() fails.

Please improve this change description.

Regards,
Markus

maintainer
#2 lore raw
In reply to Navid Emamdoost
Quoted 8 lines · Navid Emamdoost

In crypto_report, a new skb is created via nlmsg_new(). This skb should be released if crypto_report_alg() fails.

Fixes a38f7907b926 ("crypto: Add userspace configuration API")
---
 crypto/crypto_user_base.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt