crypto: user - fix memory leak in crypto_report
Subsystems (2)
PATCH 1/1 crypto: user - fix memory leak in crypto_report
In crypto_report, a new skb is created via nlmsg_new(). This skb should be released if crypto_report_alg() fails.
Fixes a38f7907b926 ("crypto: Add userspace configuration API")
Signed-off-by Navid Emamdoost <[email protected]>
--- crypto/crypto_user_base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
crypto/crypto_user_base.c +3 -1
@@ -213,8 +213,10 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh, drop_alg:crypto_mod_put (alg); -if (err) +if (err) { +kfree_skb (skb);return err; + }return nlmsg_unicast (net->crypto_nlsk, skb,NETLINK_CB (in_skb).portid); }
Signature · 1 line
2.17.1
Quoted 2 lines
In
crypto_report, a new skb is created vianlmsg_new(). This skb should be released ifcrypto_report_alg()fails.
Please improve this change description.
Regards,
Markus
Herbert Xu
maintainerQuoted 8 lines · Navid Emamdoost
In
crypto_report, a new skb is created vianlmsg_new(). This skb should be released ifcrypto_report_alg()fails.Fixes a38f7907b926 ("crypto: Add userspace configuration API")Signed-off-by Navid Emamdoost <[email protected]>--- crypto/crypto_user_base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt