crypto: user - fix memory leak in crypto_reportstat
Subsystems (2)
PATCH 1/1 crypto: user - fix memory leak in crypto_reportstat
In crypto_reportstat, a new skb is created by nlmsg_new(). This skb is leaked if crypto_reportstat_alg() fails. Required release for skb is added.
Fixes cac5818c25d0 ("crypto: user - Implement a generic crypto statistics")
Signed-off-by Navid Emamdoost <[email protected]>
--- crypto/crypto_user_stat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
crypto/crypto_user_stat.c +3 -1
@@ -328,8 +328,10 @@ int crypto_reportstat(struct sk_buff *in_skb, struct nlmsghdr *in_nlh, drop_alg:crypto_mod_put (alg); -if (err) +if (err) { +kfree_skb (skb);return err; + }return nlmsg_unicast (net->crypto_nlsk, skb,NETLINK_CB (in_skb).portid); }
Signature · 1 line
2.17.1
Quoted 3 lines
In
crypto_reportstat, a new skb is created bynlmsg_new(). This skb is leaked ifcrypto_reportstat_alg()fails. Required release for skb is added.
Please improve this change description.
Regards,
Markus
Herbert Xu
maintainerQuoted 9 lines · Navid Emamdoost
In
crypto_reportstat, a new skb is created bynlmsg_new(). This skb is leaked ifcrypto_reportstat_alg()fails. Required release for skb is added.Fixes cac5818c25d0 ("crypto: user - Implement a generic crypto statistics")Signed-off-by Navid Emamdoost <[email protected]>--- crypto/crypto_user_stat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt