nl80211: fix memory leak in nl80211_get_ftm_responder_stats
PATCH 1/1 nl80211: fix memory leak in nl80211_get_ftm_responder_stats
In nl80211_get_ftm_responder_stats, a new skb is created via nlmsg_new named msg. If nl80211hdr_put() fails, then msg should be released. The return statement should be replace by goto to error handling code.
Fixes 81e54d08d9d8 ("cfg80211: support FTM responder configuration/statistics")
Signed-off-by Navid Emamdoost <[email protected]>
--- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/wireless/nl80211.c +1 -1
@@ -13644,7 +13644,7 @@ static int nl80211_get_ftm_responder_stats(struct sk_buff *skb, hdr =nl80211hdr_put (msg, info->snd_portid, info->snd_seq,0 ,NL80211_CMD_GET_FTM_RESPONDER_STATS );if (!hdr) -return -ENOBUFS ; + goto nla_put_failure;if (nla_put_u32 (msg,NL80211_ATTR_IFINDEX , dev->ifindex)) goto nla_put_failure;
Signature · 1 line
2.17.1
Quoted 3 lines
In
nl80211_get_ftm_responder_stats, a new skb is created vianlmsg_newnamed msg. Ifnl80211hdr_put()fails, then msg should be released. The return statement should be replace by goto to error handling code.
Please improve this change description (also by avoiding a typo).
Regards,
Markus