rtl8xxxu: add bluetooth co-existence support for single antenna
Subsystems (3)
PATCH v3 1/1 rtl8xxxu: add bluetooth co-existence support for single antenna
The RTL8723BU suffers the wifi disconnection problem while bluetooth device connected. While wifi is doing tx/rx, the bluetooth will scan without results. This is due to the wifi and bluetooth share the same single antenna for RF communication and they need to have a mechanism to collaborate.
BT information is provided via the packet sent from co-processor to host (C2H). It contains the status of BT but the rtl8723bu_handle_c2h dose not really handle it. And there's no bluetooth coexistence mechanism to deal with it.
This commit adds a workqueue to set the tdma configurations and coefficient table per the parsed bluetooth link status and given wifi connection state. The tdma/coef table comes from the vendor driver code of the RTL8192EU and RTL8723BU. However, this commit is only for single antenna scenario which RTL8192EU is default dual antenna. The rtl8xxxu_parse_rxdesc24 which invokes the handle_c2h is only for 8723b and 8192e so the mechanism is expected to work on both chips with single antenna. Note RTL8192EU dual antenna is not supported.
---
Notes:
v2:
- Add helper functions to replace bunch of tdma settings
- Reformat some lines to meet kernel coding style
v3:
- Add comment for rtl8723bu_set_coex_with_type()
.../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 37 +++ .../realtek/rtl8xxxu/rtl8xxxu_8723b.c | 2 - .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 269 +++++++++++++++++- 3 files changed, 301 insertions(+), 7 deletions(-)
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h +37 -0
@@ -1220,6 +1220,37 @@ enum ratr_table_mode_new { RATEID_IDX_BGN_3SS = 14, }; +#define BT_INFO_8723B_1ANT_B_FTP BIT(7) +#define BT_INFO_8723B_1ANT_B_A2DP BIT(6) +#define BT_INFO_8723B_1ANT_B_HID BIT(5) +#define BT_INFO_8723B_1ANT_B_SCO_BUSY BIT(4) +#define BT_INFO_8723B_1ANT_B_ACL_BUSY BIT(3) +#define BT_INFO_8723B_1ANT_B_INQ_PAGE BIT(2) +#define BT_INFO_8723B_1ANT_B_SCO_ESCO BIT(1) +#define BT_INFO_8723B_1ANT_B_CONNECTION BIT(0) + +enum _BT_8723B_1ANT_STATUS { +BT_8723B_1ANT_STATUS_NON_CONNECTED_IDLE =0x0 , +BT_8723B_1ANT_STATUS_CONNECTED_IDLE =0x1 , +BT_8723B_1ANT_STATUS_INQ_PAGE =0x2 , +BT_8723B_1ANT_STATUS_ACL_BUSY =0x3 , +BT_8723B_1ANT_STATUS_SCO_BUSY =0x4 , +BT_8723B_1ANT_STATUS_ACL_SCO_BUSY =0x5 , +BT_8723B_1ANT_STATUS_MAX +}; + +struct rtl8xxxu_btcoex { +u8 bt_status; +bool bt_busy; +bool has_sco; +bool has_a2dp; +bool has_hid; +bool has_pan; +bool hid_only; +bool a2dp_only; +bool c2h_bt_inquiry; +}; +#define RTL8XXXU_RATR_STA_INIT 0#define RTL8XXXU_RATR_STA_HIGH 1#define RTL8XXXU_RATR_STA_MID 2
@@ -1340,6 +1371,10 @@ struct rtl8xxxu_priv {*/ struct ieee80211_vif *vif;struct delayed_work ra_watchdog; +struct work_struct c2hcmd_work; +struct sk_buff_head c2hcmd_queue; +spinlock_t c2hcmd_lock; +struct rtl8xxxu_btcoex bt_coex; };struct rtl8xxxu_rx_urb {
@@ -1486,6 +1521,8 @@ void rtl8xxxu_fill_txdesc_v2(struct ieee80211_hw *hw, struct ieee80211_hdr *hdr, struct rtl8xxxu_txdesc32 *tx_desc32, bool sgi, bool short_preamble, bool ampdu_enable, u32 rts_rate); +void rtl8723bu_set_ps_tdma (struct rtl8xxxu_priv *priv, +u8 arg1,u8 arg2,u8 arg3,u8 arg4,u8 arg5);extern struct rtl8xxxu_fileops rtl8192cu_fops;extern struct rtl8xxxu_fileops rtl8192eu_fops;
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c +0 -2
@@ -1580,9 +1580,7 @@ static void rtl8723b_enable_rf(struct rtl8xxxu_priv *priv)/* * Software control, antenna at WiFi side */ -#ifdef NEED_PS_TDMA rtl8723bu_set_ps_tdma (priv,0x08 ,0x00 ,0x00 ,0x00 ,0x00 ); -#endif rtl8xxxu_write32 (priv,REG_BT_COEX_TABLE1 ,0x55555555 );rtl8xxxu_write32 (priv,REG_BT_COEX_TABLE2 ,0x55555555 );
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +264 -5
311 lines not on this page · raw message
Signature · 1 line
2.20.1
Jes Sorensen
maintainerQuoted 22 lines · Chris Chiu
The RTL8723BU suffers the wifi disconnection problem while bluetooth device connected. While wifi is doing tx/rx, the bluetooth will scan without results. This is due to the wifi and bluetooth share the same single antenna for RF communication and they need to have a mechanism to collaborate.
BT information is provided via the packet sent from co-processor to host (C2H). It contains the status of BT but the
rtl8723bu_handle_c2hdose not really handle it. And there's no bluetooth coexistence mechanism to deal with it.This commit adds a workqueue to set the tdma configurations and coefficient table per the parsed bluetooth link status and given wifi connection state. The tdma/coef table comes from the vendor driver code of the RTL8192EU and RTL8723BU. However, this commit is only for single antenna scenario which RTL8192EU is default dual antenna. The
rtl8xxxu_parse_rxdesc24which invokes thehandle_c2his only for 8723b and 8192e so the mechanism is expected to work on both chips with single antenna. Note RTL8192EU dual antenna is not supported.Signed-off-by Chris Chiu <[email protected]>
Quoted 8 lines
---
Notes:
v2:
- Add helper functions to replace bunch of tdma settings
- Reformat some lines to meet kernel coding style
v3:
- Add comment forrtl8723bu_set_coex_with_type()
Looks good to me!
Jes
Quoted 21 lines · Chris Chiu
The RTL8723BU suffers the wifi disconnection problem while bluetooth device connected. While wifi is doing tx/rx, the bluetooth will scan without results. This is due to the wifi and bluetooth share the same single antenna for RF communication and they need to have a mechanism to collaborate.
BT information is provided via the packet sent from co-processor to host (C2H). It contains the status of BT but the
rtl8723bu_handle_c2hdose not really handle it. And there's no bluetooth coexistence mechanism to deal with it.This commit adds a workqueue to set the tdma configurations and coefficient table per the parsed bluetooth link status and given wifi connection state. The tdma/coef table comes from the vendor driver code of the RTL8192EU and RTL8723BU. However, this commit is only for single antenna scenario which RTL8192EU is default dual antenna. The
rtl8xxxu_parse_rxdesc24which invokes thehandle_c2his only for 8723b and 8192e so the mechanism is expected to work on both chips with single antenna. Note RTL8192EU dual antenna is not supported.
Quoted 2 lines
Signed-off-by Chris Chiu <[email protected]>Signed-off-by Jes Sorensen <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
e542e66b7c2e rtl8xxxu: add bluetooth co-existence support for single antenna
Signature · 3 lines
https://patchwork.kernel.org/patch/11175575/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches