Skip to contentSkip to conversation

Pinctrl driver for MSM8976 and MSM8956

PATCH In review [email protected] 4 participants 9 messages Oct 5, 2019 – Oct 16, 2019

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

cover Pinctrl driver for MSM8976 and MSM8956

From: AngeloGioacchino Del Regno <[email protected]>

As requested, I'm resending the pinctrl driver for this SoC in a separate patch series, with the changes suggested by Bjorn.

AngeloGioacchino Del Regno (2):
pinctrl: qcom: Add a pinctrl driver for MSM8976 and 8956
dt-bindings: pinctrl: Add MSM8976 driver bindings and documentation

 .../bindings/pinctrl/qcom,msm8976-pinctrl.txt |  183 +++
 drivers/pinctrl/qcom/Kconfig                  |   10 +
 drivers/pinctrl/qcom/Makefile                 |    1 +
 drivers/pinctrl/qcom/pinctrl-msm8976.c        | 1127 +++++++++++++++++
 4 files changed, 1321 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt
 create mode 100644 drivers/pinctrl/qcom/pinctrl-msm8976.c
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/2 pinctrl: qcom: Add a pinctrl driver for MSM8976 and 8956

From: AngeloGioacchino Del Regno <[email protected]>

Add the pinctrl driver to support pin configuration with the pinctrl framework on MSM8976, MSM8956, APQ8056, APQ8076.

---
 drivers/pinctrl/qcom/Kconfig           |   10 +
 drivers/pinctrl/qcom/Makefile          |    1 +
 drivers/pinctrl/qcom/pinctrl-msm8976.c | 1127 ++++++++++++++++++++++++
 3 files changed, 1138 insertions(+)
 create mode 100644 drivers/pinctrl/qcom/pinctrl-msm8976.c
drivers/pinctrl/qcom/Kconfig +10 -0
index 32fc2458b8eb..3fcd6c1fa5ed 100644
@@ -90,6 +90,16 @@ config PINCTRL_MSM8916
 	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
 	  Qualcomm TLMM block found on the Qualcomm 8916 platform.
 
+config PINCTRL_MSM8976
+	tristate "Qualcomm 8976 pin controller driver"
+	depends on GPIOLIB && OF
+	select PINCTRL_MSM
+	help
+	  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
+	  Qualcomm TLMM block found on the Qualcomm MSM8976 platform.
+	  The Qualcomm MSM8956, APQ8056, APQ8076 platforms are also
+	  supported by this driver.
+
 config PINCTRL_MSM8994
 	tristate "Qualcomm 8994 pin controller driver"
 	depends on GPIOLIB && OF
drivers/pinctrl/qcom/Makefile +1 -0
index f8bb0c265381..c2c2f9ad6827 100644
@@ -10,6 +10,7 @@ obj-$(CONFIG_PINCTRL_MSM8660)	+= pinctrl-msm8660.o
 obj-$(CONFIG_PINCTRL_MSM8960)	+= pinctrl-msm8960.o
 obj-$(CONFIG_PINCTRL_MSM8X74)	+= pinctrl-msm8x74.o
 obj-$(CONFIG_PINCTRL_MSM8916)	+= pinctrl-msm8916.o
+obj-$(CONFIG_PINCTRL_MSM8976)	+= pinctrl-msm8976.o
 obj-$(CONFIG_PINCTRL_MSM8994)   += pinctrl-msm8994.o
 obj-$(CONFIG_PINCTRL_MSM8996)   += pinctrl-msm8996.o
 obj-$(CONFIG_PINCTRL_MSM8998)   += pinctrl-msm8998.o
drivers/pinctrl/qcom/pinctrl-msm8976.c new file +1127 -0

1,127 lines not on this page · raw message

Signature · 1 line
2.21.0
#3 lore raw

Re: [PATCH 1/2] pinctrl: qcom: Add a pinctrl driver for MSM8976 and 8956

In reply to [email protected]
Quoted 6 lines · On Sat, Oct 5, 2019 at 12:59 PM <[email protected]> wrote:

From: AngeloGioacchino Del Regno <[email protected]>

Add the pinctrl driver to support pin configuration with the pinctrl framework on MSM8976, MSM8956, APQ8056, APQ8076.

Patch applied with Bjorn's ACK.

Thank you for fixing up these platforms, good job.

Yours,
Linus Walleij

#4 lore raw

PATCH 2/2 dt-bindings: pinctrl: Add MSM8976 driver bindings and documentation

In reply to [email protected]

From: AngeloGioacchino Del Regno <[email protected]>

Add the documentation for this new driver for pin configuration with the pinctrl framework on MSM8976/56 and its APQ variants.

---
 .../bindings/pinctrl/qcom,msm8976-pinctrl.txt | 183 ++++++++++++++++++
 1 file changed, 183 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt
Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt new file +183 -0
new file mode 100644
index 000000000000..70d04d12f136
@@ -0,0 +1,183 @@
+Qualcomm MSM8976 TLMM block
+
+This binding describes the Top Level Mode Multiplexer block found in the
+MSM8956 and MSM8976 platforms.
+
+- compatible:
+	Usage: required
+	Value type: <string>
+	Definition: must be "qcom,msm8976-pinctrl"
+
+- reg:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: the base address and size of the TLMM register space.
+
+- interrupts:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: should specify the TLMM summary IRQ.
+
+- interrupt-controller:
+	Usage: required
+	Value type: <none>
+	Definition: identifies this node as an interrupt controller
+
+- #interrupt-cells:
+	Usage: required
+	Value type: <u32>
+	Definition: must be 2. Specifying the pin number and flags, as defined
+		    in <dt-bindings/interrupt-controller/irq.h>
+
+- gpio-controller:
+	Usage: required
+	Value type: <none>
+	Definition: identifies this node as a gpio controller
+
+- #gpio-cells:
+	Usage: required
+	Value type: <u32>
+	Definition: must be 2. Specifying the pin number and flags, as defined
+		    in <dt-bindings/gpio/gpio.h>
+
+- gpio-ranges:
+	Usage: required
+	Definition:  see ../gpio/gpio.txt
+
+- gpio-reserved-ranges:
+	Usage: optional
+	Definition: see ../gpio/gpio.txt
+
+Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for
+a general description of GPIO and interrupt bindings.
+
+Please refer to pinctrl-bindings.txt in this directory for details of the
+common pinctrl bindings used by client devices, including the meaning of the
+phrase "pin configuration node".
+
+The pin configuration nodes act as a container for an arbitrary number of
+subnodes. Each of these subnodes represents some desired configuration for a
+pin, a group, or a list of pins or groups. This configuration can include the
+mux function to select on those pin(s)/group(s), and various pin configuration
+parameters, such as pull-up, drive strength, etc.
+
+
+PIN CONFIGURATION NODES:
+
+The name of each subnode is not important; all subnodes should be enumerated
+and processed purely based on their content.
+
+Each subnode only affects those parameters that are explicitly listed. In
+other words, a subnode that lists a mux function but no pin configuration
+parameters implies no information about any pin configuration parameters.
+Similarly, a pin subnode that describes a pullup parameter implies no
+information about e.g. the mux function.
+
+
+The following generic properties as defined in pinctrl-bindings.txt are valid
+to specify in a pin configuration subnode:
+
+- pins:
+	Usage: required
+	Value type: <string-array>
+	Definition: List of gpio pins affected by the properties specified in
+		    this subnode.
+
+		    Valid pins are:
+		      gpio0-gpio145
+		        Supports mux, bias and drive-strength
+
+		      sdc1_clk, sdc1_cmd, sdc1_data,
+		      sdc2_clk, sdc2_cmd, sdc2_data,
+		      sdc3_clk, sdc3_cmd, sdc3_data
+		        Supports bias and drive-strength
+
+- function:
+	Usage: required
+	Value type: <string>
+	Definition: Specify the alternative function to be configured for the
+		    specified pins. Functions are only valid for gpio pins.
+		    Valid values are:
+
+		    gpio, blsp_uart1, blsp_spi1, smb_int, blsp_i2c1, blsp_spi2,
+		    blsp_uart2, blsp_i2c2, gcc_gp1_clk_b, blsp_spi3,
+		    qdss_tracedata_b, blsp_i2c3, gcc_gp2_clk_b, gcc_gp3_clk_b,
+		    blsp_spi4, cap_int, blsp_i2c4, blsp_spi5, blsp_uart5,
+		    qdss_traceclk_a, m_voc, blsp_i2c5, qdss_tracectl_a,
+		    qdss_tracedata_a, blsp_spi6, blsp_uart6, qdss_tracectl_b,
+		    blsp_i2c6, qdss_traceclk_b, mdp_vsync, pri_mi2s_mclk_a,
+		    sec_mi2s_mclk_a, cam_mclk, cci0_i2c, cci1_i2c, blsp1_spi,
+		    blsp3_spi, gcc_gp1_clk_a, gcc_gp2_clk_a, gcc_gp3_clk_a,
+		    uim_batt, sd_write, uim1_data, uim1_clk, uim1_reset,
+		    uim1_present, uim2_data, uim2_clk, uim2_reset,
+		    uim2_present, ts_xvdd, mipi_dsi0, us_euro, ts_resout,
+		    ts_sample, sec_mi2s_mclk_b, pri_mi2s, codec_reset,
+		    cdc_pdm0, us_emitter, pri_mi2s_mclk_b, pri_mi2s_mclk_c,
+		    lpass_slimbus, lpass_slimbus0, lpass_slimbus1, codec_int1,
+		    codec_int2, wcss_bt, sdc3, wcss_wlan2, wcss_wlan1,
+		    wcss_wlan0, wcss_wlan, wcss_fm, key_volp, key_snapshot,
+		    key_focus, key_home, pwr_down, dmic0_clk, hdmi_int,
+		    dmic0_data, wsa_vi, wsa_en, blsp_spi8, wsa_irq, blsp_i2c8,
+		    pa_indicator, modem_tsync, ssbi_wtr1, gsm1_tx, gsm0_tx,
+		    sdcard_det, sec_mi2s, ss_switch,
+
+- bias-disable:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configured as no pull.
+
+- bias-pull-down:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configured as pull down.
+
+- bias-pull-up:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configured as pull up.
+
+- output-high:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins are configured in output mode, driven
+		    high.
+		    Not valid for sdc pins.
+
+- output-low:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins are configured in output mode, driven
+		    low.
+		    Not valid for sdc pins.
+
+- drive-strength:
+	Usage: optional
+	Value type: <u32>
+	Definition: Selects the drive strength for the specified pins, in mA.
+		    Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16
+
+Example:
+
+	tlmm: pinctrl@1000000 {
+		compatible = "qcom,msm8976-pinctrl";
+		reg = <0x1000000 0x300000>;
+		interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-ranges = <&tlmm 0 0 145>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+
+		blsp1_uart2_active: blsp1_uart2_active {
+			mux {
+				pins = "gpio4", "gpio5", "gpio6", "gpio7";
+				function = "blsp_uart2";
+			};
+
+			config {
+				pins = "gpio4", "gpio5", "gpio6", "gpio7";
+				drive-strength = <2>;
+				bias-disable;
+			};
+		};
+	};
Signature · 1 line
2.21.0
Reviewed-by on v1 2/2
#5 lore raw

Re: [PATCH 2/2] dt-bindings: pinctrl: Add MSM8976 driver bindings and documentation

Quoted 4 lines · On Sat 05 Oct 03:59 PDT 2019, [email protected] wrote:

From: AngeloGioacchino Del Regno <[email protected]>

Add the documentation for this new driver for pin configuration with the pinctrl framework on MSM8976/56 and its APQ variants.

You forgot your Signed-off-by on this patch.

Regards,
Bjorn

Quoted 197 lines
---
 .../bindings/pinctrl/qcom,msm8976-pinctrl.txt | 183 ++++++++++++++++++
 1 file changed, 183 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt
Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt new file +183 -0
new file mode 100644
index 000000000000..70d04d12f136
@@ -0,0 +1,183 @@
+Qualcomm MSM8976 TLMM block
+
+This binding describes the Top Level Mode Multiplexer block found in the
+MSM8956 and MSM8976 platforms.
+
+- compatible:
+	Usage: required
+	Value type: <string>
+	Definition: must be "qcom,msm8976-pinctrl"
+
+- reg:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: the base address and size of the TLMM register space.
+
+- interrupts:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: should specify the TLMM summary IRQ.
+
+- interrupt-controller:
+	Usage: required
+	Value type: <none>
+	Definition: identifies this node as an interrupt controller
+
+- #interrupt-cells:
+	Usage: required
+	Value type: <u32>
+	Definition: must be 2. Specifying the pin number and flags, as defined
+		    in <dt-bindings/interrupt-controller/irq.h>
+
+- gpio-controller:
+	Usage: required
+	Value type: <none>
+	Definition: identifies this node as a gpio controller
+
+- #gpio-cells:
+	Usage: required
+	Value type: <u32>
+	Definition: must be 2. Specifying the pin number and flags, as defined
+		    in <dt-bindings/gpio/gpio.h>
+
+- gpio-ranges:
+	Usage: required
+	Definition:  see ../gpio/gpio.txt
+
+- gpio-reserved-ranges:
+	Usage: optional
+	Definition: see ../gpio/gpio.txt
+
+Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for
+a general description of GPIO and interrupt bindings.
+
+Please refer to pinctrl-bindings.txt in this directory for details of the
+common pinctrl bindings used by client devices, including the meaning of the
+phrase "pin configuration node".
+
+The pin configuration nodes act as a container for an arbitrary number of
+subnodes. Each of these subnodes represents some desired configuration for a
+pin, a group, or a list of pins or groups. This configuration can include the
+mux function to select on those pin(s)/group(s), and various pin configuration
+parameters, such as pull-up, drive strength, etc.
+
+
+PIN CONFIGURATION NODES:
+
+The name of each subnode is not important; all subnodes should be enumerated
+and processed purely based on their content.
+
+Each subnode only affects those parameters that are explicitly listed. In
+other words, a subnode that lists a mux function but no pin configuration
+parameters implies no information about any pin configuration parameters.
+Similarly, a pin subnode that describes a pullup parameter implies no
+information about e.g. the mux function.
+
+
+The following generic properties as defined in pinctrl-bindings.txt are valid
+to specify in a pin configuration subnode:
+
+- pins:
+	Usage: required
+	Value type: <string-array>
+	Definition: List of gpio pins affected by the properties specified in
+		    this subnode.
+
+		    Valid pins are:
+		      gpio0-gpio145
+		        Supports mux, bias and drive-strength
+
+		      sdc1_clk, sdc1_cmd, sdc1_data,
+		      sdc2_clk, sdc2_cmd, sdc2_data,
+		      sdc3_clk, sdc3_cmd, sdc3_data
+		        Supports bias and drive-strength
+
+- function:
+	Usage: required
+	Value type: <string>
+	Definition: Specify the alternative function to be configured for the
+		    specified pins. Functions are only valid for gpio pins.
+		    Valid values are:
+
+		    gpio, blsp_uart1, blsp_spi1, smb_int, blsp_i2c1, blsp_spi2,
+		    blsp_uart2, blsp_i2c2, gcc_gp1_clk_b, blsp_spi3,
+		    qdss_tracedata_b, blsp_i2c3, gcc_gp2_clk_b, gcc_gp3_clk_b,
+		    blsp_spi4, cap_int, blsp_i2c4, blsp_spi5, blsp_uart5,
+		    qdss_traceclk_a, m_voc, blsp_i2c5, qdss_tracectl_a,
+		    qdss_tracedata_a, blsp_spi6, blsp_uart6, qdss_tracectl_b,
+		    blsp_i2c6, qdss_traceclk_b, mdp_vsync, pri_mi2s_mclk_a,
+		    sec_mi2s_mclk_a, cam_mclk, cci0_i2c, cci1_i2c, blsp1_spi,
+		    blsp3_spi, gcc_gp1_clk_a, gcc_gp2_clk_a, gcc_gp3_clk_a,
+		    uim_batt, sd_write, uim1_data, uim1_clk, uim1_reset,
+		    uim1_present, uim2_data, uim2_clk, uim2_reset,
+		    uim2_present, ts_xvdd, mipi_dsi0, us_euro, ts_resout,
+		    ts_sample, sec_mi2s_mclk_b, pri_mi2s, codec_reset,
+		    cdc_pdm0, us_emitter, pri_mi2s_mclk_b, pri_mi2s_mclk_c,
+		    lpass_slimbus, lpass_slimbus0, lpass_slimbus1, codec_int1,
+		    codec_int2, wcss_bt, sdc3, wcss_wlan2, wcss_wlan1,
+		    wcss_wlan0, wcss_wlan, wcss_fm, key_volp, key_snapshot,
+		    key_focus, key_home, pwr_down, dmic0_clk, hdmi_int,
+		    dmic0_data, wsa_vi, wsa_en, blsp_spi8, wsa_irq, blsp_i2c8,
+		    pa_indicator, modem_tsync, ssbi_wtr1, gsm1_tx, gsm0_tx,
+		    sdcard_det, sec_mi2s, ss_switch,
+
+- bias-disable:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configured as no pull.
+
+- bias-pull-down:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configured as pull down.
+
+- bias-pull-up:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins should be configured as pull up.
+
+- output-high:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins are configured in output mode, driven
+		    high.
+		    Not valid for sdc pins.
+
+- output-low:
+	Usage: optional
+	Value type: <none>
+	Definition: The specified pins are configured in output mode, driven
+		    low.
+		    Not valid for sdc pins.
+
+- drive-strength:
+	Usage: optional
+	Value type: <u32>
+	Definition: Selects the drive strength for the specified pins, in mA.
+		    Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16
+
+Example:
+
+	tlmm: pinctrl@1000000 {
+		compatible = "qcom,msm8976-pinctrl";
+		reg = <0x1000000 0x300000>;
+		interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-ranges = <&tlmm 0 0 145>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+
+		blsp1_uart2_active: blsp1_uart2_active {
+			mux {
+				pins = "gpio4", "gpio5", "gpio6", "gpio7";
+				function = "blsp_uart2";
+			};
+
+			config {
+				pins = "gpio4", "gpio5", "gpio6", "gpio7";
+				drive-strength = <2>;
+				bias-disable;
+			};
+		};
+	};
Signature · 1 line
2.21.0
#6 lore raw

Re: [PATCH 2/2] dt-bindings: pinctrl: Add MSM8976 driver bindings and documentation

Il giorno lun 7 ott 2019 alle ore 07:56 Bjorn Andersson <[email protected]> ha scritto:

Quoted 8 lines · On Sat 05 Oct 03:59 PDT 2019, [email protected] wrote:
Quoted 5 lines

From: AngeloGioacchino Del Regno <[email protected]>

Add the documentation for this new driver for pin configuration with the pinctrl framework on MSM8976/56 and its APQ variants.

Quoted 7 lines

You forgot your Signed-off-by on this patch.

Regards,
Bjorn

Oops! That was totally unintentional.
I don't know how should I proceed in these cases but seems overkill to resend the entire thing just to add the tag. If I have to then I will, otherwise, whoever
will apply this, please feel free to add my

Thanks,
Angelo

Quoted 197 lines
Quoted 197 lines
---
 .../bindings/pinctrl/qcom,msm8976-pinctrl.txt | 183 ++++++++++++++++++
 1 file changed, 183 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt
Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt new file +183 -1
new file mode 100644
index 000000000000..70d04d12f136
@@ -0,0 +1,183 @@
+Qualcomm MSM8976 TLMM block
+
+This binding describes the Top Level Mode Multiplexer block found in the
+MSM8956 and MSM8976 platforms.
+
+- compatible:
+     Usage: required
+     Value type: <string>
+     Definition: must be "qcom,msm8976-pinctrl"
+
+- reg:
+     Usage: required
+     Value type: <prop-encoded-array>
+     Definition: the base address and size of the TLMM register space.
+
+- interrupts:
+     Usage: required
+     Value type: <prop-encoded-array>
+     Definition: should specify the TLMM summary IRQ.
+
+- interrupt-controller:
+     Usage: required
+     Value type: <none>
+     Definition: identifies this node as an interrupt controller
+
+- #interrupt-cells:
+     Usage: required
+     Value type: <u32>
+     Definition: must be 2. Specifying the pin number and flags, as defined
+                 in <dt-bindings/interrupt-controller/irq.h>
+
+- gpio-controller:
+     Usage: required
+     Value type: <none>
+     Definition: identifies this node as a gpio controller
+
+- #gpio-cells:
+     Usage: required
+     Value type: <u32>
+     Definition: must be 2. Specifying the pin number and flags, as defined
+                 in <dt-bindings/gpio/gpio.h>
+
+- gpio-ranges:
+     Usage: required
+     Definition:  see ../gpio/gpio.txt
+
+- gpio-reserved-ranges:
+     Usage: optional
+     Definition: see ../gpio/gpio.txt
+
+Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for
+a general description of GPIO and interrupt bindings.
+
+Please refer to pinctrl-bindings.txt in this directory for details of the
+common pinctrl bindings used by client devices, including the meaning of the
+phrase "pin configuration node".
+
+The pin configuration nodes act as a container for an arbitrary number of
+subnodes. Each of these subnodes represents some desired configuration for a
+pin, a group, or a list of pins or groups. This configuration can include the
+mux function to select on those pin(s)/group(s), and various pin configuration
+parameters, such as pull-up, drive strength, etc.
+
+
+PIN CONFIGURATION NODES:
+
+The name of each subnode is not important; all subnodes should be enumerated
+and processed purely based on their content.
+
+Each subnode only affects those parameters that are explicitly listed. In
+other words, a subnode that lists a mux function but no pin configuration
+parameters implies no information about any pin configuration parameters.
+Similarly, a pin subnode that describes a pullup parameter implies no
+information about e.g. the mux function.
+
+
+The following generic properties as defined in pinctrl-bindings.txt are valid
+to specify in a pin configuration subnode:
+
+- pins:
+     Usage: required
+     Value type: <string-array>
+     Definition: List of gpio pins affected by the properties specified in
+                 this subnode.
+
+                 Valid pins are:
+                   gpio0-gpio145
+                     Supports mux, bias and drive-strength
+
+                   sdc1_clk, sdc1_cmd, sdc1_data,
+                   sdc2_clk, sdc2_cmd, sdc2_data,
+                   sdc3_clk, sdc3_cmd, sdc3_data
+                     Supports bias and drive-strength
+
+- function:
+     Usage: required
+     Value type: <string>
+     Definition: Specify the alternative function to be configured for the
+                 specified pins. Functions are only valid for gpio pins.
+                 Valid values are:
+
+                 gpio, blsp_uart1, blsp_spi1, smb_int, blsp_i2c1, blsp_spi2,
+                 blsp_uart2, blsp_i2c2, gcc_gp1_clk_b, blsp_spi3,
+                 qdss_tracedata_b, blsp_i2c3, gcc_gp2_clk_b, gcc_gp3_clk_b,
+                 blsp_spi4, cap_int, blsp_i2c4, blsp_spi5, blsp_uart5,
+                 qdss_traceclk_a, m_voc, blsp_i2c5, qdss_tracectl_a,
+                 qdss_tracedata_a, blsp_spi6, blsp_uart6, qdss_tracectl_b,
+                 blsp_i2c6, qdss_traceclk_b, mdp_vsync, pri_mi2s_mclk_a,
+                 sec_mi2s_mclk_a, cam_mclk, cci0_i2c, cci1_i2c, blsp1_spi,
+                 blsp3_spi, gcc_gp1_clk_a, gcc_gp2_clk_a, gcc_gp3_clk_a,
+                 uim_batt, sd_write, uim1_data, uim1_clk, uim1_reset,
+                 uim1_present, uim2_data, uim2_clk, uim2_reset,
+                 uim2_present, ts_xvdd, mipi_dsi0, us_euro, ts_resout,
+                 ts_sample, sec_mi2s_mclk_b, pri_mi2s, codec_reset,
+                 cdc_pdm0, us_emitter, pri_mi2s_mclk_b, pri_mi2s_mclk_c,
+                 lpass_slimbus, lpass_slimbus0, lpass_slimbus1, codec_int1,
+                 codec_int2, wcss_bt, sdc3, wcss_wlan2, wcss_wlan1,
+                 wcss_wlan0, wcss_wlan, wcss_fm, key_volp, key_snapshot,
+                 key_focus, key_home, pwr_down, dmic0_clk, hdmi_int,
+                 dmic0_data, wsa_vi, wsa_en, blsp_spi8, wsa_irq, blsp_i2c8,
+                 pa_indicator, modem_tsync, ssbi_wtr1, gsm1_tx, gsm0_tx,
+                 sdcard_det, sec_mi2s, ss_switch,
+
+- bias-disable:
+     Usage: optional
+     Value type: <none>
+     Definition: The specified pins should be configured as no pull.
+
+- bias-pull-down:
+     Usage: optional
+     Value type: <none>
+     Definition: The specified pins should be configured as pull down.
+
+- bias-pull-up:
+     Usage: optional
+     Value type: <none>
+     Definition: The specified pins should be configured as pull up.
+
+- output-high:
+     Usage: optional
+     Value type: <none>
+     Definition: The specified pins are configured in output mode, driven
+                 high.
+                 Not valid for sdc pins.
+
+- output-low:
+     Usage: optional
+     Value type: <none>
+     Definition: The specified pins are configured in output mode, driven
+                 low.
+                 Not valid for sdc pins.
+
+- drive-strength:
+     Usage: optional
+     Value type: <u32>
+     Definition: Selects the drive strength for the specified pins, in mA.
+                 Valid values are: 2, 4, 6, 8, 10, 12, 14 and 16
+
+Example:
+
+     tlmm: pinctrl@1000000 {
+             compatible = "qcom,msm8976-pinctrl";
+             reg = <0x1000000 0x300000>;
+             interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+             gpio-controller;
+             #gpio-cells = <2>;
+             gpio-ranges = <&tlmm 0 0 145>;
+             interrupt-controller;
+             #interrupt-cells = <2>;
+
+             blsp1_uart2_active: blsp1_uart2_active {
+                     mux {
+                             pins = "gpio4", "gpio5", "gpio6", "gpio7";
+                             function = "blsp_uart2";
+                     };
+
+                     config {
+                             pins = "gpio4", "gpio5", "gpio6", "gpio7";
+                             drive-strength = <2>;
+                             bias-disable;
+                     };
+             };
+     };
--

2.21.0

maintainer Reviewed-by on v1 2/2
#7 lore raw

Re: [PATCH 2/2] dt-bindings: pinctrl: Add MSM8976 driver bindings and documentation

In reply to [email protected]
Quoted 9 lines · On Sat, 5 Oct 2019 12:59:36 +0200, [email protected] wrote:

From: AngeloGioacchino Del Regno <[email protected]>

Add the documentation for this new driver for pin configuration with the pinctrl framework on MSM8976/56 and its APQ variants.

---
 .../bindings/pinctrl/qcom,msm8976-pinctrl.txt | 183 ++++++++++++++++++
 1 file changed, 183 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,msm8976-pinctrl.txt
#8 lore raw

Re: [PATCH 2/2] dt-bindings: pinctrl: Add MSM8976 driver bindings and documentation

In reply to [email protected]
Quoted 4 lines · On Sat, Oct 5, 2019 at 12:59 PM <[email protected]> wrote:

From: AngeloGioacchino Del Regno <[email protected]>

Add the documentation for this new driver for pin configuration with the pinctrl framework on MSM8976/56 and its APQ variants.

Fixed up the tags including SoB and applied!

Thanks!
Linus Walleij