Skip to contentSkip to conversation

backlight: lm3630a: fix module aliases

PATCH In review Andreas Kemnade 2 participants 3 messages Sep 10, 2019 – Oct 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 backlight: lm3630a: fix module aliases

Devicetree aliases are missing, so that module autoloading does not work properly.

---
 drivers/video/backlight/lm3630a_bl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/video/backlight/lm3630a_bl.c +3 -1
index 3b45a1733198..9d67c07db2f2 100644
@@ -617,12 +617,14 @@ static const struct i2c_device_id lm3630a_id[] = {
 	{}
 };
 
+MODULE_DEVICE_TABLE(i2c, lm3630a_id);
+
 static const struct of_device_id lm3630a_match_table[] = {
 	{ .compatible = "ti,lm3630a", },
 	{ },
 };
 
-MODULE_DEVICE_TABLE(i2c, lm3630a_id);
+MODULE_DEVICE_TABLE(of, lm3630a_match_table);
 
 static struct i2c_driver lm3630a_i2c_driver = {
 	.driver = {
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Andreas Kemnade

Devicetree aliases are missing, so that module autoloading does not work properly.

Quoted 27 lines
---
 drivers/video/backlight/lm3630a_bl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/video/backlight/lm3630a_bl.c +3 -1
index 3b45a1733198..9d67c07db2f2 100644
@@ -617,12 +617,14 @@ static const struct i2c_device_id lm3630a_id[] = {
 	{}
 };
 
+MODULE_DEVICE_TABLE(i2c, lm3630a_id);
+
 static const struct of_device_id lm3630a_match_table[] = {
 	{ .compatible = "ti,lm3630a", },
 	{ },
 };
 
-MODULE_DEVICE_TABLE(i2c, lm3630a_id);
+MODULE_DEVICE_TABLE(of, lm3630a_match_table);
 
 static struct i2c_driver lm3630a_i2c_driver = {
 	.driver = {
Signature · 1 line
2.11.0
#2 lore raw

Hi,

hmm, this bugfix has not arrived in -next or any -fixes branch I am aware of yet. I hope it is not forgotten...
so a friendly ping.

Regards,
Andreas

Quoted 37 lines · On Wed, 11 Sep 2019 11:51:48 +0100 Daniel Thompson…
Quoted 4 lines · Andreas Kemnade

Devicetree aliases are missing, so that module autoloading does not work properly.

Quoted 27 lines
---
 drivers/video/backlight/lm3630a_bl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/video/backlight/lm3630a_bl.c +3 -1
index 3b45a1733198..9d67c07db2f2 100644
@@ -617,12 +617,14 @@ static const struct i2c_device_id lm3630a_id[] = {
 	{}
 };
 
+MODULE_DEVICE_TABLE(i2c, lm3630a_id);
+
 static const struct of_device_id lm3630a_match_table[] = {
 	{ .compatible = "ti,lm3630a", },
 	{ },
 };
 
-MODULE_DEVICE_TABLE(i2c, lm3630a_id);
+MODULE_DEVICE_TABLE(of, lm3630a_match_table);
 
 static struct i2c_driver lm3630a_i2c_driver = {
 	.driver = {
Signature · 1 line
2.11.0