net: dsa: b53: Do not clear existing mirrored port mask
PATCH 1/1 net: dsa: b53: Do not clear existing mirrored port mask
Clearing the existing bitmask of mirrored ports essentially prevents us from capturing more than one port at any given time. This is clearly wrong, do not clear the bitmask prior to setting up the new port.
--- drivers/net/dsa/b53/b53_common.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/dsa/b53/b53_common.c +0 -1
@@ -1845,7 +1845,6 @@ int b53_mirror_add(struct dsa_switch *ds, int port, loc =B53_EG_MIR_CTL ;b53_read16 (dev,B53_MGMT_PAGE , loc, ®); - reg &= ~MIRROR_MASK ; reg |=BIT (port);b53_write16 (dev,B53_MGMT_PAGE , loc, reg);
Signature · 1 line
2.17.1
Quoted 7 lines · Florian Fainelli
Clearing the existing bitmask of mirrored ports essentially prevents us from capturing more than one port at any given time. This is clearly wrong, do not clear the bitmask prior to setting up the new port.
Reported-by Hubert Feurstein <[email protected]>Fixes ed3af5fd08eb ("net: dsa: b53: Add support for port mirroring")Signed-off-by Florian Fainelli <[email protected]>
David Miller
maintainerFrom: Florian Fainelli <[email protected]>
Date: Sat, 5 Oct 2019 15:05:18 -0700
Quoted 7 lines
Clearing the existing bitmask of mirrored ports essentially prevents us from capturing more than one port at any given time. This is clearly wrong, do not clear the bitmask prior to setting up the new port.
Reported-by Hubert Feurstein <[email protected]>Fixes ed3af5fd08eb ("net: dsa: b53: Add support for port mirroring")Signed-off-by Florian Fainelli <[email protected]>
Applied and queued up for -stable, thanks.