Skip to contentSkip to conversation

initcall.h: initcall_run_list(): Improve debug output

PATCH New Ovidiu Panait 2 participants 2 messages Sep 25, 2019 – Oct 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 initcall.h: initcall_run_list(): Improve debug output

From: Ovidiu Panait <[email protected]>

Existing debug output is mixed with the function name:
initcall_run_list() initcall: 25263initcall_run_list() (relocated to 425263)

Turn it to:
initcall_run_list() initcall: 25263 (relocated to 425263)

---
 include/initcall.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
include/initcall.h +5 -3
index 78d15afe69..b5acdd01bd 100644
@@ -30,11 +30,13 @@ static inline int initcall_run_list(const init_fnc_t init_sequence[])
 #ifdef CONFIG_EFI_APP
 		reloc_ofs = (unsigned long)image_base;
 #endif
-		debug("initcall: %p", (char *)*init_fnc_ptr - reloc_ofs);
 		if (reloc_ofs)
-			debug(" (relocated to %p)\n", (char *)*init_fnc_ptr);
+			debug("initcall: %p (relocated to %p)\n",
+					(char *)*init_fnc_ptr - reloc_ofs,
+					(char *)*init_fnc_ptr);
 		else
-			debug("\n");
+			debug("initcall: %p\n", (char *)*init_fnc_ptr - reloc_ofs);
+
 		ret = (*init_fnc_ptr)();
 		if (ret) {
 			printf("initcall sequence %p failed at call %p (err=%d)\n",
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 initcall.h: initcall_run_list(): Improve debug output

Quoted 9 lines · Ovidiu Panait

From: Ovidiu Panait <[email protected]>

Existing debug output is mixed with the function name:
initcall_run_list() initcall: 25263initcall_run_list() (relocated to 425263)

Turn it to:
initcall_run_list() initcall: 25263 (relocated to 425263)

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191005/ed8a9b47/attachment.sig>