Skip to contentSkip to conversation

tools: provide cbfstool

PATCH New Tom Rini 2 participants 3 messages Oct 6, 2019 – Oct 10, 2019 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Tom Rini

author
#1 lore raw

PATCH 1/1 tools: provide cbfstool

Quoted 9 lines · Heinrich Schuchardt

'make tests' requires cbfstool. But this file is not built by U-Boot.

cbfstool can be built from https://github.com/coreboot/coreboot.git
after copying some include files from
https://github.com/coreboot/vboot.git but that is to much of a hassle.

Let's deliver cbfstool with U-Boot.

I do not want to bundle yet another "thing" from another project that will require re-syncing. We already frankly have problems with too many things getting out-of-date (and making a regular re-sync is on my TODO list, but below removing python2 from our build).

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191006/bde19aa5/attachment.sig>
#2 lore raw

PATCH 1/1 tools: provide cbfstool

Hi,

Quoted 4 lines · Tom Rini
Quoted 1 line · Heinrich Schuchardt

'make tests' requires cbfstool. But this file is not built by U-Boot.

If so this is a bug. The tests are supposed to detect that cbfstool is missing and skip the comparison tests if so.

Quoted 9 lines
Quoted 8 lines

cbfstool can be built from https://github.com/coreboot/coreboot.git
after copying some include files from
https://github.com/coreboot/vboot.git but that is to much of a hassle.

Let's deliver cbfstool with U-Boot.

Quoted 7 lines

I do not want to bundle yet another "thing" from another project that will require re-syncing. We already frankly have problems with too many things getting out-of-date (and making a regular re-sync is on my TODO list, but below removing python2 from our build).

--
Tom

Regards,
Simon

author
#3 lore raw

PATCH 1/1 tools: provide cbfstool

Quoted 10 lines · Simon Glass

Hi,

Quoted 4 lines · Tom Rini
Quoted 1 line · Heinrich Schuchardt

'make tests' requires cbfstool. But this file is not built by U-Boot.

If so this is a bug. The tests are supposed to detect that cbfstool is missing and skip the comparison tests if so.

Right. To be clearer, these tests are not as useful as we would like as the CI loops do not run them. We could more easily jam this in to GitLab (since we control the host environment) but then we have different coverage in GitLab vs Travis, which is not ideal.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191010/fa1bfa0d/attachment.sig>