staging: rtl8723bs: Remove unnecessary braces
PATCH 1/1 staging: rtl8723bs: Remove unnecessary braces
Remove braces that are not necessary for any arm of this statement. Issue found by checkpatch.
--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_xmit.c +2 -3
@@ -3063,9 +3063,8 @@ void rtw_ack_tx_done(struct xmit_priv *pxmitpriv, int status) {struct submit_ctx *pack_tx_ops = &pxmitpriv->ack_tx_ops; -if (pxmitpriv->ack_tx) { +if (pxmitpriv->ack_tx)rtw_sctx_done_err (&pack_tx_ops, status); - }else { +else DBG_871X ("%s ack_tx not set\n" , __func__); - } }
Signature · 1 line
2.20.1
Quoted 2 lines · Javier F. Arias
Remove braces that are not necessary for any arm of this statement. Issue found by checkpatch.
It may have been that the DBG call could disappear in some configuration, in which case the braces would have been necessary. But even when debugging is not wanted, the DBG... macro generates a do while, so the braces are indeed not needed.
julia
Quoted 30 lines
Signed-off-by Javier F. Arias <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/rtl8723bs/core/rtw_xmit.c +2
-4@@ -3063,9 +3063,8 @@ void rtw_ack_tx_done(struct xmit_priv *pxmitpriv, int status) {struct submit_ctx *pack_tx_ops = &pxmitpriv->ack_tx_ops; -if (pxmitpriv->ack_tx) { +if (pxmitpriv->ack_tx)rtw_sctx_done_err (&pack_tx_ops, status); - }else { +else DBG_871X ("%s ack_tx not set\n" , __func__); - } } --2.20.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191006230327.GA4168%40gmail.com.