Skip to contentSkip to conversation

net: devlink: fix reporter dump dumpit

PATCH Applied Jiri Pirko 2 participants 2 messages Oct 7, 2019

Subsystems (2)
lore
Share & tools
lore

Jiri Pirko

author
#0 lore raw

PATCH 1/1 net: devlink: fix reporter dump dumpit

From: Jiri Pirko <[email protected]>

In order for attrs to be prepared for reporter dump dumpit callback, set GENL_DONT_VALIDATE_DUMP_STRICT instead of GENL_DONT_VALIDATE_DUMP.

Fixes ee85da535fe3 ("devlink: have genetlink code to parse the attrs during dumpit"
---
 net/core/devlink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/core/devlink.c +2 -1
index 22f59461b0c1..eb0a22f05887 100644
@@ -6176,7 +6176,8 @@ static const struct genl_ops devlink_nl_ops[] = {
 	},
 	{
 		.cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET,
-		.validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
+		.validate = GENL_DONT_VALIDATE_STRICT |
+			    GENL_DONT_VALIDATE_DUMP_STRICT,
 		.dumpit = devlink_nl_cmd_health_reporter_dump_get_dumpit,
 		.flags = GENL_ADMIN_PERM,
 		.internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK |
Signature · 1 line
2.21.0
maintainer Applied
#1 lore raw

From: Jiri Pirko <[email protected]>
Date: Mon, 7 Oct 2019 09:28:31 +0200

Quoted 7 lines

From: Jiri Pirko <[email protected]>

In order for attrs to be prepared for reporter dump dumpit callback, set GENL_DONT_VALIDATE_DUMP_STRICT instead of GENL_DONT_VALIDATE_DUMP.

Fixes ee85da535fe3 ("devlink: have genetlink code to parse the attrs during dumpit"

Applied, thanks.